This revision was automatically updated to reflect the committed changes.
Closed by commit rL316992: Add data formatter for libc++'s forward_list
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D35556?vs=120491&id=120961#toc
Repository:
rL LLVM
https://reviews.llvm.o
labath added a comment.
Thanks.
By the way, I have a couple of other patches lined up that you probably did not
notice:
https://reviews.llvm.org/D35666
https://reviews.llvm.org/D35615
https://reviews.llvm.org/D35305
https://reviews.llvm.org/D35556
___
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Great, this is much nicer.
Comment at: source/Plugins/Language/CPlusPlus/LibCxxList.cpp:141
-namespace lldb_private {
-namespace formatters {
-class LibcxxStdListSyntheti
labath updated this revision to Diff 120491.
labath marked 4 inline comments as done.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D35556
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/forward_list/Makefile
packa
labath marked 5 inline comments as done.
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/forward_list/main.cpp:5
+{
+ std::forward_list empty{}, one_elt{47}, five_elts{1,22,333,,5};
+ ret
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
It looks like the behavior of the two derived list classes here are only
partially factored out. See the individual comments but it looks like there is
a lot more that could be sh
jingham added a comment.
Will do. I was sick all last week so I have a bit of a backlog, I'll get to
this as soon as I can.
https://reviews.llvm.org/D35556
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
labath added a comment.
Hey Jim,
I wrote a couple of new libc++ data formatters in july. You seem to be the data
formatter owner nowadays. Would you mind taking a look?
https://reviews.llvm.org/D35556
___
lldb-commits mailing list
lldb-commits@lis
labath created this revision.
Herald added a subscriber: srhines.
Herald added a reviewer: EricWF.
This adds a data formatter for the implementation of forward_list in
libc++. I've refactored the existing std::list data formatter a bit to
enable more sharing of code (mainly the loop detection stuf
