This revision was automatically updated to reflect the committed changes.
Closed by commit rL312431: Add test case for attach-by-pid from different cwd
(authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D32522?vs=113067&id=113671#toc
Repository:
rL LLVM
https://reviews.
emaste added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:44
+"""Test attach by process id"""
+os.mkdir(os.path.join(os.getcwd(),'newdir'))
+
self.buildProgram('main.cpp',os.path.join(os.g
emaste added a comment.
Testing this just now I got:
FAIL: LLDB (/usr/bin/cc-x86_64) ::
test_attach_to_process_from_different_dir_by_id
(TestProcessAttach.ProcessAttachTestCase)
==
ERROR: test_attach_to_process
vbalu updated this revision to Diff 113067.
vbalu marked 2 inline comments as done.
vbalu added a comment.
done changes as ssuggested
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
Index:
packages/Python/lldbsuite/
emaste added a comment.
Ping for two open questions
https://reviews.llvm.org/D32522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste added a comment.
Generally LGTM with two questions inline.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:45
+os.mkdir(os.path.join(os.getcwd(),'newdir'))
+self.buildProgram('main.cpp','newdir/proc_attach')
vbalu updated this revision to Diff 100579.
vbalu added a comment.
Modified as suggested. sorry for the delay, i caught up in other work. Please
let me know if something goes wrong.
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProc
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:47
+exe = os.path.join('.','newdir','proc_attach')
+self.addTearDownHook(lambda: shutil.rmtree(os.path.join(os.getcwd(
+
-
emaste added a comment.
Two small nits noted inline, but now the test does not pass without
https://reviews.llvm.org/D32271 and does with it. Note that in the "without"
case it returned error rather than failing, perhaps related to the path issue I
noted?
Other than that issue I think this is
you mean like this "exe = os.path.join('./newdir/','proc_attach')". I can't
use "os.getcwd" as it will become the absolute path which we should not use.
thanks,
vbalu
On Wed, May 3, 2017 at 11:51 AM, Zachary Turner wrote:
> Can you rewrite the exe path computation to use os.path.join so we're n
vbalu updated this revision to Diff 97575.
vbalu marked an inline comment as done.
vbalu added a comment.
modified exe path computation
Repository:
rL LLVM
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
Index:
p
On 3 May 2017 at 07:41, vignesh balu wrote:
> you mean like this "exe = os.path.join('./newdir/','proc_attach')". I can't
probably something like: os.path.join('.', 'newdir', 'proc_attach')
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
Can you rewrite the exe path computation to use os.path.join so we're not
assuming posix syntax?
On Tue, May 2, 2017 at 11:11 PM vignesh balu via Phabricator via
lldb-commits wrote:
> vbalu updated this revision to Diff 97550.
> vbalu added a comment.
>
> Corrected the code. Now this test will fa
vbalu updated this revision to Diff 97550.
vbalu added a comment.
Corrected the code. Now this test will fail without
https://reviews.llvm.org/D32271 patch.
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
Index:
pa
emaste requested changes to this revision.
emaste added a comment.
This revision now requires changes to proceed.
This test passes even without the change in https://reviews.llvm.org/D32271,
presumably because `exe = os.path.join(os.getcwd(), 'newdir/proc_attach')` is
providing us with an absolu
emaste added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:43
+ def test_attach_to_process_frm_different_dir_by_id(self):
+ """Test attach by process id"""
+os.mkdir(os.path.join(os.get
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Cool. Thank you.
https://reviews.llvm.org/D32522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
vbalu updated this revision to Diff 96878.
vbalu added a comment.
Removed the changes from test frame work.
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
Index:
packages/Python/lldbsuite/test/functionalities/proce
labath added a comment.
Thank you for taking the time to add the test.
I'd like to avoid modifying the test framework for the sake of this test, if
that is possible.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1487
'EXE': exe_name}
+if not os.
vbalu created this revision.
Adding test case to test the scenario in https://reviews.llvm.org/D3
Repository:
rL LLVM
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
packages/Python/lldbsuite/test/lldbtest.py
In
20 matches
Mail list logo
