This revision was automatically updated to reflect the committed changes.
Closed by commit rL297095: Remove FileSpec::ReadFileContents. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D30622?vs=90617&id=90759#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30622
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great. One thing I'd consider is adding a function which returns the data
buffer as a StringRef (`AsStringRef()` ?) instead of the GetChars function, but
I don't feel strongly about it.
zturner created this revision.
The idea is that `DataBufferLLVM` already covers this use case, so there is no
point duplicating the code. The only tricky thing is that I found one case
where we attempt to modify the bytes we read in (in `ObjectFilePECOFF`). It
seems kind of hackish, but it wo
