labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks great. One thing I'd consider is adding a function which returns the data buffer as a StringRef (`AsStringRef()` ?) instead of the GetChars function, but I don't feel strongly about it. https://reviews.llvm.org/D30622 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits