[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

2016-11-29 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288159: Specify the dependencies of lldb-server manually (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26975?vs=78880&id=79584#toc Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

2016-11-29 Thread Todd Fiala via Phabricator via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. I think this is a great approach. LGTM! https://reviews.llvm.org/D26975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

Re: [Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

2016-11-29 Thread Zachary Turner via lldb-commits
Lgtm, and as we start untangling the mess of dependencies in liblldb id like for us to take the same approach there too (as llvm does) On Tue, Nov 29, 2016 at 3:08 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > Any thoughts on this? > > > https://r

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

2016-11-29 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Any thoughts on this? https://reviews.llvm.org/D26975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

2016-11-22 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: zturner, beanz, tfiala. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, srhines, danalbert. This basically just inlines the LLDBDependencies.cmake file into lldb-server CMakeLists.txt. The reason is that most of these