Re: [Lldb-commits] [PATCH] D18547: Fix infinite recursion in DWO file parsing

2016-03-29 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264729: Fix infinite recursion in DWO file parsing (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18547?vs=51896&id=51897#toc Repository: rL LLVM http://reviews.llvm.org/D18

Re: [Lldb-commits] [PATCH] D18547: Fix infinite recursion in DWO file parsing

2016-03-29 Thread Pavel Labath via lldb-commits
labath marked an inline comment as done. labath added a comment. @clayborg: I am going to put this in now, to stabilize the buildbot situation. I'll be happy to address any concerns in a follow-up commit. http://reviews.llvm.org/D18547 ___ lldb-com

Re: [Lldb-commits] [PATCH] D18547: Fix infinite recursion in DWO file parsing

2016-03-29 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:334 @@ +333,3 @@ +virtual std::unique_ptr +GetDWOForCompileUnit(DWARFCompileUnit &dw

[Lldb-commits] [PATCH] D18547: Fix infinite recursion in DWO file parsing

2016-03-29 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: tberghammer, clayborg. labath added a subscriber: lldb-commits. Since r264316, clang started adding DW_AT_GNU_dwo_name attribute to dwo files (previously, this attribute was only present in main object files), breaking pretty much every dwo t