This revision was automatically updated to reflect the committed changes.
Closed by commit rG013a8fc26ef8: [lldb] Update LLDB Code Ownership (authored by
JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D15694
JDevlieghere added a comment.
Alright, seems like we have consensus. The only person that hasn't chimed in
yet is Greg, but based on a comment in another thread he might be OOO. We can
alway address concerns post-commit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https:
DavidSpickett accepted this revision.
DavidSpickett added a comment.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
JDevlieghere updated this revision to Diff 547274.
JDevlieghere marked 7 inline comments as done.
JDevlieghere added a comment.
- Add Pavel's nominations
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
Files:
lldb/CODE_OWNERS.txt
lldb/Code
zequanwu added inline comments.
Comment at: lldb/CodeOwners.rst:132
+
+Breakpad
+
labath wrote:
> @zequanwu
I accept this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
DavidSpickett added inline comments.
Comment at: lldb/CodeOwners.rst:150
+
+ELF
+~~~
labath wrote:
> @DavidSpickett
Ok with me.
Comment at: lldb/CodeOwners.rst:220
+
+lldb-server
+~~~
labath wrote:
> @DavidSpickett
Ok
labath accepted this revision.
labath added a comment.
I've suggested some additional/alternative/backup (choose your interpretation)
owners for the components I'm listed as the only owner (I only wish I could
find someone to take over android). If they accept, then take this as my
endorsement
aaron.ballman added inline comments.
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
tonic wrot
JDevlieghere updated this revision to Diff 547099.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Link to developer policy.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
Files:
lldb/CODE_OWNERS.txt
lldb/Code
tonic added a comment.
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
JDevlieghere wrote:
>
JDevlieghere added inline comments.
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
DavidSpicke
JDevlieghere updated this revision to Diff 546897.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
- Update wording
- Remove double newline
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
Files:
lldb/CODE_OWNERS.
DavidSpickett added inline comments.
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
JDevlieghe
JDevlieghere added inline comments.
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
DavidSpicke
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM modulo nits found by others, thank you for this!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
___
lldb-commits mailing lis
DavidSpickett added inline comments.
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
This could
JDevlieghere updated this revision to Diff 546694.
JDevlieghere added a comment.
Add Discourse and Discord usernames.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
Files:
lldb/CODE_OWNERS.txt
lldb/CodeOwners.rst
Index: lldb/CodeOwners.r
tonic added a comment.
Since you are going to the effort of changing the CodeOwners file format from
what is in LLVM, can you go ahead and add Discourse and Discord handles? It is
often very helpful to tag someone on Discourse/Discord. I'll be proposing this
change for LLVM soon.
CHANGES SIN
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
___
lldb-commits mailing list
lldb-commits@list
JDevlieghere created this revision.
JDevlieghere added reviewers: jasonmolenda, DavidSpickett, jingham, bulbazord,
Michael137, clayborg, mib, labath, wallace, compnerd, aprantl, zequanwu,
emaste, omjavaid.
Herald added a subscriber: yaxunl.
Herald added a project: All.
JDevlieghere requested revi
20 matches
Mail list logo
