DavidSpickett added inline comments.

================
Comment at: lldb/CodeOwners.rst:7-8
+particular part of LLDB are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of LLDB, with the final word on
+what goes in or not.
+
----------------
This could be taken to mean every review must have approval from a code owner, 
on top of whatever other review has been done. Is that the intent? Someone 
coming from a project with strong maintainer rules (e.g. GDB, so I gather) may 
take it that way.


================
Comment at: lldb/CodeOwners.rst:214
+
+
+Tools
----------------
Is the extra space an RST thing, seems placed randomly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156949/new/

https://reviews.llvm.org/D156949

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to