DavidSpickett added a comment.
I've landed this so it has some time to go through bots before a backport to 15.
Apologies that your name isn't in the commit, I did add an author line locally
but Arc decided to remove it before landing.
If you do more fixes (and please do) get commit access your
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa9ffb4734535: Fix LLDB build on old Linux kernels (pre-4.1)
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133778/new/
https://r
DavidSpickett added a comment.
I only have newer kernels but replacing the type with what it looks like on an
older kernel and undefing PERF_ATTR_SIZE_VER5, lldb does build. So it looks
like this is a good thing to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
DavidSpickett added a comment.
Did this ever land? I only see
https://github.com/llvm/llvm-project/commit/d35702efe73010409c75b1f1b64f205cc3b2f6d3.
We have a short time to get this into 15.0.2, so I'd like to land this if it is
needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
wallace added a comment.
Thanks!!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133778/new/
https://reviews.llvm.org/D133778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
Lgtm, but please include the kernel version for the record
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133778/new/
https://reviews.llvm.org/
DavidSpickett added a comment.
> old Linux kernels
Also, could you include the kernel versions (that you know about at least) in
the commit message. For the next person who hits this and wonders if your
change is what they need to include.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
calebzulawski added a comment.
In terms of who calls it and might error, it looks like it's all used in
IntelPTMultiCoreTrace.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133778/new/
https://reviews.llvm.org/D133778
_
DavidSpickett added a comment.
llvm_unreachable is equivalent to __builtin_unreachable so yes it aborts with a
stack trace. I misread and thought you were returning values still.
Worth trying one of the trace commands in this build and see if lldb crashes or
we get a nice "not supported" messag
calebzulawski added a comment.
I'm not exactly sure what llvm_unreachable does, but I don't believe it will
return 0 (maybe it aborts?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133778/new/
https://reviews.llvm.org/D133778
___
DavidSpickett added reviewers: wallace, jj10306.
DavidSpickett added a comment.
Adding reviewers who know the trace feature.
Seems fine at a glance for the functions that return error types already but
for example `GetEffectiveDataBufferSize` check who calls it and might crash if
it returns 0.
calebzulawski created this revision.
calebzulawski added a reviewer: DavidSpickett.
calebzulawski added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
calebzulawski requested review of this revision.
Herald added a subscriber: lldb-commits.
These fields are
12 matches
Mail list logo
