DavidSpickett added reviewers: wallace, jj10306. DavidSpickett added a comment.
Adding reviewers who know the trace feature. Seems fine at a glance for the functions that return error types already but for example `GetEffectiveDataBufferSize` check who calls it and might crash if it returns 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/D133778 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits