This revision was automatically updated to reflect the committed changes.
Closed by commit rL250146: Preliminary NetBSD support (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13334?vs=37077&id=37214#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13334
Files:
lld
emaste added a comment.
OK by me. I'd also like to see less duplication, but have no objection to this
as it is now.
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
labath added a comment.
I would like to see these platforms merged, but I don't think that is up to me.
Feel free to go ahead.
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
brucem added a comment.
My plan is to land this in about 16 hours unless I hear otherwise. (@labath,
@tfiala, @emaste)
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
krytarowski updated this revision to Diff 37077.
Repository:
rL LLVM
http://reviews.llvm.org/D13334
Files:
include/lldb/Host/Config.h
include/lldb/Host/HostInfo.h
include/lldb/Host/HostNativeThread.h
include/lldb/Host/HostNativeThreadForward.h
include/lldb/Host/netbsd/Config.h
incl
tfiala added a comment.
> Unless someone else (@emaste?) objects, I think this looks fine to land and
> iterate on trunk as discussed in the mailing list thread. Just one minor
> comment based on cleanups that are on-going on trunk now.
Sounds reasonable.
Repository:
rL LLVM
http://review
brucem added a subscriber: brucem.
brucem added a comment.
Unless someone else (@emaste?) objects, I think this looks fine to land and
iterate on trunk as discussed in the mailing list thread. Just one minor
comment based on cleanups that are on-going on trunk now.
Comment at
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 02.10.2015 12:15, Kamil Rytarowski via lldb-commits wrote:
> On 02.10.2015 10:07, Ed Maste wrote:
>> On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits
>> wrote:
>>>
>>> Yes, please! Better incomplete support in the source trees
>>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 02.10.2015 10:07, Ed Maste wrote:
> On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits
> wrote:
>>
>> Yes, please! Better incomplete support in the source trees then
>> once almost complete but rotting in a local patch...
>
> I agre
On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits
wrote:
>
> Yes, please! Better incomplete support in the source trees then once
> almost complete but rotting in a local patch...
I agree - I think it's better to get basic support in as soon as
possible and we can refactor as appropri
emaste added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
krytarowski wrote:
> labath wrote:
> > krytarowski wrote:
> > > labath wro
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 01.10.2015 23:20, Joerg Sonnenberger via lldb-commits wrote:
> On Thu, Oct 01, 2015 at 10:41:46AM +, Pavel Labath via
> lldb-commits wrote:
>> This platform code looks like it was copy-pasted from
>> PlatformFreeBSD. Do you anticipate making s
On Thu, Oct 01, 2015 at 10:41:46AM +, Pavel Labath via lldb-commits wrote:
> This platform code looks like it was copy-pasted from PlatformFreeBSD.
> Do you anticipate making significant changes here?
>
> If not, it might be a good idea to share this code with FreeBSD in some
> way (in fact th
krytarowski added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
labath wrote:
> krytarowski wrote:
> > labath wrote:
> > > krytarowsk
labath added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
krytarowski wrote:
> labath wrote:
> > krytarowski wrote:
> > > labath wro
krytarowski added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
labath wrote:
> krytarowski wrote:
> > labath wrote:
> > > This platf
labath added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
krytarowski wrote:
> labath wrote:
> > This platform code looks like it wa
krytarowski added inline comments.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
labath wrote:
> This platform code looks like it was copy-pasted from
krytarowski added a comment.
Primary reason to skip for now build scripts is that this patch takes long to
be landed.
http://reviews.llvm.org/D12994
I don't want to submit a diff to patches sources...
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
labath added subscribers: emaste, labath.
Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1
@@ +1,2 @@
+//===-- PlatformNetBSD.cpp -*- C++ -*-===//
+//
This platform code looks like it was copy-pasted from Platform
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
This adds platform code without the cmake/gmake glue to the existing
infrastructure.
The missing and incompatibility
21 matches
Mail list logo
