JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129603/new/
https://reviews.llvm.org/D129603
___
lldb-commits mailing list
JDevlieghere added a comment.
- Do we need the source file for anything? I think it's fine to keep it around
to regenerate the test, but please fix the extension. Nothing in lldb uses
`.cc`.
- I think if we check in the "binary", we should also update the other
crashlogs tests to rely on it, an
JDevlieghere added a comment.
Can we use obj2yaml / yaml2obj for the binary?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129603/new/
https://reviews.llvm.org/D129603
___
lldb-commits mailing list
lldb-
mib created this revision.
mib added a reviewer: JDevlieghere.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch should fix the interactive crashlog test by checking in the
binary and debug info so tha
