[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rG4135abca897d: [lldb] add SBSection.alignment to python bindings (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://revi

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. I do not have commit access; could someone merge this patch as time allows? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-com

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary marked 2 inline comments as done. dmlary added a comment. @JDevlieghere if I'm reading this right, yours is the last approval this review needs. Is there anything else you would like to be updated in this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

clayborg accepted this revision. clayborg added a comment. Looks good, thanks for the revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-commits

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary updated this revision to Diff 441429. dmlary added a comment. merge tests, rename yml to yaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 Files: lldb/bindings/interface/SBSection.i lldb/inc

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D128069#3619736 , @dmlary wrote: > updated to include test cases for `SBSection.GetAlignment()` and > `SBSection.alignment` property. Cool. Looks

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary updated this revision to Diff 441073. dmlary added a comment. updated to include test cases for `SBSection.GetAlignment()` and `SBSection.alignment` property. @labath Thanks for the yaml2obj pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

Re: [Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

On Fri, Jun 17, 2022 at 14:32 Jonas Devlieghere via Phabricator wrote: > > JDevlieghere added a comment. > > In D128069#3592733 , @dmlary wrote: > > > I went through the existing tests for SBSection, and there is only one test > > case for all the getters

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

labath added a comment. In D128069#3602256 , @dmlary wrote: >> We should test any APIs we add in a python test IMHO. Also testing that the >> ".alignment" property works > > Ok, I'll add tests for the added python function and property. > > Now for the

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. > We should test any APIs we add in a python test IMHO. Also testing that the > ".alignment" property works Ok, I'll add tests for the added python function and property. Now for the hard part, what's the recommended way to access elf section details within python with

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

clayborg added a comment. In D128069#3599456 , @dmlary wrote: > Sent this via email, but doesn't look like it showed up here: > >> I'm less concerned about the getter and the property and more about the >> underlying functionality. It doesn't look like i

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. Sent this via email, but doesn't look like it showed up here: > I'm less concerned about the getter and the property and more about the > underlying functionality. It doesn't look like it's being tested, and adding > it to the SB API allows to change that. Just to clari

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

labath added a comment. For the underlying functionality, I think it'd be best to extend `lldb-test` to print section alignment (`dumpSectionList` in `lldb/tools/lldb-test/lldb-test.cpp`) and then write (or extend) some test in `test/Shell/ObjectFile/ELF` (or your favourite object format). Tha

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere added a comment. In D128069#3592733 , @dmlary wrote: > I went through the existing tests for SBSection, and there is only one test > case for all the getters & props, and that is for `target_byte_size`. Based > on that lack, and the simpli

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. I went through the existing tests for SBSection, and there is only one test case for all the getters & props, and that is for `target_byte_size`. Based on that lack, and the simplicity of the getter, I didn't think a test case was warranted here. If the reviewers feel

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere added a comment. Is this something we could add a test for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary created this revision. dmlary added a reviewer: clayborg. dmlary added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere. Herald added a project: All. dmlary requested review of this revision. This commit adds SBSection.GetAlignment(), and SBSection.alignment as a python