clayborg added a comment. In D128069#3599456 <https://reviews.llvm.org/D128069#3599456>, @dmlary wrote:
> Sent this via email, but doesn't look like it showed up here: > >> I'm less concerned about the getter and the property and more about the >> underlying functionality. It doesn't look like it's being tested, and adding >> it to the SB API allows to change that. > > Just to clarify, are you asking me to add a test for the underlying > functionality, `Section.GetLog2Align()`? Or is the goal to add the > test at the SBSection level to ensure we detect if someone ever > changes the underlying api? We should test any APIs we add in a python test IMHO. Also testing that the ".alignment" property works Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
