[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

thieta added a comment. FYI: I helped @PatriosTheGreat to commit this after he asked for help in discord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ l

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

This revision was automatically updated to reflect the committed changes. Closed by commit rGa33983729df6: Pass plugin_name in SBProcess::SaveCore (authored by PatriosTheGreat, committed by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12532

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat added a comment. Thanks Greg, Can you or someone please take this commit to main branch since I don't have a commit permission? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ ll

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the changes. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ lldb-commi

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat added a comment. Hi Greg, Sorry for a delay had an issue with tests local run. I fixed the previous feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 430357. PatriosTheGreat marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/sourc

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looking great, just a few more fixes. Thanks for making the changes. Comment at: lldb/include/lldb/API/SBProcess.h:348 + /// \param[in] core_style - Specify th

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 429160. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/source/API/SBProcess.cpp lldb/test/API/functionaliti

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg added a comment. It might be a good idea to add a test for this. There seems to be a test already in this file: lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py In fact looking at this test, it seems they specify the "SaveCoreStyle" via an opt

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat marked 3 inline comments as done. PatriosTheGreat added a comment. Thanks for clarifications. Fixed header doc and parameter name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 428880. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/source/API/SBProcess.cpp Index: lldb/source/API/SBPro

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:340 /// Save the state of the process in a core file (or mini dump on Windows). + lldb::SBError SaveCore(const char *file_name, const char *plugin_name); I would modify the header

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

jingham added a comment. In D125325#3505305 , @PatriosTheGreat wrote: > Hi Greg. > > Thanks for the review. > I fixed the feedback. > I forgot the default initialization of plugin_name parameter in SBProcess.i > in previous version, but I assume it's st

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat marked 3 inline comments as done. PatriosTheGreat added a comment. Hi Greg. Thanks for the review. I fixed the feedback. I forgot the default initialization of plugin_name parameter in SBProcess.i in previous version, but I assume it's still better to explicitly create a separat

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 428577. PatriosTheGreat edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/so

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We can't change any public API calls since other tools might link against the existing API, but we can add new variants to the API. Inline fixes have been suggested. =

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: clayborg, labath. Herald added a project: All. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This CL allows to use minidump save-core functionality (