jingham added a comment. In D125325#3505305 <https://reviews.llvm.org/D125325#3505305>, @PatriosTheGreat wrote:
> Hi Greg. > > Thanks for the review. > I fixed the feedback. > I forgot the default initialization of plugin_name parameter in SBProcess.i > in previous version, but I assume it's still better to explicitly create a > separate method. Yes, a method with a default parameter has a different mangled name from the method w/o the parameter, so it's still a binary incompatible change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
