[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

jingham added a comment. In D112587#3092125 , @clayborg wrote: > In D112587#3092120 , @jingham wrote: > >> Note, the breakpoint serialization for breakpoints only serializes the >> filter/resolver and the breakpo

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg added a comment. In D112587#3092120 , @jingham wrote: > Note, the breakpoint serialization for breakpoints only serializes the > filter/resolver and the breakpoint specific options. It doesn't do anything > with locations or their options. Af

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

jingham added a comment. Note, the breakpoint serialization for breakpoints only serializes the filter/resolver and the breakpoint specific options. It doesn't do anything with locations or their options. After all, you when you go to reset a breakpoint in another session (which is what this

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb2549683260: Add breakpoint resolving stats to each target. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://revie

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. sounds good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://reviews.llvm.org/D112587 ___

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 +else + llvm::consumeError(expected_value.takeError()); + } wallace wrote: > err, i'm not a fan of this. Why don't you just make this return an expected > and make t

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg updated this revision to Diff 382803. clayborg added a comment. Changes in this version: - If we fail to get "details" from the structured data, we put the error string into the "details" dictionary with the error string. - Added "numLocations" (int64_t) and "numResolvedLocations" (int6

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 +else + llvm::consumeError(expected_value.takeError()); + } err, i'm not a f

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg created this revision. clayborg added reviewers: JDevlieghere, wallace, aadsm, labath, jingham. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds breakpoints to each target's statistics so we can track how l