jingham added a comment. In D112587#3092125 <https://reviews.llvm.org/D112587#3092125>, @clayborg wrote:
> In D112587#3092120 <https://reviews.llvm.org/D112587#3092120>, @jingham wrote: > >> Note, the breakpoint serialization for breakpoints only serializes the >> filter/resolver and the breakpoint specific options. It doesn't do anything >> with locations or their options. After all, you when you go to reset a >> breakpoint in another session (which is what this serialization is for) you >> have no way of knowing what locations you are going to find. > > Good to know! > >> So if you want to record the locations (for instance to make sure that your >> recreation actually did the same work) then you will have to record the >> locations some other way. However, you do record the number of locations, >> which is probably a good enough signal that you aren't recreating what you >> thought you were. So maybe you don't need to worry about this. > > I am mainly concerned with the overall details of a breakpoint, and usually > for the breakpoints that have no locations due to a source mapping error, or > lack of debug information. Both stats are available (debug info size + > breakpoint filter/resolver details) so that will help us figure out why > things are not working for people. I had locations before, but I am not sure > we need that information just yet so I will leave that for later if we do end > up needing it for some reason. This seems like a reasonable choice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://reviews.llvm.org/D112587 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
