[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

This revision was automatically updated to reflect the committed changes. Closed by commit rG953ddded1aa2: [lldb] Handle malformed qfThreadInfo reply (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted marked an inline comment as done. ted added a comment. Prints were there for my debugging. They don't serve a purpose, so I've removed them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.org/D109937 __

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted updated this revision to Diff 374233. ted added a comment. Remove unneeded prints from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https://reviews.llvm.org/D109937 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCom

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestThreadInfoTrailingComma.py:24-25 +process = self.connect(target) +print(process.GetThread

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted updated this revision to Diff 374049. ted added a comment. [lldb] Handle malformed qfThreadInfo reply Add requested test. Refine handling of malformed reply with no valid threads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/ https

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

labath added a comment. In D109937#3007071 , @ted wrote: > I've got a test written. It doesn't crash like the debugger in the wild does, > but it does give a tid of 0 for each thread I ask about. So I can assert if > the threads don't have the correct t

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted added a comment. I've got a test written. It doesn't crash like the debugger in the wild does, but it does give a tid of 0 for each thread I ask about. So I can assert if the threads don't have the correct tid. With the patch, the test passes (gets the tids correctly) Without the patch and

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted added a comment. I agree about the test. I'll work on one. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2911-2912 +// if ids is empty, this is an error +if (ids.size() == 0) + return {}; +

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

labath added a reviewer: mgorny. labath added a comment. +1 for the test. It should be fairly easy to rig up a "gdb-remote client" test that sends such a packet. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2909-2917 + if (!pid_

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

clayborg added a comment. We should make a test for this. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2909-2917 + if (!pid_tid) { +// if ids is empty, this is an error +if (ids.size() == 0) +

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted created this revision. ted added a reviewer: clayborg. ted requested review of this revision. Herald added a project: LLDB. If the remote gdbserver's qfThreadInfo reply has a trailing comma, GDBRemoteCommunicationClient::GetCurrentProcessAndThreadIDs will return an empty vector of thread ids.