[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c11e5722c30: [LLDB][GUI] Add initial searcher support (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, sounds like you have thought this through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108545/new/ https://reviews.llvm.org/D108545 _

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. @clayborg I see a number of issues with using forms directly: - The user will have to bother with form navigation. If we have a text field and a choice field, the user will have to switch between them using Tab and Shift+Tab in order to explore, rectify, and select

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

clayborg added a comment. In D108545#2962017 , @OmarEmaraDev wrote: > @clayborg I was planning on getting to field completion later as part of a > global "context window" feature. There are reasons why I need this as a full > separate window for now. I

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3592 +m_selected_match(0), m_first_visible_match(0) { +; + } OmarEmaraDev wrote: > clayborg wrote: > > Should we be doing just like any other dialog that we have

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. @clayborg I was planning on getting to field completion later as part of a global "context window" feature. There are reasons why I need this as a full separate window for now. Imminently, I am creating an operator that changes the file in the sources window so tha

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

clayborg added a comment. I like the look of this. It seems we would want this kind of auto complete in many fields that we already have, like the file or directory dialogs to start with. My main question is do we need a full window for this, or can be paint a window that is just the search re

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. An example searcher window for source files: F18633042: 20210823-141344.mp4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108545/new/ https

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new type of reusable UI components. Searcher Win