[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00d19c6704f4: [various] Remove or use variables which are unused but set. (authored by mbenfield, committed by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

dblaikie added a comment. In D102942#2791204 , @mbenfield wrote: > I also heard via email from Amara Emerson that the change is fine for similar > reasons. Great, thanks for checking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. I also heard via email from Amara Emerson that the change is fine for similar reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942 _

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

samparker added inline comments. Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1250 else -return false; +return Changed; dblaikie wrote: > Also might be worth reaching out to authors to check that this change is > intended & possibly teste

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

lebedev.ri resigned from this revision. lebedev.ri added a comment. (removing from my queue - i don't expect to provide any review here) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942 ___

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. In D102942#2774819 , @dblaikie wrote: > Sure, all sounds good - if you can, please reach out to the authors of any of > the semantics changing changes (the ones related to the `Changed` values in > transformations) to see if t

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

teemperor accepted this revision. teemperor added a comment. `ABISysV_ppc.cpp` feels a bit like this should be used to calculate some offset, but I don't think that's for this review to figure out what is wrong there. The other LLDB changes LGTM. Comment at: lldb/source/Inter

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, all sounds good - if you can, please reach out to the authors of any of the semantics changing changes (the ones related to the `Changed` values in transformations) to see if they co

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. Herald added a subscriber: JDevlieghere. Several variables I have just removed outright, including llvm/lib/Target/X86/X86FloatingPoint.cpp: STDeadDefs lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp: fp_bytes lldb/source/Interpreter/CommandInterpreter.cpp: actual_cmd_n

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield created this revision. Herald added subscribers: pengfei, lebedev.ri, kbarton, hiraditya, nemanjai. Herald added a reviewer: lebedev.ri. mbenfield requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This is in prepar