teemperor accepted this revision. teemperor added a comment. `ABISysV_ppc.cpp` feels a bit like this should be used to calculate some offset, but I don't think that's for this review to figure out what is wrong there. The other LLDB changes LGTM.
================ Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:3104 bool wants_raw_input = false; - size_t actual_cmd_name_len = 0; std::string next_word; ---------------- Was already checked in unused and I don't see what we would need that for, LGTM. ================ Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp:342 - uint32_t isa_count = 0; - ---------------- This code was apparently rendered obsolete by 89870cebcb0c9996f49336a21e72b80511f37341 so LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
