[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

stella.stamenova added a comment. > Oh I still saw that one running a few days back! @stella.stamenova in the > review you mention a second windows lldb bot, is it x86 as well? I don't see > it in https://lab.llvm.org/buildbot/#/console The one I was referring to is https://lab.llvm.org/buildbo

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

stella.stamenova added a comment. In D145242#4173592 , @Michael137 wrote: > In D145242#4173577 , > @stella.stamenova wrote: > >> Looks like either this change or D125241 >> br

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

stella.stamenova added a comment. Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and re

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

stella.stamenova added a comment. Looks like this change broke the windows lldb build: https://lab.llvm.org/buildbot/#/builders/83/builds/29801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104 ___

[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

stella.stamenova added a comment. Looks like the new test is failing on the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was already red because of `TestCommandScript.py`, so you might have missed this. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

stella.stamenova added a comment. Looks like this broke the windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/26822 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

stella.stamenova added a comment. Looks like the windows lldb bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/26083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650 ___

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/26042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. In D133366#3923291 , @kastiglione wrote: > Ugh, the test that is failing uses windows paths but runs on both windows and > non-windows machines. I will revert this and the two fix commits. You should be able to test fo

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

stella.stamenova added a comment. The newly added test is failing on the windows buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/25446 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 ___

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

stella.stamenova added a comment. Looks like in addition to the Linux failure, this also broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136761/ne

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

stella.stamenova added a comment. Herald added subscribers: Michael137, JDevlieghere. I think this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135998/new/

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

stella.stamenova added a comment. Looks like this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24631 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135413/new/ https://reviews.llvm.org/D135413 _

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

stella.stamenova added a comment. This broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/22557/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131983/new/ https://reviews.llvm.org/D131983

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

stella.stamenova added a comment. Looks like this broke the Windows lldb bot as well: https://lab.llvm.org/buildbot/#/builders/83/builds/21186 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 __

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20566 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

stella.stamenova added a comment. This broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. In D125943#3587778 , @wallace wrote: > @stella.stamenova, I've just tried that compile command with several versions > of gcc, including g++ (GCC) 8.5.0 on CentOS and got no error Sadly I couldn't > install 7.3.1. Could

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. In D125943#3586910 , @wallace wrote: > yes, i'm trying to fix it now. Thanks! Thanks! One more to add to the list: FAILED: tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/IntelPTPerThre

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. These changes (the set of [trace][intelpt] changes) broke the windows lldb bot. It's most likely this particular change, but it could be one of the others. Unfortunately, the bot had just been broken by https://reviews.llvm.org/D127882, so it didn't show the fa

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/18228 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Prepare decouple instance and plugin names

stella.stamenova added a comment. It looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/15999 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/D119146 _

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

stella.stamenova added a comment. It looks like the new test is failing on the Windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/15049 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 __

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added a comment. Thanks! It looks like there's a failure that was previously hidden by the unexpected passes: https://lab.llvm.org/buildbot/#/builders/83/builds/14781 It seems like it's been in all of the previous builds as well, but it was not reported separately for some re

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added inline comments. Comment at: lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46 @skipIfTargetAndroid() # debuggerd interferes with this test on Android @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr247

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM, I think there might be a couple more places to remove the xfail, but otherwise ship it! Comment at: lldb/test/API/functionalities/inferior-crashin

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added a comment. They should correspond to these files: lldb-api :: functionalities/inferior-crashing/TestInferiorCrashing.py => test/API/functionalities/inferior-crashing/TestInferiorCrashing.py lldb-api :: functionalities/inferior-crashing/TestInferiorCrashingStep.py => t

[Lldb-commits] [PATCH] D118750: [LLDB] add sub register enums on x64 Windows

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This broke the windows bot in the best way possible - by making some tests pass now that didn't use to. Could you un-xfail those too? https://lab.llvm.org/buildbot/#/builders/83/builds/14736 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG738d73fbf4ed: [lldb] Update the lldb build instructions on Windows (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice now

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also nee

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

stella.stamenova updated this revision to Diff 404065. stella.stamenova added a comment. Add more details for developer command prompt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/ https://reviews.llvm.org/D118425 Files: lldb/docs/resources/build.rst Index: lldb/docs/re

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, dblaikie. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The existing instructions for lldb on Windows can be more explicit. This adds

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova abandoned this revision. stella.stamenova added a comment. I spent a bit of time trying to investigate the failures, but I couldn't make much progress and I don't have time to dedicate to a more thorough investigation. It looks like there are a few tests that outright fail (inc

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117637/new/ https://reviews.llvm.org/D117637 ___

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova added a comment. So, sadly, I am going to have to backtrack here. When I set `LLDB_USE_LLDB_SERVER` in my environment and ran the tests, they did appear to be more stable (fewer failures across 10 test runs), but it was all a joke my machine was playing on me. Running the test

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This does not build correctly with gcc 7.3.1 on CentOS: /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/resource/1/b/llvm

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, clayborg, labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current default is to not use lldb-server on Windows, however, ll

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

stella.stamenova added a comment. Since @omjavaid is working on a related change in https://reviews.llvm.org/D117363, perhaps he can make the necessary changes there to support `-j` for the tests? Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11697

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 __

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/new/ https://reviews.llvm.org/D104886 ___ lldb-commits mail

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:73 +#if defined(_WIN32) +// Don't mess with the signal handlers on Windows. Were these not used on Windows at all before? CHANGES SIN

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116972/new/ https://reviews.llvm.org/D116972 ___ lldb-commits maili

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

stella.stamenova added a comment. The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to se

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4abf28c0a0b: [lldb] Update the PDB tests to pass with the VS2019 toolset (authored by stella.stamenova). Repository: r

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

stella.stamenova added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/Shell/SymbolFile/PDB/enums-layout.test:13 -ENUM: Type{{.*}} , name = "Enum", size = 4, decl = simpletypestest.cpp:19, compiler_type = {{.*}} enum Enum { +ENUM: Type

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

stella.stamenova created this revision. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The pdb lldb tests do not work correctly with both the VS2019 and VS2017 toolsets at the moment. This change updates several of the te

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc24860118a7e: [lldb] Skip two lldb tests on Windows because they are flaky (authored by stella.stamenova). Repository:

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

stella.stamenova created this revision. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests work fine with VS2017, but become more flaky with VS2019 and the buildbot is about to get upgraded. Repository: rG LLV

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

stella.stamenova added a comment. @zequanwu : It looks like the bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/12413 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114467/new/ https://reviews.llvm.org/D114467 _

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

stella.stamenova added a comment. This broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12270 I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

stella.stamenova added a comment. I think this broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova added a comment. This broke the build on Windows. The buildbot was, sadly, already red because of another test failure: https://lab.llvm.org/buildbot/#/builders/83/builds/11931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added a comment. Can you please disable the test on Windows or back your change out until there's a fix? There are already other failures that are getting missed because the bot is red. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432 + elif os.name == 'posix': + exename = "python" + str(sys.version_info[0]) + info['executable'] = os.path.join(sys.prefix, 'bin', exename)

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413 +static const char GetInterpreterInfoScript[] = R"( +import os Does `sys.executable` not work for some reason? C

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

stella.stamenova added a comment. Windows buildbot is broken: https://lab.llvm.org/buildbot/#/builders/83/builds/11865 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added a comment. The Windows buildbot is still broken after this change: https://lab.llvm.org/buildbot/#/builders/83/builds/11630 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added inline comments. Comment at: lldb/test/Shell/Settings/TestEchoCommands.test:4 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out -# RUN: %lldb -x -b --so

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

stella.stamenova added a comment. It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now): https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG58917054c298: [lldb] Skip several lldb tests that are flaky on Windows (authored by stella.stamenova). Repository: rG L

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

stella.stamenova created this revision. stella.stamenova added a reviewer: labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests fail every 10 or so runs on Windows causing both local failures as well as buil

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

stella.stamenova added a comment. This broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/10836 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 ___

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

stella.stamenova added a comment. This change is causing failures on the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/9098 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

stella.stamenova added a comment. In D100299#2917598 , @jankratochvil wrote: > In D100299#2917467 , @Eric wrote: > >> Is arm hardware necessary to test this, > > In this case it is not as it does not require link

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

stella.stamenova added a comment. In D105471#2896533 , @stella.stamenova wrote: > I think this change broke the Windows LLDB bot. More specifically the > TestStructTypes test: > > https://lab.llvm.org/buildbot/#/builders/83/builds/8528 Looks like you f

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

stella.stamenova added a comment. I think this change broke the Windows LLDB bot. More specifically the TestStructTypes test: https://lab.llvm.org/buildbot/#/builders/83/builds/8528 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105471/new/ https:

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

stella.stamenova added a comment. In D105160#2848805 , @clayborg wrote: > @stella.stamenova all test suite failures should be fixed now. This is a redo > on https://reviews.llvm.org/D104488 which was reverted in less that a day... @clayborg : Thanks! We

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

stella.stamenova added a comment. This broke the windows lldb bot and the follow up changes did not fix it: https://lab.llvm.org/buildbot/#/builders/83/builds/7748 Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ htt

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. In D101128#2831098 , @wallace wrote: > I'm reverting it asap Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 _

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. @wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

stella.stamenova added a comment. The Windows buildbot does not like signposts: https://lab.llvm.org/buildbot/#/builders/83/builds/7271 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 ___

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

This revision was automatically updated to reflect the committed changes. Closed by commit rGca10add5dbe4: [lldb, win] Remove obsolete workaround for MSVC and python libs (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This workaround was necessary before the major chan

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

stella.stamenova added a comment. I don't have context into this either. Does this cause any test failures or is everything still green after the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208 _

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. It looks like this broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101333/new/ https://rev

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

stella.stamenova added a comment. Looks like this is failing on the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6033 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 _

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

stella.stamenova added a comment. This broke the windows LLDB bot. Please fix it soon or revert. https://lab.llvm.org/buildbot/#/builders/83/builds/5685 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

stella.stamenova added a subscriber: teemperor. stella.stamenova added a comment. It looks like @teemperor fixed it already! In D99694#2671640 , @stella.stamenova wrote: > The latest change (commit be0ced03 >

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

stella.stamenova added a comment. The latest change (commit be0ced03 ) issues the following warning: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

stella.stamenova added a comment. Looks like this broke the Windows lldb buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/5173 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 __

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, This is where the

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should f

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:114 + create_python_package( +${swig_target} How is this different than the package on line 107? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. This did end up breaking the windows build bot... https://lab.llvm.org/buildbot/#/builders/83/builds/4808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 _

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. In D98842#2634902 , @teemperor wrote: > Just gonna post a comment to point out that this apparently adds all tests > twice to `check-all` which makes the tests go kaputt (but I only messaged > Jonas directly about that,

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Looks good as long as it doesn't break windows :O CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 ___

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/4725 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98749/new/ https://reviews.llvm.org/D98749

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG801067f4c09b: [mlir][lldb] Fix several gcc warnings in mlir and lldb (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

stella.stamenova added inline comments. Comment at: lldb/source/Commands/CommandObjectTrace.cpp:119 lldb::TraceSP trace_sp = traceOrErr.get(); - if (m_options.m_verbose) + if (m_options.m_verbose && trace_sp) result.AppendMessageWithFormat("loading trace

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

stella.stamenova added a comment. In D95711#2595566 , @mib wrote: > In D95711#2595458 , > @stella.stamenova wrote: > >> This does not build on the Windows bot: >> >> https://lab.llvm.org/buildbot/#/builders/83/buil

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

stella.stamenova added a comment. This does not build on the Windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/4214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 ___

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. In D96778#2595162 , @jankratochvil wrote: > In D96778#2595110 , > @stella.stamenova wrote: > >> What is the actual test requirement? > > It requires x86_64 (it is incompatible wit

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. Considering this broke two bots, you might want to commit a fix or revert soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. In D96778#2594405 , @jankratochvil wrote: > @stella.stamenova It failed on a Windows box: > https://lab.llvm.org/buildbot/#/builders/83/builds/4202 > > $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" > "--ta

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

stella.stamenova created this revision. Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini. Herald added a rev

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

stella.stamenova accepted this revision. stella.stamenova added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96779/new/ https://reviews.llvm.org/D96779 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova updated this revision to Diff 323053. stella.stamenova edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96427/new/ https://reviews.llvm.org/D96427 Files: clang/test/Unit/lit.site.cfg.py.in lld/t

  1   2   3   4   >