[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

rriddle added a comment. Moving the constructor/destructor to the cpp file makes sense to remove the "undefined reference to vtable" issues that we've seen before, but I don't understand the changes to pure virtual methods or the removal of the LLDB_ENABLE_PYTHON checks. Can you elaborate more?

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

rriddle added a comment. This makes sense to me, but again will defer to area owners for what the expectation is here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157764/new/ https://reviews.llvm.org/D157764

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. LGTM, but deferring to code owners for full approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153073/new/ https://reviews.llvm.org/D1530

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

rriddle added a comment. Could we switch the RTTI to use the llvm RTTI extension mechanism, instead of enums? Other classes have started doing this, and it'd be really nice if users can write REPLS without needing to touch upstream LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D149702: [LLDB] Add minimal support for the new Mojo language

rriddle accepted this revision. rriddle added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.llvm.org/D149702 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

rriddle accepted this revision. rriddle added a comment. LGTM with comment addressed, and white space changes dropped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 _

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. LGTM, and makes sense to me given that downstream users often want a build of LLVM with `CMAKE_CXX_VISIBILITY_PRESET=hidden`, but lldb should still be able to build/link/work in the presence

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

rriddle added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:173 + if (LLDB_EXPORT_ALL_SYMBOLS) +if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") Other places uses `if (NOT CM

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3252d1a2c56: [lldb][NFC] Move various constructor definitions from .h to .cpp (authored by rriddle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147252/ne

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

rriddle created this revision. Herald added a subscriber: bollu. Herald added a project: All. rriddle requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I ran into issues with linking downstream language plugin to liblldb in debug builds, hitt

[Lldb-commits] [PATCH] D142733: Add _Optional as fast qualifier

rriddle added a comment. I don't understand the MLIR changes here, how are they relevant to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142733/new/ https://reviews.llvm.org/D142733 ___ lldb-

[Lldb-commits] [PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c484f11d355: [llvm] Add a SFINAE template parameter to DenseMapInfo (authored by rriddle). Changed prior to commit: https://reviews.llvm.org/D113

[Lldb-commits] [PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle updated this revision to Diff 387386. rriddle added a comment. Herald added subscribers: lldb-commits, hiraditya. Herald added a project: LLDB. resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.