[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -204,9 +209,64 @@ bool ScriptedThread::LoadArtificialStackFrames() { SymbolContext sc; symbol_addr.CalculateSymbolContext(&sc); -StackFrameSP synth_frame_sp = std::make_shared( +return std::make_shared( this->shared_from_this(), idx, idx, cfa, cfa_i

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Reimplement PythonObject::Dump using the limited API (PR #152055)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/152055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reimplement PythonObject::Dump using the limited API (PR #152055)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
@@ -131,23 +132,30 @@ void StructuredPythonObject::Serialize(llvm::json::OStream &s) const { // PythonObject void PythonObject::Dump(Stream &strm) const { - if (m_py_obj) { -FILE *file = llvm::sys::RetryAfterSignal(nullptr, ::tmpfile); -if (file) { - ::PyObject_

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reimplement PythonObject::Dump using the limited API (PR #152055)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
@@ -131,23 +132,30 @@ void StructuredPythonObject::Serialize(llvm::json::OStream &s) const { // PythonObject void PythonObject::Dump(Stream &strm) const { - if (m_py_obj) { -FILE *file = llvm::sys::RetryAfterSignal(nullptr, ::tmpfile); -if (file) { - ::PyObject_

[Lldb-commits] [lldb] [lldb] Fix TLS support on Darwin platforms (PR #151601)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
@@ -10,10 +10,12 @@ touch_shared(); // Create some TLS storage within the static executable. __thread int var_static = 44; +__thread int var_static2 = 22; void *fn_static(void *param) { var_static *= 2; + var_static2 *= 3; medismailben wrote: ind

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/152006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate InitializePythonRAII::InitializeThreadsPrivate (NFC) (PR #151780)

2025-08-01 Thread Med Ismail Bennani via lldb-commits
@@ -137,7 +137,16 @@ struct InitializePythonRAII { config.install_signal_handlers = 0; Py_InitializeFromConfig(&config); PyConfig_Clear(&config); -InitializeThreadsPrivate(); + +// The only case we should go further and acquire the GIL: it is unlocked. +

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_SimpleString using the Python stable C API (PR #151777)

2025-08-01 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Use Clang attributes to keep track of pointer plus len (PR #148981)

2025-07-28 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: I have some reservations about the effectiveness of this new approach: Instead of having a list in lldb-rpc with your ptr + length exceptions, now we need to mark manually every single method at the SBAPI level. If a new method gets added the SBAPI and the contributor doesn

[Lldb-commits] [lldb] Switch the ScriptedBreakpointResolver over to the ScriptedInterface form (PR #150720)

2025-07-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Beautiful! LGTM with comments! https://github.com/llvm/llvm-project/pull/150720 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] Switch the ScriptedBreakpointResolver over to the ScriptedInterface form (PR #150720)

2025-07-26 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,100 @@ +//===-- ScriptedBreakpointPythonInterface.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Switch the ScriptedBreakpointResolver over to the ScriptedInterface form (PR #150720)

2025-07-26 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,100 @@ +//===-- ScriptedBreakpointPythonInterface.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Switch the ScriptedBreakpointResolver over to the ScriptedInterface form (PR #150720)

2025-07-26 Thread Med Ismail Bennani via lldb-commits
@@ -50,8 +50,28 @@ void BreakpointResolverScripted::CreateImplementationIfNeeded( if (!script_interp) return; - m_implementation_sp = script_interp->CreateScriptedBreakpointResolver( - m_class_name.c_str(), m_args, breakpoint_sp); + m_interface_sp = script_interp

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Overall, LGTM with comments and linking failure addressed. https://github.com/llvm/llvm-project/pull/147655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Looks like there is a linking issue on Linux: ``` 2025-07-24T23:47:48.0834355Z [6326/6332] Linking CXX executable bin/lldb-rpc-gen 2025-07-24T23:47:48.0834814Z FAILED: bin/lldb-rpc-gen 2025-07-24T23:47:48.0852723Z : && /opt/llvm/bin/clang++ -gmlt -fPIC -fno-semantic-interpo

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
@@ -306,6 +348,28 @@ bool EmitAmalgamatedServerHeader(const std::vector &Files) { return true; } +bool EmitAmalgamatedLibraryHeader(const std::vector &Files) { medismailben wrote: Not sure what "Amalgamated" means here, I'd like a more self-explaining name

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
@@ -46,6 +48,12 @@ static std::string GetServerOutputDirectory() { return std::string(Path); } +static std::string GetLibraryOutputDirectory() { + llvm::SmallString<128> Path(OutputDir.getValue()); medismailben wrote: nit: I was wondering if we should make

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include medismailben wrote: Make sure to remove this from every test https://github.com/llvm/llvm-project/pull/147655 __

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include + +#include "lldb/API/SBDefines.h" + +namespace lldb { +class LLDB_API SBRPC_CHECKARRAYPTR { medismailben wrote: +1 https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Med Ismail Bennani via lldb-commits
@@ -153,70 +249,221 @@ class LLDB_API SBDebugger { /// lldb::SBStructuredData settings = debugger.GetSetting("target.arg0"); /// lldb::SBStructuredData settings = debugger.GetSetting("target"); /// - /// \param[out] setting + /// \param[in] setting /// Property set

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Med Ismail Bennani via lldb-commits
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger { bool &is_debugger_specific); #endif + /// Get structured progress data from an event. + /// + /// \param [in] event + /// The event to extract the progress information from. + /

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Med Ismail Bennani via lldb-commits
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger { bool &is_debugger_specific); #endif + /// Get structured progress data from an event. + /// + /// \param [in] event + /// The event to extract the progress information from. + /

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Med Ismail Bennani via lldb-commits
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger { bool &is_debugger_specific); #endif + /// Get structured progress data from an event. medismailben wrote: nit: ```suggestion /// Get progress structured data from

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > We definitely need more documentation, but I do sometimes get annoyed by it > when it obscures browsing through the source code by stretching out the class > definition. If that includes important information about the API, then I > think it's worth it, but some of these

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Make registers always available & fix x29/x30 parsing (PR #145104)

2025-06-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/145104 >From c83fa6be0c41102d4c0df424574b215d4f83f5f2 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Fri, 20 Jun 2025 14:45:11 -0700 Subject: [PATCH 1/2] [lldb/crashlog] Fix register parsing for arm64 usi

[Lldb-commits] [lldb] [lldb/crashlog] Make registers always available & fix x29/x30 parsing (PR #145104)

2025-06-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/145104 This patch addresses 2 issues: 1. It makes registers available on non-crashed threads all the time 2. It fixes arm64 registers parsing for registers that don't use the `x` prefix (`fp` -> `x29` / `lr` -> `x

[Lldb-commits] [lldb] [lldb] Add support for x86_64h to scripted process (NFC) (PR #145099)

2025-06-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/145099 This patch adds support to the haswell sub-architecture (x86_64h) to scripted processes. rdar://147208252 >From bf21c2e9c59939956230d3093d5705e3e8fde12e Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani

[Lldb-commits] [lldb] [lldb/cmake] Plugin layering enforcement mechanism (PR #144543)

2025-06-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Cool stuff! https://github.com/llvm/llvm-project/pull/144543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #144839)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/144839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #144839)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: This is just fixing the test failure introduced by #94575 https://github.com/llvm/llvm-project/pull/144839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #144839)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/144839 This patch makes interactive mode as the default when using the crashlog command. It replaces the existing `-i|--interactive` flag with a new `-m|--mode` option, that can either be `interactive` or `batch`

[Lldb-commits] [lldb] [lldb][target] Add progress report for wait-attaching to process (PR #144768)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/144768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][target] Add progress report for wait-attaching to process (PR #144768)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
@@ -3546,6 +3546,8 @@ llvm::Expected Target::GetTraceOrCreate() { } Status Target::Attach(ProcessAttachInfo &attach_info, Stream *stream) { + std::unique_ptr attach_progress; + attach_progress = std::make_unique("Waiting to attach to process"); medismailben

[Lldb-commits] [lldb] [lldb][target] Add progress report for wait-attaching to process (PR #144768)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Cool! LGTM with comment addressed. https://github.com/llvm/llvm-project/pull/144768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb][target] Add progress report for wait-attaching to process (PR #144768)

2025-06-18 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/144768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a python JIT loader class. (PR #142514)

2025-06-03 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Hey @clayborg, this is pretty cool. I'm glad you were able to use and extend > the ScriptedPythonInterface to implement this, hopefully it wasn't too > complicated. LGTM! I meant LGTM on the scripting side of things. I still thing we should address Jim's comments: > For

[Lldb-commits] [lldb] Add a pythin JIT loader class. (PR #142514)

2025-06-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Hey @clayborg, this is pretty cool. I'm glad you were able to use and extend the ScriptedPythonInterface to implement this, hopefully it wasn't too complicated. LGTM! https://github.com/llvm/llvm-project/pull/142514 __

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Cool! Would be nice to change some of the existing tests to make sure these work as expected. https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb-dap] attempt to fix test_disassemble (PR #140975)

2025-05-21 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: That doesn't solve the issue: ``` File "/Users/mib/Developer/open-source/llvm.org/lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py", line 28, in test_disassemble self.assertIn("location", pc_assembly, "Source location missing.") AssertionError: 'locatio

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-21 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Hey @eronnen, I think this change broke the macOS lldb incremental bot: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/26259/execution/node/106/log/?consoleFull Let me know if you need help to investigate it or if we should revert it if you don't have t

[Lldb-commits] [lldb] [lldb] Convert Maintainers file from reStructuredText -> Markdown (PR #140958)

2025-05-21 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/140958 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Restore ObjC incomplete type dereferencing fix (PR #139567)

2025-05-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/139567 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Restore ObjC incomplete type dereferencing fix (PR #139567)

2025-05-12 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > @felipepiovezan I don't have a machine to run ObjC tests on, could you apply > this patch and see if it fixes the issue in #135843 ? The test pass after applying this patch. Feel free to land this whenever :) https://github.com/llvm/llvm-project/pull/139567 _

[Lldb-commits] [lldb] [lldb] Restore ObjC incomplete type dereferencing fix (PR #139567)

2025-05-12 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > @felipepiovezan I don't have a machine to run ObjC tests on, could you apply > this patch and see if it fixes the issue in #135843 ? I'll try that for you. https://github.com/llvm/llvm-project/pull/139567 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb][cmake] Error out when building debugserver with CMake 4 (PR #138020)

2025-04-30 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Shouldn't we just pre-populate that cmake variable when it's not set ? That would be a better user experience. https://github.com/llvm/llvm-project/pull/138020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-28 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 medismailben wrote: This is probably just an artifact of the downstream fork, I believe @chelcassanova has a fix for this already https://github.com/llvm/llvm-project/pull/136748

[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

2025-04-28 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/137446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

2025-04-25 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/137446 This patch changes the progress count formatting show thousands separator making it easier to read big numbers. >From a293b8b3cd50037998db82b4cd2298489b8b5499 Mon Sep 17 00:00:00 2001 From: Med Ismail Benn

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-25 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Not to derail this too much, but I'm also thinking if we should _stop_ > coloring the column number. Happy to open a patch if people think this is a > good idea? I don't have a strong opinion on this but I'm curious on why coloring the column number is bothering you spec

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-03-30 Thread Med Ismail Bennani via lldb-commits
@@ -744,6 +744,10 @@ let Command = "process continue" in { Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to, temporarily " "ignoring other breakpoints. Can be specified more than once. " "The continue action will be done synchronously if this o

[Lldb-commits] [lldb] Fix the managing of the session dictionary when you have nested wrappers (PR #132846)

2025-03-24 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/132846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

2025-03-24 Thread Med Ismail Bennani via lldb-commits
@@ -38,23 +38,82 @@ class ThreadMemory : public lldb_private::Thread { } const char *GetName() override { -if (!m_name.empty()) - return m_name.c_str(); if (m_backing_thread_sp) return m_backing_thread_sp->GetName(); return nullptr; } cons

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

2025-03-24 Thread Med Ismail Bennani via lldb-commits
@@ -79,34 +136,124 @@ class ThreadMemory : public lldb_private::Thread { } bool SetBackingThread(const lldb::ThreadSP &thread_sp) override { -// printf ("Thread 0x%llx is being backed by thread 0x%llx\n", GetID(), -// thread_sp->GetID()); m_backing_thread_sp =

[Lldb-commits] [lldb] Control the "step out through thunk" logic explicitly when pushing thread plans (PR #129301)

2025-03-02 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Sorry for the delay, LGTM https://github.com/llvm/llvm-project/pull/129301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-22 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/127153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-22 Thread Med Ismail Bennani via lldb-commits
@@ -453,22 +455,16 @@ ScriptedProcess::GetLoadedDynamicLibrariesInfos() { if (!dict->HasKey("load_addr")) return error_with_message("Dictionary is missing key 'load_addr'"); +llvm::StringRef path = ""; medismailben wrote: If you're using a new `

[Lldb-commits] [lldb] [lldb] Document behavior in process launch help (PR #128215)

2025-02-21 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/128215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread Med Ismail Bennani via lldb-commits
@@ -46,22 +46,82 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args: lldb.SBStructuredData if len(self.threads) == 2: self.threads[len(self.threads) - 1].is_stopped = True -corefile_module = self.get_module_with_name( -self.co

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > @jimingham @medismailben Can you please let me know if you have more > questions regarding the problem and solution ? Right now, I have > conditionally ignored the modules which are not created and only loaded the > successful ones, if needed I can always load the success

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-17 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: I'd like to get a better understanding of what you're trying to achieve: Does the child elf-core process doesn't have any module loaded ? Are they only described in the tombstone and require to be downloaded which could potentially fail ? https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-17 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: I'm not convinced of that this change needs to be happen in ScriptedProcess ... May be we could have a setting to not discard all modules loaded in case 1 of them failed to load that would also work with other Process plugins. @jimingham what do you think ? https://github.

[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)

2025-02-17 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/127419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)

2025-02-17 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Nice! LGTM with comment. https://github.com/llvm/llvm-project/pull/127419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)

2025-02-17 Thread Med Ismail Bennani via lldb-commits
@@ -76,6 +77,18 @@ bool ThreadPlanShouldStopHere::DefaultShouldStopHereCallback( } } + // Check whether the frame we are in is a language runtime thunk, only for + // step out: + if (operation == eFrameCompareOlder) { +Symbol *symbol = frame->GetSymbolContext(eSym

[Lldb-commits] [lldb] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue API (PR #126901)

2025-02-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/126901 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve isolation between Process plugins and OS plugins (PR #125302)

2025-02-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/125302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement ${target.file} format variable (PR #123431)

2025-01-17 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/123431 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

2025-01-16 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/123225 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Fix typo in error message when creating a target (PR #122514)

2025-01-10 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/122514 This fixes a typo when creating a target from the crashlog script and that we were not able to find a valid architecture from the crash report. rdar://137344016 >From 4b25769382f81fd03553703624e8b8e48d83a

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: LGTM. nit: I'd have called the API `SBError::GetStructuredError`. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

2024-12-12 Thread Med Ismail Bennani via lldb-commits
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager &diagnostic_manager, const EvaluateExpressionOptions &options, lldb::UserExpressionSP &shared_ptr_to_me, lldb::ExpressionVariableSP &result_va

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Med Ismail Bennani via lldb-commits
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Med Ismail Bennani via lldb-commits
@@ -473,6 +473,38 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK paths the CUs was compiled against. In the + /// presence of different SDKs, we try to pick the most appropriate + /// one

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > or, should we allow base classes to be looked up by name as well? I'd prefer the latter so they can used interchangeably. I like the fact that the subscript can be either an int or a string. https://github.com/llvm/llvm-project/pull/118814 ___

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

2024-12-05 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. Nice! LGTM! https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused field Platform::m_remote_url (PR #118411)

2024-12-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. This doesn't seem to be used anywhere. LGTM! https://github.com/llvm/llvm-project/pull/118411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] Add 'FindFirstSymbolWithNameAndType()' to ModuleList. (PR #117777)

2024-11-28 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > > I'm only using it in an internal branch > > > > Not sure what the protocol is for this (CC @JDevlieghere @labath). At the > very least we should have some coverage for it in the test-suite. There's > precedent for this, e.g., APIs that only get exercised on the Swift

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben requested changes to this pull request. @jasonmolenda I think there is a mistake in your range check. https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
@@ -6184,7 +6184,14 @@ Status Process::GetMemoryRegionInfo(lldb::addr_t load_addr, MemoryRegionInfo &range_info) { if (const lldb::ABISP &abi = GetABI()) load_addr = abi->FixAnyAddress(load_addr); - return DoGetMemoryRegionInfo(load_a

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/111929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Target] Add null-check before dereferencing inlined_info (NFC) (PR #116300)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/116300 This patch is a follow-up to 5b6b0c97ff09de2850577bbabe1f0c296d1c7af1 and adds extra-null checks before dereferencing the inlined_info pointer. >From cbd6cd71cdd99db615445d0c5591482a12b61df8 Mon Sep 17 00:

[Lldb-commits] [lldb] [lldb/Target] Add null-check before dereferencing inlined_info (NFC) (PR #116300)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/116300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Target] Add null-check before dereferencing inlined_info (NFC) (PR #116300)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/116300 >From fd5ba55ee1d1231fc0acf19ee124d811da795a41 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 14 Nov 2024 16:09:53 -0800 Subject: [PATCH] [lldb/Target] Add null-check before dereferencing inl

[Lldb-commits] [lldb] [lldb/Target] Add null-check before dereferencing inlined_info (NFC) (PR #116300)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/116300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/API] Hoist some of SBFrame logic to lldb_private::StackFrame (NFC) (PR #116298)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/116298 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/API] Hoist some of SBFrame logic to lldb_private::StackFrame (NFC) (PR #116298)

2024-11-14 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/116298 This patch moves some of the logic implemented in the SBFrame APIs to the lldb_private::StackFrame class so it can be re-used elsewhere. >From c5bd8c739816988a6a3c710704fc83a298811bf6 Mon Sep 17 00:00:00 2

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/115876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,137 @@ +import os, struct, signal + +from typing import Any, Dict + +import lldb +from lldb.plugins.scripted_process import ScriptedProcess +from lldb.plugins.scripted_process import ScriptedThread + + +class DummyStopHook: +def __init__(self, target, args): +

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with comments. https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,137 @@ +import os, struct, signal + +from typing import Any, Dict + +import lldb +from lldb.plugins.scripted_process import ScriptedProcess +from lldb.plugins.scripted_process import ScriptedThread + + +class DummyStopHook: +def __init__(self, target, args): +

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   4   5   6   7   8   9   10   >