mizvekov wrote:
@emaxx-google thanks for the reproducer.
I will be off to C++Now soon, so it's unlikely I will have time to take a look
at
that in the next two weeks, sorry about that.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/136162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/136158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/136158
>From ba2f21f3619a8079e1ae06a6a01d11be8d98163f Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 17 Apr 2025 13:31:32 -0300
Subject: [PATCH] [ci] add dependencies for lldb python binding tests
Add corr
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/136158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/135630
>From f9afd2f06762c30dd22218d8eacd2cb6599ffb59 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 14 Apr 2025 11:56:01 -0300
Subject: [PATCH] Draft: test
With change:
1) 4m46s -
https://buildkite.com/l
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/135630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/135499
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT
projects="${1}"
targets="${2}"
+runtimes="${3}"
lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml
--use-unique-output-file-name --timeout=1200 --time-tests"
echo "--- cmake"
export PIP_BREAK_SYSTEM_PACKAGES=1
+
pip ins
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/135630
>From 1571fc17e789839bd2f177cca80c0b9f69233cf6 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 14 Apr 2025 11:56:01 -0300
Subject: [PATCH] Draft: test
With change:
1) 4m46s -
https://buildkite.com/l
mizvekov wrote:
In one of these changes we did bump one of these bit fields down to 15 bits,
starting from 16.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
mizvekov wrote:
Could it be you are hitting an overflow/wrap around perhaps?
Some of these nodes store the unsignedOrNone representation in a bitfield, but
that's still 15 bits.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailin
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/135630
>From a1320e77fc49c78a5915335e07c7eb7e8823cd0a Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 14 Apr 2025 11:56:01 -0300
Subject: [PATCH] Draft: test
With change:
1) 4m46s -
https://buildkite.com/l
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/135630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
One thing that looks fishy, but that is even a different node, is this early
return on `VisitSubstNonTypeTemplateParmPackExpr` in `ASTReaderStmt`.
```C++
if (ArgPack.getKind() != TemplateArgument::Pack)
return;
```
This looks impossible to hit, because `getArgumentPack` c
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/135499
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -52,6 +52,8 @@
"clang": {"clang-tools-extra", "compiler-rt", "cross-project-tests"},
"clang-tools-extra": {"libc"},
"mlir": {"flang"},
+# Test everyything if ci scripts are changed.
+".ci": {"llvm", "clang", "lld", "lldb"},
mizvekov wrote
https://github.com/mizvekov deleted
https://github.com/llvm/llvm-project/pull/135499
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -49,17 +52,31 @@ trap at-exit EXIT
projects="${1}"
targets="${2}"
+runtimes="${3}"
lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml
--use-unique-output-file-name --timeout=1200 --time-tests"
echo "--- cmake"
export PIP_BREAK_SYSTEM_PACKAGES=1
+
pip ins
@@ -49,17 +52,31 @@ trap at-exit EXIT
projects="${1}"
targets="${2}"
+runtimes="${3}"
lit_args="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml
--use-unique-output-file-name --timeout=1200 --time-tests"
echo "--- cmake"
export PIP_BREAK_SYSTEM_PACKAGES=1
+
pip ins
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/135499
>From 456d2fd5f7341eaee6278231b8024b4608d7dc53 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 12 Apr 2025 12:57:08 -0300
Subject: [PATCH] [CI] monolithic-linux improvements
Some improvements to mono
@@ -130,12 +132,11 @@ def _add_dependencies(projects: Set[str]) -> Set[str]:
def _compute_projects_to_test(modified_projects: Set[str], platform: str) ->
Set[str]:
projects_to_test = set()
for modified_project in modified_projects:
-# Skip all projects where we
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/135499
>From 70021811ab6551ed38d04a2f740b9e6b330e3290 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 12 Apr 2025 12:57:08 -0300
Subject: [PATCH] [CI] monolithic-linux improvements
Some improvements to mono
mizvekov wrote:
Thanks for that stack trace, could be unrelated to this, but that still helped
find a bug: https://github.com/llvm/llvm-project/pull/135450
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lis
mizvekov wrote:
Okay, if the problem is an uninitialized source location somewhere, then that
patch doesn't help at all.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
mizvekov wrote:
Do you have a backtrace of that uninitialized read?
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
@eaeltsin speculative fix here, but can you try with this patch?
https://github.com/llvm/llvm-project/pull/135434
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
mizvekov wrote:
> We are now seeing non-determinism in `.pcm` files that root-causes to this
> commit.
>
> @mizvekov - might it be something obvious, like pointer-keyed containers or
> similar?
I don't see anything obvious. The only parts of the patch which touch anything
similar to pointer-
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/132234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
Will need to revert a dependent commit, this needs to revert as well so it goes
cleanly.
https://github.com/llvm/llvm-project/pull/132234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
mizvekov wrote:
@nico thanks, that's landed. Let me know if it's all green now, otherwise we
proceed with the revert.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
mizvekov wrote:
> > @alexfh should be fixed by #133613
>
>
>
> Thank you! The crash is resolved. Do you still need a reduced test case?
No worries, the tests included in PR already reproduce it.
https://github.com/llvm/llvm-project/pull/132401
___
mizvekov wrote:
@alexfh should be fixed by https://github.com/llvm/llvm-project/pull/133613
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
mizvekov wrote:
Thanks, this will be fixed here:
https://github.com/llvm/llvm-project/pull/133113
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
mizvekov wrote:
Thanks, that would be appreciated.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
Thanks, for the report, will be fixed by
https://github.com/llvm/llvm-project/pull/132551
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/132280
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
Yeah, clang side unchanged.
The lldb changed stuff is trivial, I don't think it's worth waiting a long time
for lldb input.
https://github.com/llvm/llvm-project/pull/132234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
mizvekov wrote:
But there is reason to cherry-pick
https://github.com/llvm/llvm-project/pull/125791, as it fixes a regression
which would otherwise be introduced in 20.x.
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
mizvekov wrote:
Cherry picking this onto the 20.x release branch requires
https://github.com/llvm/llvm-project/pull/125791 to be cherry-picked first.
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llv
mizvekov wrote:
/cherry-pick 08bda1cc6b0d2f1d31a89a76b5c154a11086c420
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov milestoned
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov milestoned
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov approved this pull request.
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
> > > > > Actually, @mizvekov, can we make the
> > > > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> > > > > &C, Kind DK)` constructor default initialize the `StrictPackMatch`
> > > > > member to false? In that case users of `CreateDeserialize
mizvekov wrote:
> > > Actually, @mizvekov, can we make the
> > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> > > &C, Kind DK)` constructor default initialize the `StrictPackMatch`
> > > member to false? In that case users of `CreateDeserialized` wouldn't need
mizvekov wrote:
> Actually, @mizvekov, can we make the
> `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext
> &C, Kind DK)` constructor default initialize the `StrictPackMatch` member to
> false? In that case users of `CreateDeserialized` wouldn't need to worry
> abo
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/125418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/125418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/125418
>From 29c48b0785af13572a785f90747529ffe7a572ed Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sun, 2 Feb 2025 13:31:20 -0300
Subject: [PATCH] [clang] NFC: rename MatchedPackOnParmToNonPackOnArg to
Strict
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -280,7 +280,8 @@ std::optional
CxxModuleHandler::tryInstantiateStdTemplate(Decl *d) {
new_class_template->getDeclContext(),
new_class_template->getTemplatedDecl()->getLocation(),
new_class_template->getLocation(), new_class_template, imported_args,
-
mizvekov wrote:
> It is not only valuable to external resugarers. Another point that warrants
> an introduction of it is for unevaluated lambdas. These lambdas e.g.
> appearing as part of the `using Alias = decltype(lambda)` could carry a
> requires expression and thus evaluating it requires t
mizvekov wrote:
> @mizvekov I will provide a more detailed response to the points you made in
> your last message separately, but for now I would like to ask you to revert
> the commit to unbreak us.
@gribozavr see https://github.com/llvm/llvm-project/pull/102510 for alternative.
> which mea
mizvekov wrote:
> We keep track of propagated and inferred nullability annotations in a [side
> data
> structure](https://github.com/google/crubit/blob/main/nullability/type_nullability.h#L185).
> Our approach allows us to save on memory by not actually re-instantiating
> everything with new
mizvekov wrote:
> I don't know, but it would be a lot of work, and would likely still mean
> preserving the same information as `SubstTemplateTypeParmType` nodes
> currently provide.
>
> Our scope is also larger than what Clang's resugarer aims to do, because for
> our purposes sometimes ther
mizvekov wrote:
> I agree that we don't need `SubstTemplateTypeParmType` nodes if all
> resuraging that we ever do is related to types that the Clang frontend itself
> knows. However that is not universally true.
>
> For example, we (Google) have a tool for inferring and checking nullability
mizvekov wrote:
One possibility here is that if you have the type, then you will have a
template specialization type for the template alias, and that gives you the
template arguments used to specialize the alias. Which should answer this need.
But of course, if you have a lossy semantic adjust
mizvekov wrote:
The basic premise here was implemented back in D134604, and this has been for
a few years applied in some cases, like substitution of default arguments.
We leave a Subst* node behind with the purpose of somewhere down the line
changing it back to what the user wrote.
So we do
mizvekov wrote:
> @mizvekov, do you have any idea how to get back the lost
> `SubstTemplateTypeParmType`? It plays an important role in the IWYU tool
> analysis. Thanks!
So from my undertstanding, IWYU only needs the SubstTemplateTypeParmType for
resugaring purposes, in order to recover the t
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/101858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/101858
>From 1c6bfceea2a50b822a111996a481afe8fb8e522d Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sun, 23 Oct 2022 16:57:12 +0200
Subject: [PATCH] [clang] Reland: Instantiate alias templates with sugar
This
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/101858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
This missed adding support to StructuralValue template arguments to the
template differ.
See https://github.com/llvm/llvm-project/pull/93265
Te support is still missing, we are just avoiding the crash for now.
https://github.com/llvm/llvm-project/pull/78041
___
Author: Matheus Izvekov
Date: 2022-10-31T17:57:19+01:00
New Revision: 279fe6281d2ca5b2318c7437316c28750feaac8d
URL:
https://github.com/llvm/llvm-project/commit/279fe6281d2ca5b2318c7437316c28750feaac8d
DIFF:
https://github.com/llvm/llvm-project/commit/279fe6281d2ca5b2318c7437316c28750feaac8d.dif
Author: Matheus Izvekov
Date: 2022-10-27T06:18:52+02:00
New Revision: 59f0827e2cf3755834620e7e0b6d946832440f80
URL:
https://github.com/llvm/llvm-project/commit/59f0827e2cf3755834620e7e0b6d946832440f80
DIFF:
https://github.com/llvm/llvm-project/commit/59f0827e2cf3755834620e7e0b6d946832440f80.dif
Author: Matheus Izvekov
Date: 2022-10-26T10:14:21+02:00
New Revision: a58d83b2c97cd480a8533b11b86c7cd709c48176
URL:
https://github.com/llvm/llvm-project/commit/a58d83b2c97cd480a8533b11b86c7cd709c48176
DIFF:
https://github.com/llvm/llvm-project/commit/a58d83b2c97cd480a8533b11b86c7cd709c48176.dif
Author: Matheus Izvekov
Date: 2022-09-16T16:36:00+02:00
New Revision: 67e22983115451ef5512ad2813dd337762c52da3
URL:
https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3
DIFF:
https://github.com/llvm/llvm-project/commit/67e22983115451ef5512ad2813dd337762c52da3.dif
Author: Matheus Izvekov
Date: 2022-09-16T11:55:40+02:00
New Revision: aff1f6310e5f4cea92c4504853d5fd824754a74f
URL:
https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f
DIFF:
https://github.com/llvm/llvm-project/commit/aff1f6310e5f4cea92c4504853d5fd824754a74f.dif
wrote:
>
>
>
> On Sun, Nov 14, 2021 at 3:30 PM Matheus Izvekov via lldb-commits
> wrote:
>>
>>
>> Author: Matheus Izvekov
>> Date: 2021-11-15T00:29:05+01:00
>> New Revision: 6438a52df1c7f36952b6126ff7b978861b76ad45
>>
>
Author: Matheus Izvekov
Date: 2021-11-12T01:47:29+01:00
New Revision: 55085952175ed3b029097a0594acc4e34a5df218
URL:
https://github.com/llvm/llvm-project/commit/55085952175ed3b029097a0594acc4e34a5df218
DIFF:
https://github.com/llvm/llvm-project/commit/55085952175ed3b029097a0594acc4e34a5df218.dif
72 matches
Mail list logo
