[Lldb-commits] [clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

https://github.com/mordante approved this pull request. Thanks, LGTM! https://github.com/llvm/llvm-project/pull/126352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct documentation of LLDB_TEST_USER_ARGS (PR #89042)

https://github.com/mordante approved this pull request. Thanks! The changes LGTM, but I haven't verified the commands work as described. https://github.com/llvm/llvm-project/pull/89042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

mordante wrote: Thanks for the fix! https://github.com/llvm/llvm-project/pull/88312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/88613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

https://github.com/mordante commented: Thanks for the review! https://github.com/llvm/llvm-project/pull/88613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

@@ -0,0 +1,194 @@ +//===-- LibCxxProxyArray.cpp---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/88613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/88312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/88613 These proxies are returned by operator[](...). These proxies all "behave" the same. They store a pointer to the data of the valarray they are a proxy for and they have an internal array of indices. This interna

[Lldb-commits] [lldb] a33a754 - [lldb] Fixes comment typos.

Author: Mark de Wever Date: 2024-04-13T12:03:18+02:00 New Revision: a33a754cff02fda7520fa63fbc6c85c274a44baa URL: https://github.com/llvm/llvm-project/commit/a33a754cff02fda7520fa63fbc6c85c274a44baa DIFF: https://github.com/llvm/llvm-project/commit/a33a754cff02fda7520fa63fbc6c85c274a44baa.diff

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/88178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/88178 >From 5140ce2929ca56c865fc9c02fb0849ba06727c56 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Tue, 19 Mar 2024 20:31:41 +0100 Subject: [PATCH] [lldb][libc++] Adds local_t clock data formatters. --- .../Lan

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

@@ -1068,6 +1068,29 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { eTypeOptionCascade, true); + AddCXXSummary( + cpp_category_sp, + lldb_private::formatters::LibcxxChronoLocalSecondsSummaryProvide

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

https://github.com/mordante ready_for_review https://github.com/llvm/llvm-project/pull/88312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

@@ -751,6 +751,8 @@ def setUpCommands(cls): "settings set symbols.enable-external-lookup false", # Inherit the TCC permissions from the inferior's parent. "settings set target.inherit-tcc true", +# Based on https://discourse.llvm

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/88312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/88312 None >From a94781dd9a993d88dc1eb0897eade23fb4acdf4e Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Wed, 10 Apr 2024 21:12:29 +0200 Subject: [PATCH] [libc++][CI] Tests LLDB libc++ data formatters. --- libc

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/88178 None >From 656ee030e38be24732dd78f96204ce12fe40e788 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Tue, 19 Mar 2024 20:31:41 +0100 Subject: [PATCH] [lldb][libc++] Adds local_t clock data formatters. --- .

[Lldb-commits] [lldb] [lldb][DataFormatter] Fix format specifiers in LibCxxSliceArray summary provider (PR #85763)

https://github.com/mordante approved this pull request. I wasn't aware LLDB's print accepts `%zu`, thanks for the fix! https://github.com/llvm/llvm-project/pull/85763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb][libc++] Adds slice_array data formatters. (PR #85544)

mordante wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/85544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds slice_array data formatters. (PR #85544)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/85544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds slice_array data formatters. (PR #85544)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85544 >From 52d525c8377fe36d2c8c7705736482ee6a021366 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sat, 16 Mar 2024 17:25:32 +0100 Subject: [PATCH 1/2] [lldb][libc++] Adds slice_array data formatters. --- .../P

[Lldb-commits] [lldb] [lldb][libc++] Adds slice_array data formatters. (PR #85544)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/85544 None >From 52d525c8377fe36d2c8c7705736482ee6a021366 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sat, 16 Mar 2024 17:25:32 +0100 Subject: [PATCH] [lldb][libc++] Adds slice_array data formatters. --- ...

[Lldb-commits] [lldb] [LLDB][doc] Updates build instructions. (PR #84630)

mordante wrote: > Looks good. I see the PR test for "Test documentation build" is failing, but > that's an issue with the bot and pexpect. Is this a known issue and is somebody already working on fixing this? https://github.com/llvm/llvm-project/pull/84630 _

[Lldb-commits] [lldb] [LLDB][doc] Updates build instructions. (PR #84630)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/84630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][doc] Updates build instructions. (PR #84630)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/84630 Recently building libc++ requires building libunwind too. This updates the LLDB instructions. I noticed this recently and it was separately filed as https://github.com/llvm/llvm-project/issues/84053 >From 994

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/80609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

@@ -0,0 +1,140 @@ +//===-- LibCxxValarray.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/80609 >From 661f43e0aa40b29ca8bde6c643ee1f3241ecfb17 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 4 Feb 2024 18:46:50 +0100 Subject: [PATCH] [lldb][libc++] Adds valarray data formatters. The code is heavil

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

@@ -750,6 +750,11 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { lldb_private::formatters::LibcxxStdVectorSyntheticFrontEndCreator, "libc++ std::vector synthetic children", "^std::__[[:alnum:]]+::vector<.+>$", stl_deref_flags,

[Lldb-commits] [lldb] [lldb] Fix printf formatting of std::time_t seconds (PR #81078)

mordante wrote: Thanks for the fix! https://github.com/llvm/llvm-project/pull/81078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/80609 The code is heavily based on the vector data formatter. >From 12b03c9ff9f6ddb0a011d8f958e3a826bd7603b9 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 4 Feb 2024 18:46:50 +0100 Subject: [PATCH] [lldb][l

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

mordante wrote: @jasonmolenda I'm not using a mac, but based on your results I expect that `std::size_t` is a 64-bit _unsigned_ integer type. Is that correct? https://github.com/llvm/llvm-project/pull/78609 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [libc] [clang-tools-extra] [mlir] [lldb] [flang] [compiler-rt] [libcxx] [llvm] [libunwind] [clang] [lld] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (P

mordante wrote: > @mordante I guess the PR missed LLVM18 release. I'll update the release notes > accordingly. Is that OK? Yes. It would have been nice to get this in LLVM 18, but I don't feel it's critical to backport it. (Especially since it's a C++26 only feature and I expect very few peop

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/78609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/78609 >From 31a7604f872116521558dcb9f1b4c2c4f5f9d439 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 18 Jan 2024 19:21:09 +0100 Subject: [PATCH 1/2] [lldb][libc++] Adds system_clock data formatters. --- .../

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

@@ -32,6 +32,106 @@ def test_with_run_command(self): self.expect("frame variable m", substrs=["m = 4321 months"]) self.expect("frame variable y", substrs=["y = 321 years"]) +self.expect( +"frame variable ss_tp", +substrs=["ss_tp

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

@@ -1073,18 +1073,79 @@ bool lldb_private::formatters::LibcxxWStringViewSummaryProvider( bool success; ValueObjectSP dataobj; size_t size; - std::tie( success, dataobj, size ) = LibcxxExtractStringViewData(valobj); + std::tie(success, dataobj, size) = LibcxxExtractStri

[Lldb-commits] [lld] [openmp] [libcxxabi] [libunwind] [clang-tools-extra] [libc] [libcxx] [compiler-rt] [lldb] [llvm] [clang] [mlir] [polly] [flang] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,397 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [libunwind] [llvm] [flang] [clang-tools-extra] [mlir] [lldb] [libcxxabi] [compiler-rt] [lld] [polly] [libcxx] [clang] [openmp] [libc] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [polly] [clang-tools-extra] [libcxxabi] [libcxx] [mlir] [lld] [clang] [compiler-rt] [libc] [flang] [libunwind] [llvm] [openmp] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante approved this pull request. LGTM modulo one typo. https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [polly] [clang] [lldb] [libcxx] [clang-tools-extra] [libcxxabi] [libc] [libunwind] [openmp] [lld] [llvm] [mlir] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,458 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [mlir] [openmp] [llvm] [clang] [libcxx] [libc] [lldb] [clang-tools-extra] [lld] [libunwind] [flang] [polly] [libcxxabi] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,172 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [flang] [clang-tools-extra] [compiler-rt] [libunwind] [openmp] [lldb] [llvm] [libc] [libcxx] [mlir] [clang] [polly] [libcxxabi] [lld] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,458 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [mlir] [libunwind] [llvm] [libcxx] [lldb] [openmp] [polly] [lld] [libc] [compiler-rt] [clang-tools-extra] [flang] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,172 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [openmp] [flang] [compiler-rt] [lld] [clang] [polly] [mlir] [libcxx] [clang-tools-extra] [libcxxabi] [lldb] [llvm] [libunwind] [libc] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante requested changes to this pull request. > I did some re-imagining of the tests, there is a some redundancy but it is > cleared that nothing was missed. The tests are formatted in tabular form > manually to make them easier to read. Redundant code in tests when if i

[Lldb-commits] [lldb] [polly] [libunwind] [libc] [llvm] [clang-tools-extra] [libcxx] [libcxxabi] [compiler-rt] [openmp] [lld] [flang] [mlir] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [lld] [libcxx] [openmp] [llvm] [clang-tools-extra] [flang] [clang] [mlir] [libc] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante approved this pull request. Still LGTM! https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libc] [flang] [mlir] [libcxx] [lldb] [clang-tools-extra] [openmp] [clang] [llvm] [lld] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [llvm] [mlir] [lldb] [clang] [compiler-rt] [lld] [libc] [libcxx] [flang] [clang-tools-extra] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -1513,6 +1519,11 @@ __sanitizer_verify_double_ended_contiguous_container(const void*, const void*, c #define _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK # endif +// Clang-18 has support for deducing this, but it does not set the FTM. +#if defined(__cpp_explicit_this_

[Lldb-commits] [clang] [lld] [lldb] [flang] [mlir] [llvm] [libcxx] [libc] [openmp] [compiler-rt] [clang-tools-extra] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -7,7 +7,8 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME -// XFAIL: clang-16 || clang-17 +// The tested functionality needs deducing this. +// UNSUPPORTED: clang-16 || clang-17 || apple-clang mordante wro

[Lldb-commits] [flang] [clang] [mlir] [llvm] [libcxx] [libc] [lld] [lldb] [compiler-rt] [clang-tools-extra] [openmp] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante approved this pull request. Thanks LGTM modulo a few minor comment. https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [clang-tools-extra] [clang] [mlir] [llvm] [openmp] [compiler-rt] [libcxx] [lld] [flang] [libc] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -470,4 +470,9 @@ inline Tp const& DoNotOptimize(Tp const& value) { # define TEST_IF_AIX(arg_true, arg_false) arg_false #endif +// Clang-18 has support for deducing this, but it does not set the FTM. +#if defined(__cpp_explicit_this_parameter) || (defined(_LIBCPP_CLANG_VER)

[Lldb-commits] [openmp] [clang] [lld] [libc] [lldb] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [mlir] [flang] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [lld] [compiler-rt] [libcxx] [lldb] [clang-tools-extra] [flang] [llvm] [openmp] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1273,6 +1293,24 @@ public: __impl_.__swap(__that.__impl_); } +# if _LIBCPP_STD_VER >= 26 && defined(_LIBCPP_HAS_EXPLICIT_THIS_PARAMETER) + struct __variant_visit_barrier_tag { // unnamable when using standard library modules mordante wrote: I'm n

[Lldb-commits] [compiler-rt] [clang] [lld] [openmp] [libc] [llvm] [lldb] [libcxx] [flang] [clang-tools-extra] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1130,6 +1137,19 @@ using __best_match_t = typename invoke_result_t<_MakeOverloads<_Types...>, _Tp, } // namespace __variant_detail +template < class _Visitor, class... _Vs, typename = void_t()))...> > +_LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_THROW_BAD_VARIANT_ACCESS

[Lldb-commits] [openmp] [clang] [lld] [libc] [lldb] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [flang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -0,0 +1,357 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [libc] [flang] [openmp] [lld] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1267,7 +1267,11 @@ def add_version_header(tc): }, { "name": "__cpp_lib_variant", -"values": {"c++17": 202102}, +"values": { +"c++17": 202102, # std::visit for classes derived from std::variant +

[Lldb-commits] [llvm] [clang] [libcxx] [compiler-rt] [libc] [lldb] [lld] [clang-tools-extra] [flang] [openmp] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -0,0 +1,48 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [libc] [openmp] [libcxx] [flang] [lld] [clang-tools-extra] [llvm] [compiler-rt] [lldb] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante requested changes to this pull request. Mostly LGTM, I like to see it again for a quick look. https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] [llvm] [compiler-rt] [flang] [openmp] [clang] [clang-tools-extra] [lld] [libcxx] [libc] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [clang] [llvm] [compiler-rt] [openmp] [lldb] [clang-tools-extra] [flang] [libc] [libcxx] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1130,6 +1137,19 @@ using __best_match_t = typename invoke_result_t<_MakeOverloads<_Types...>, _Tp, } // namespace __variant_detail +template < class _Visitor, class... _Vs, typename = void_t()))...> > mordante wrote: Clang-format needs to be compatible

[Lldb-commits] [clang-tools-extra] [flang] [openmp] [llvm] [compiler-rt] [libc] [libcxx] [clang] [lld] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1130,6 +1137,19 @@ using __best_match_t = typename invoke_result_t<_MakeOverloads<_Types...>, _Tp, } // namespace __variant_detail +template < class _Visitor, class... _Vs, typename = void_t()))...> > +_LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_THROW_BAD_VARIANT_ACCESS

[Lldb-commits] [openmp] [mlir] [llvm] [libc] [lldb] [clang] [compiler-rt] [flang] [clang-tools-extra] [libcxx] [lld] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -144,7 +144,8 @@ _LIBCPP_HIDE_FROM_ABI decltype(auto) __visit_format_arg(_Visitor&& __vis, basic_ __libcpp_unreachable(); } -# if _LIBCPP_STD_VER >= 26 +# if _LIBCPP_STD_VER >= 26 && (!defined(_LIBCPP_COMPILER_CLANG_BASED) || _LIBCPP_CLANG_VER >= 1800) ---

[Lldb-commits] [clang-tools-extra] [llvm] [mlir] [libcxx] [compiler-rt] [clang] [libc] [lldb] [libcxxabi] [polly] [libunwind] [flang] [libc++][any] LWG3305: `any_cast` (PR #78215)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/78215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [llvm] [mlir] [libcxx] [lldb] [libcxxabi] [polly] [flang] [libunwind] [compiler-rt] [clang] [clang-tools-extra] [libc++][any] LWG3305: `any_cast` (PR #78215)

@@ -555,6 +556,7 @@ inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST _ValueType template inline _LIBCPP_HIDE_FROM_ABI add_pointer_t> any_cast(any const* __any) _NOEXCEPT { + static_assert(!is_void_v<_ValueType>, "_ValueType may not be void."); -

[Lldb-commits] [libcxxabi] [mlir] [llvm] [libc] [lldb] [libunwind] [clang] [compiler-rt] [flang] [clang-tools-extra] [libcxx] [polly] [libc++][any] LWG3305: `any_cast` (PR #78215)

https://github.com/mordante approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/78215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [libcxx] [lldb] [flang] [llvm] [libc] [clang] [compiler-rt] [mlir] [clang-tools-extra] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -144,7 +144,8 @@ _LIBCPP_HIDE_FROM_ABI decltype(auto) __visit_format_arg(_Visitor&& __vis, basic_ __libcpp_unreachable(); } -# if _LIBCPP_STD_VER >= 26 +# if _LIBCPP_STD_VER >= 26 && (!defined(_LIBCPP_COMPILER_CLANG_BASED) || _LIBCPP_CLANG_VER >= 1800) ---

[Lldb-commits] [libcxx] [compiler-rt] [clang-tools-extra] [flang] [llvm] [lldb] [lld] [libc] [mlir] [clang] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -0,0 +1,36 @@ +//===--===// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[Lldb-commits] [lld] [libc] [llvm] [libcxx] [clang-tools-extra] [lldb] [clang] [mlir] [compiler-rt] [flang] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -267,7 +366,8 @@ class _LIBCPP_TEMPLATE_VIS basic_format_arg<_Context>::handle { // This function is user facing, so it must wrap the non-standard types of // the "variant" in a handle to stay conforming. See __arg_t for more details. template -_LIBCPP_HIDE_FROM_ABI declty

[Lldb-commits] [libcxx] [clang-tools-extra] [mlir] [clang] [libc] [llvm] [flang] [lld] [compiler-rt] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -19,19 +19,25 @@ #include "test_macros.h" #include "make_string.h" +#if _LIBCPP_STD_VER >= 26 +TEST_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations") +#endif + template void test(From value) { auto store = std::make_format_args(value); const std::basic_format_a

[Lldb-commits] [llvm] [clang-tools-extra] [compiler-rt] [libcxx] [clang] [flang] [libc] [mlir] [lldb] [lld] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -7,6 +7,7 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME +// XFAIL: clang-16 || clang-17 mordante wrote: We know it fails so there is no real need to test that. Quite often we do XFAIL when we want to up

[Lldb-commits] [flang] [mlir] [clang-tools-extra] [llvm] [clang] [libc] [lld] [lldb] [compiler-rt] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -163,20 +163,26 @@ class _LIBCPP_TEMPLATE_VIS basic_format_context basic_format_arg { -if constexpr (same_as) - return {}; -else if constexpr (same_as::handle>) - // At the moment it's not possible for formatting

[Lldb-commits] [flang] [mlir] [libcxx] [clang] [clang-tools-extra] [llvm] [libc] [compiler-rt] [lld] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -193,7 +194,8 @@ _LIBCPP_HIDE_FROM_ABI _Rp __visit_format_arg(_Visitor&& __vis, basic_format_arg< __libcpp_unreachable(); } -# endif + +# endif // if _LIBCPP_STD_VER >= 26 mordante wrote: ```suggestion # endif // if _LIBCPP_STD_VER >= 26 && defined(

[Lldb-commits] [compiler-rt] [lldb] [libc] [clang-tools-extra] [mlir] [llvm] [clang] [flang] [lld] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -19,19 +19,25 @@ #include "test_macros.h" #include "make_string.h" +#if _LIBCPP_STD_VER >= 26 +TEST_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations") +#endif + template void test(From value) { auto store = std::make_format_args(value); const std::basic_format_a

[Lldb-commits] [clang-tools-extra] [llvm] [compiler-rt] [mlir] [clang] [libc] [flang] [libcxx] [lldb] [lld] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -163,20 +163,26 @@ class _LIBCPP_TEMPLATE_VIS basic_format_context basic_format_arg { -if constexpr (same_as) - return {}; -else if constexpr (same_as::handle>) - // At the moment it's not possible for formatting

[Lldb-commits] [mlir] [lldb] [libc] [clang] [flang] [compiler-rt] [clang-tools-extra] [lld] [llvm] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante requested changes to this pull request. In general this looks good. I'd like to have another look after addressing the comments. https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [flang] [lld] [compiler-rt] [clang] [clang-tools-extra] [mlir] [libcxx] [libc] [llvm] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/78609 None >From 31a7604f872116521558dcb9f1b4c2c4f5f9d439 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 18 Jan 2024 19:21:09 +0100 Subject: [PATCH] [lldb][libc++] Adds system_clock data formatters. --- ..

[Lldb-commits] [polly] [clang-tools-extra] [libc] [libcxxabi] [lld] [libunwind] [flang] [mlir] [llvm] [compiler-rt] [libcxx] [clang] [openmp] [lldb] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,281 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [llvm] [mlir] [libc] [openmp] [libcxx] [polly] [compiler-rt] [lldb] [flang] [clang-tools-extra] [libunwind] [libcxxabi] [lld] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,267 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [libunwind] [flang] [mlir] [openmp] [clang-tools-extra] [lldb] [polly] [compiler-rt] [clang] [lld] [llvm] [libcxx] [libc] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,281 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [libcxxabi] [clang-tools-extra] [libunwind] [openmp] [lldb] [mlir] [flang] [libcxx] [lld] [libc] [compiler-rt] [polly] [llvm] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [clang-tools-extra] [lld] [libcxxabi] [lldb] [libunwind] [llvm] [libcxx] [openmp] [libc] [clang] [mlir] [flang] [polly] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,267 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [mlir] [lld] [openmp] [polly] [flang] [llvm] [lldb] [clang] [clang-tools-extra] [libcxxabi] [libc] [libunwind] [compiler-rt] [libcxx] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,267 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang-tools-extra] [libcxxabi] [mlir] [clang] [polly] [openmp] [lldb] [flang] [libunwind] [compiler-rt] [libc] [llvm] [lld] [libcxx] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,281 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang-tools-extra] [libcxxabi] [lld] [clang] [libc] [libcxx] [lldb] [polly] [libunwind] [flang] [openmp] [mlir] [llvm] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,157 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [libc] [polly] [openmp] [clang-tools-extra] [compiler-rt] [libunwind] [flang] [lldb] [clang] [libcxx] [mlir] [lld] [llvm] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [polly] [flang] [llvm] [libunwind] [mlir] [clang-tools-extra] [libc] [openmp] [libcxxabi] [clang] [compiler-rt] [libcxx] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,76 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [clang-tools-extra] [lldb] [compiler-rt] [mlir] [libcxx] [openmp] [llvm] [libcxxabi] [lld] [clang] [libc] [libunwind] [polly] [flang] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,75 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [flang] [llvm] [libcxx] [libunwind] [lld] [clang] [mlir] [libc] [clang-tools-extra] [compiler-rt] [lldb] [libcxxabi] [openmp] [polly] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante requested changes to this pull request. Thanks I think this is getting close, I would like to see it again after addressing the comments. https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [clang] [llvm] [libcxx] [flang] [lldb] [libcxxabi] [libunwind] [compiler-rt] [libc] [clang-tools-extra] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

@@ -5,39 +5,134 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===--===// + // UNSUPPORTED: c++03, c++11, c++14, c++17 // -#include +// constexpr explicit(extent != dynamic_extent)

[Lldb-commits] [libc] [compiler-rt] [libcxxabi] [lldb] [llvm] [clang] [flang] [clang-tools-extra] [libunwind] [libcxx] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [libunwind] [libcxxabi] [llvm] [flang] [libc] [libcxx] [lldb] [clang] [clang-tools-extra] [compiler-rt] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/78157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [libc] [llvm] [clang] [libcxxabi] [libunwind] [libcxx] [flang] [compiler-rt] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

https://github.com/mordante approved this pull request. > Thanks. The documentation build fails due to some CMake error consistently > otherwise I believe I addressed all comments. I think I fixed this a few days ago. LGTM modulo 1 nit. https://github.com/llvm/llvm-project/pull/78157 ___

[Lldb-commits] [clang-tools-extra] [clang] [lldb] [polly] [libcxx] [llvm] [mlir] [compiler-rt] [libunwind] [libc] [libcxxabi] [flang] [libc++][any] LWG3305: `any_cast` (PR #78215)

mordante wrote: > > I see you implemented this code only for C++26. In general we retroactively > > apply LWG issues to all previous standard versions. Is there a reason why > > you only applied this to C++26? > > I am not familiar with this process. I'm happy to do what's needed to be > done

[Lldb-commits] [libc] [llvm] [lld] [flang] [libcxx] [libunwind] [mlir] [clang] [compiler-rt] [lldb] [libcxxabi] [clang-tools-extra] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [libc] [lldb] [libunwind] [libcxx] [clang-tools-extra] [libcxxabi] [llvm] [compiler-rt] [lld] [clang] [flang] [mlir] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [clang] [libcxx] [mlir] [llvm] [lld] [compiler-rt] [clang-tools-extra] [flang] [lldb] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[Lldb-commits] [lldb] [llvm] [libcxx] [mlir] [clang-tools-extra] [compiler-rt] [lld] [flang] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

  1   2   >