junior-jl wrote:
> LGTM.
>
> Unless you've got commit access yourself, I can land this for you on Monday.
Great!
I don't have write access. So... as soon as this get merged, I'll open the
other PR!
Thanks again for the help here!
https://github.com/llvm/llvm-project/pull/76112
junior-jl wrote:
> Do a check for unused calls to getregexmatch, I found a few I think.
Done in the last commit. There was the two you mentioned and another one.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commit
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From fb2383f3e6e2124e4f14e8e0f6a04df4bed15f65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 18 Jan 2024 20:03:25 -0300
Subject: [PATCH 1/3] refactor PutCStringColorHighlight |
junior-jl wrote:
> Maybe this is me being used to monster functions in lldb, but this one seems
> fine. At least the volume of code.
What you could do is "early return" (/early continue) in a couple of places to
reduce the indentation.
> 1. You could early return if there are no matches.
> 2.
junior-jl wrote:
Last commit changes:
- Renamed `pattern_info` to `settings` in all of its uses.
- Moved `HighlightSettings` declaration outside `for` loop.
- Edited commit message as suggested.
> So you're asking about "stacked PRs" and I myself haven't tried this. LLVM
> has recently enabled
@@ -260,10 +271,9 @@ class Stream {
/// The ANSI color code to end colorization. This is
/// environment-dependent.
- void PutCStringColorHighlighted(llvm::StringRef text,
- llvm::StringRef pattern = "",
-
@@ -1618,22 +1621,25 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
for (uint32_t i = 0; i < num_matches; ++i) {
Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]);
if (symbol) {
+Stream::HighlightSettings pattern_info(
+
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From fb2383f3e6e2124e4f14e8e0f6a04df4bed15f65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 18 Jan 2024 20:03:25 -0300
Subject: [PATCH 1/2] refactor PutCStringColorHighlight |
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -72,23 +72,21 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
-void Stream::PutCStringColorHighlighted(llvm::StringRef text,
-llvm::StringRef pattern,
-llvm::String
@@ -262,14 +263,12 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
}
if (ConstString demangled = m_mangled.GetDemangledName()) {
s->PutCString(", name=\"");
-s->PutCStringColorHighlighted(demangled.GetStringRef(), pattern,
-
@@ -1609,6 +1612,11 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
}
if (num_matches > 0) {
+llvm::StringRef ansi_prefix =
+interpreter.GetDebugger().GetRegexMatchAnsiPrefix();
+llvm::StringRef ansi_suffix =
+interpreter.G
@@ -23,6 +23,16 @@
namespace lldb_private {
+struct Information {
junior-jl wrote:
Done.
I was thinking: should we add a default constructor?
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits maili
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From fb2383f3e6e2124e4f14e8e0f6a04df4bed15f65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 18 Jan 2024 20:03:25 -0300
Subject: [PATCH] refactor PutCStringColorHighlight | add
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From b2d254fabcaacb849ba48e342c62abf7ecd9779a Mon Sep 17 00:00:00 2001
From: taalhaataahir0102 <23100...@lums.edu.pk>
Date: Wed, 13 Dec 2023 15:12:29 +0500
Subject: [PATCH 1/6] Using struct for transfering patte
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From b2d254fabcaacb849ba48e342c62abf7ecd9779a Mon Sep 17 00:00:00 2001
From: taalhaataahir0102 <23100...@lums.edu.pk>
Date: Wed, 13 Dec 2023 15:12:29 +0500
Subject: [PATCH 1/5] Using struct for transfering patte
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl created
https://github.com/llvm/llvm-project/pull/76112
Follow-up to #69422.
This commit builds upon the previous contribution that introduced symbol
colorization in the image lookup command when using regex. In response to
feedback from reviewers, this follow-up
junior-jl wrote:
> > I tried this now and I guess it's not correct. For example, if I have a
> > prefix (red color) and no suffix, the text does not go back to normal and
> > will be forever red. Or am I doing something wrong?
>
> This is expected. We don't expect many people to do this but if
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 01/10] [lldb] colorize symbols in image lo
junior-jl wrote:
> I tried this now and I guess it's not correct. For example, if I have a
> prefix (red color) and no suffix, the text does not go back to normal and
> will be forever red. Or am I doing something wrong?
 and no suffix, the text does not go back to normal and will be
forever red. Or am I doing something wrong?
> Or rath
junior-jl wrote:
> You could do:
s->PutCStringColorHighlighted(symbol->GetName().GetStringRef(), pattern,
target_sp ? target_sp->GetDebugger().GetRegexMatchAnsiPrefix() :
"",
target_sp ? target_sp->GetDebugger().GetRegexMatchAnsiSuffix() :
"");
I
junior-jl wrote:
In the last commit:
- Added the conditions `prefix.empty()` and `suffix.empty()` to the 'no color'
path.
- Added missing arguments to `PutCStringColorHighlighted` call in
`SymbolContext` (line 177).
I had to copy the same statements from line 99 here. Is it better if I declar
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/9] [lldb] colorize symbols in image look
junior-jl wrote:
Addressed @JDevlieghere suggestions.
- A new debugger option was created for custom colors.
- The test needed some adaptation and we added a new case to test for other
color option.
- The `SymbolContext` situtation is working as discussed with David: no color
when there is no
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/8] [lldb] colorize symbols in image look
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
-uint32_t addr_byte_size = UINT32_MAX,
-bool all_ranges =
@@ -231,6 +231,25 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C string \a text to the stream, applying red color highlighting
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
-uint32_t addr_byte_size = UINT32_MAX,
-bool all_ranges =
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -1593,6 +1595,7 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
return 0;
SymbolContext sc;
+ bool use_color = interpreter.GetDebugger().GetUseColor();
junior-jl wrote:
Done.
https://github.com/llvm/llvm-project/pull/69422
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
-uint32_t addr_byte_size = UINT32_MAX,
-bool all_ranges =
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/7] [lldb] colorize symbols in image look
@@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
if (symbol->ValueIsAddress()) {
DumpAddress(
interpreter.GetExecutionContext().GetBestExecutionContextScope(),
- symbol->GetAddressRef(),
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/2] [lldb] colorize symbols in image look
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/2] [lldb] colorize symbols in image look
junior-jl wrote:
> Opinions differ on what goes in a commit message but this seems fine to me,
> I'd just remove the sub-headings. My usual rule is that folks can choose not
> to read it if they don't want to, include as much information as you would
> want to see if you yourself had to come b
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
> Also could you include a bit more explanation of the problem in the commit
> message. The issue is great, but it'll save someone a few clicks if you just
> include a sentence or two more in the commit message.
I added more information. Now that you taught me that the PR desc
junior-jl wrote:
> I was about to tell you about the `process launch -m` shortcut, then I
> realised you added that yourself :) (I'm using it all the time now)
Haha, that's great to know! 🥹
> This is actually good news then, we already have test coverage. Please
> re-order the expected output
@@ -265,8 +265,6 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
process_sp->SyncIOHandler(0, std::chrono::seconds(2));
llvm::StringRef data = stream.GetString();
junior-jl wrote:
Done! Yes, as you expected,
@@ -282,6 +280,8 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
exe_module_sp->GetFileSpec().GetPath().c_str(), archname);
}
result.SetStatus(eReturnStatusSuccessFinishResult);
+if (!data.empty())
---
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/73173
From e451fe7a466f90557c301f0775d65caaa8955a8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Wed, 22 Nov 2023 18:26:14 -0300
Subject: [PATCH 1/2] [lldb] correct inconsistent order of
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
> When you're doing these updates, remember that the PR's message is the one
> used for the final merge. You can update both if you like, but the PR message
> wins.
(for llvm-project that is, this is a per-repository setting)
I was Googling about this now. Thank you for the cl
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
Hi @emaste, I've updated the commit message. When squashing the commits, the
commit message defaulted to the names of the previous commits. I've added a
brief description of the contribution – please let me know if this needs any
adjustments.
https://github.com/llvm/llvm-proj
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/junior-jl created
https://github.com/llvm/llvm-project/pull/73173
## Overview
This pull request addresses the issue
[#68035](https://github.com/llvm/llvm-project/issues/68035), where an
inconsistency in the order of "Process launched" and "Process stopped" messages
occurs
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From a15d0cdc0330fe811ce65dc4d62374fd12304cef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 8e5e67ff640aa0ff14b1a0bd0110b88c539ccfe8 Mon Sep 17 00:00:00 2001
From: taalhaataahir0102 <23100...@lums.edu.pk>
Date: Wed, 11 Oct 2023 14:27:15 +0500
Subject: [PATCH 1/3] colorization
---
lldb/include/ll
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/5] [lldb] colorize symbols in image look
@@ -231,6 +231,18 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C string \a text to the stream, applying color highlighting to
@@ -231,6 +231,18 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C string \a text to the stream, applying color highlighting to
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if (p
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text.data());
---
junior-jl wrote:
In this last commit, your suggestions on the algorithm were done (the use of
`remaining` instead of `text` and `drop_front`. Also, the method is now on
`Stream` and called `PutCStringColorHighlighted` as you recommended. It looks
way better that way.
> Then later use that wit
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/3] [lldb] colorize symbols in image look
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if (p
@@ -252,11 +253,16 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s->Printf(", value = 0x%16.16" PRIx64,
m_addr_range.GetBaseAddress().GetOffset());
}
- ConstString demangled = GetMangled().GetDemangledName();
- if (demangled)
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -95,7 +97,8 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
if (!name)
name = function->GetName();
if (name)
-name.Dump(s);
+pattern ? Address::DumpName(s, name.GetStringRef(), pattern)
+
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -253,9 +264,20 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
m_addr_range.GetBaseAddress().GetOffset());
}
ConstString demangled = GetMangled().GetDemangledName();
- if (demangled)
+
+ // Checking if the name (i.e., searched s
junior-jl wrote:
>>
- Please remove any commented out code, comments that are now obvious from
reading the code, etc.
- Rename name to pattern, it will be a 1000% less confusing for all of us :)
- Make sure that ninja check-lldb has no failures.
- clang-format your changes (http
@@ -163,6 +176,14 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
+
+ // Similar here, Using DumpName if th
@@ -0,0 +1,25 @@
+# RUN: %clang_host -g %S/Inputs/main.c -o %t
junior-jl wrote:
Yes, I believe that was the case. Removed the other test.
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
ll
@@ -89,13 +97,18 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
s->Printf("<");
dumped_something = true;
} else {
- ConstString name;
+ ConstString name_func;
junior-jl wrote:
Since the argument i
@@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s->Printf(", value = 0x%16.16" PRIx64,
m_addr_range.GetBaseAddress().GetOffset());
}
- ConstString demangled = GetMangled().GetDemangledName();
- if (demangled)
@@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s->Printf(", value = 0x%16.16" PRIx64,
m_addr_range.GetBaseAddress().GetOffset());
}
- ConstString demangled = GetMangled().GetDemangledName();
- if (demangled)
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 620ce688faba76bee7deb1429e7499f473d7509c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From a857d725625ea0d094da1860316f5204f11c9ba1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 7f228a5c2ef65ba595ca9b7c0d7227cd82f63b3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
junior-jl wrote:
Hi David! I'm working with @taalhaataahir0102 on this. I addressed some of your
comments.
First, in the renamed `DumpName`, I tried using `llvm` Regex instead of `std`.
It is passing the tests, so I hope it's okay. One question about it, do you
think `Address` is the right cl
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
Addressed @JDevlieghere comments regarding formatting and inlined comments.
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 6fd515e6e6cd392128410b30d243714c4bcc549b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 3 Oct 2023 15:28:45 -0300
Subject: [PATCH] [lldb] add stop-at-user-entry option to p
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From c5466f3d06b1859e5ea880a4c88dca91e85f5b4b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 3 Oct 2023 15:28:45 -0300
Subject: [PATCH] [lldb] add stop-at-user-entry option to p
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 5e03656813dfa9ff5985a9e1aa7a001872115500 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 3 Oct 2023 15:28:45 -0300
Subject: [PATCH] [lldb] add stop-at-user-entry option to p
@@ -8,18 +8,21 @@
#include "CommandOptionsProcessLaunch.h"
+#include "lldb/Core/Module.h"
#include "lldb/Host/FileSystem.h"
#include "lldb/Host/HostInfo.h"
#include "lldb/Host/OptionParser.h"
#include "lldb/Interpreter/CommandCompletions.h"
#include "lldb/Interpreter/Com
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 6de148adcdd1eedea7e23b4e267c6f42bb68bc45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 3 Oct 2023 15:28:45 -0300
Subject: [PATCH 1/3] [lldb] add stop-at-user-entry option
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -335,6 +335,48 @@ BreakpointSP Target::GetBreakpointByID(break_id_t
break_id) {
return bp_sp;
}
+lldb::BreakpointSP lldb_private::Target::CreateBreakpointAtUserEntry() {
+ TargetSP target_sp = shared_from_this();
+ Status error;
+ ModuleSP main_module_sp = target_sp->
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 6de148adcdd1eedea7e23b4e267c6f42bb68bc45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 3 Oct 2023 15:28:45 -0300
Subject: [PATCH 1/2] [lldb] add stop-at-user-entry option
1 - 100 of 163 matches
Mail list logo
