[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-20 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thank you for breaking this change up into smaller patches, that's always a good idea and will certainly help with reviewing. Given that this is a significant new feature, could you please start an RFC on [Discourse](https://discourse.llvm.org/c/subprojects/lldb/8)? We had

[Lldb-commits] [lldb] [lldb] Recognize MTE fault Mach exceptions (PR #159117)

2025-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/159117 Recognize an MTE tag fault Mach exception. A tag fault is an error reported by Arm's Memory Tagging Extension (MTE) when a memory access attempts to use a pointer with a tag that doesn't match the tag stor

[Lldb-commits] [lldb] [lldb] Change directory creation logic in framework-header-fix (PR #158355)

2025-09-20 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Why don't we ensure the build system creates the directory instead? https://github.com/llvm/llvm-project/pull/158355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb-dap] Add invalidated event (PR #157530)

2025-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/157530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Turn LineEntry into a class and make AddressRange member optional (PR #158811)

2025-09-20 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can we break this up into an NFC patch that makes `LineEntry` a class and a separate PR for the functional change that makes `AddressRange` optional? https://github.com/llvm/llvm-project/pull/158811 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -271,6 +283,131 @@ class ObjectFileMachO : public lldb_private::ObjectFile { uint32_t strsize = 0; /* string table size in bytes */ }; + // The LC_DYLD_INFO's dyld_info_command has 32-bit file offsets + // that we will use as virtual address offsets, and may ne

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo Doxygen comments. https://github.com/llvm/llvm-project/pull/159849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/159849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -271,6 +283,131 @@ class ObjectFileMachO : public lldb_private::ObjectFile { uint32_t strsize = 0; /* string table size in bytes */ }; + // The LC_DYLD_INFO's dyld_info_command has 32-bit file offsets + // that we will use as virtual address offsets, and may ne

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Looks good, thank you! https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Using the session ID sounds fine. I suppose the first segment of the UUID is unique enough, so if it's easy, I'd lean towards that. I also think we can drop the `-session` and `-vscode` from the filename (unless forks like cursor would report something else and folks think

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/159160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -164,48 +126,65 @@ void Server::AddResourceProvider( m_resource_providers.push_back(std::move(resource_provider)); } -void Server::AddRequestHandler(llvm::StringRef method, RequestHandler handler) { - m_request_handlers[method] = std::move(handler); -} - -void Server::A

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -69,7 +114,8 @@ template class Transport { /// Sends a response to a specific request. virtual llvm::Error Send(const Resp &) = 0; - /// Implemented to handle incoming messages. (See Run() below). + /// Implemented to handle incoming messages. (See `RegisterMessageH

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -297,6 +340,450 @@ class JSONRPCTransport : public IOTransport { static constexpr llvm::StringLiteral kMessageSeparator = "\n"; }; -} // namespace lldb_private +/// A handler for the response to an outgoing request. +template +using Reply = +std::conditional_t, +

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +58,54 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +/// An error to indicate that the parameters of a Req, Resp or Evt could not be +/// deserialized. +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + +

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -297,6 +340,450 @@ class JSONRPCTransport : public IOTransport { static constexpr llvm::StringLiteral kMessageSeparator = "\n"; }; -} // namespace lldb_private +/// A handler for the response to an outgoing request. +template +using Reply = +std::conditional_t, +

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -322,6 +323,17 @@ struct CallToolResult { llvm::json::Value toJSON(const CallToolResult &); bool fromJSON(const llvm::json::Value &, CallToolResult &, llvm::json::Path); +lldb_protocol::mcp::Request +MakeRequest(int64_t id, llvm::StringRef method, +std::optional

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Thanks, this is looking good. Left some nits, but I think I have a good grasp on the Binder now. I assume the plan is to use the Binder for `lldb-dap` too? https://github.com/llvm/llvm-project/pull/159160 __

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/159825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] install lldb-tblgen by default to ease cross-compilation (one-liner) (PR #159812)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add command line option `--connection-timeout` (PR #156803)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/156803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] NFC: SBThread should not be the one to compute StopReasonData. (PR #157577)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks! https://github.com/llvm/llvm-project/pull/157577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/API] Mark SBValue with error as invalid (PR #158759)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I was under the impression that these two (`IsValid` and `GetError`) were intentionally decoupled, although I don't remember the reasoning. I vaguely remember this came up when @PortalPete was working on this. @adrian-prantl / @jimingham Do I misremember? https://github.

[Lldb-commits] [lldb] 082d1d9 - [lldb-dap] Bump form-data from 4.0.1 to 4.0.4

2025-09-18 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-09-18T14:40:18-07:00 New Revision: 082d1d911c1cd79849f74ac203fbcbfbb6737cef URL: https://github.com/llvm/llvm-project/commit/082d1d911c1cd79849f74ac203fbcbfbb6737cef DIFF: https://github.com/llvm/llvm-project/commit/082d1d911c1cd79849f74ac203fbcbfbb6737cef.d

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/159160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -100,22 +175,301 @@ template class Transport { virtual llvm::Expected RegisterMessageHandler(MainLoop &loop, MessageHandler &handler) = 0; - // FIXME: Refactor mcp::Server to not directly access log on the transport. - // protected: +protected: template inline a

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I did a first pass but I definitely need to do another pass with everything I learned during the first round, but don't want to hold back initial comment on that. https://github.com/llvm/llvm-project/pull/159160 ___

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { JDevlieghere wrote: This is the first file in the diff, so maybe its purpose will become clear later, but at this

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb][nfc] Remove no-op calls to Fix*Address (PR #159586)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/159586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Could you use `kNum_Cores` so we don't have to remember to update this when > new ones are added? > > Also the `eCore_wasm32` one has an empty body, so does that mean it does not > get checked? Good catch, that's an unintentional off-by-one. Using `kNum_Cores` addresses

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/159452 >From 57198d217f9e5df387c8e35452c82577756f2bb0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 17 Sep 2025 13:56:13 -0700 Subject: [PATCH] [lldb] Add a static_assert that g_core_definitions matc

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/159452 This PR uses the same trick as 7ced9fff95473 to ensure the `g_core_definitions` table is correctly indexed by the Core enum. It's easy to make a mistake. Case in point: this caught two entries that appeare

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This is what the compiler tells you when you make a mistake: ``` /Users/jonas/llvm/llvm-project/lldb/source/Utility/ArchSpec.cpp:263:34: note: expression evaluates to '24 == 25' 263 | g_core_definitions[I].core == I, | ~~~^~~~ /Use

[Lldb-commits] [lldb] [NFC][lldb-dap] Fix typo in invalidated event (PR #158338)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/158338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-mcp] Adding a tool to list debuggers again. (PR #158340)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Not directly related to this PR, but something I'm planning to address that will affect this. I've gotten some reports that nearly all models struggle with the debugger IDs being 1-based. Some of them are smart enough to try 1

[Lldb-commits] [lldb] [lldb/docs] Breakdown python reference into multiple files (PR #158331)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Any reason we can't use the existing [.htaccess](https://github.com/llvm/llvm-project/blob/main/lldb/docs/.htaccess) for that? https://github.com/llvm/llvm-project/pull/158331 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [LLDB][NativePDB] Add modifiers to modified type name (PR #159296)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/159296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Recognize MTE fault Mach exceptions (PR #159117)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/158161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: General feedback: Comment should end with periods. We have a little RISC-V board that runs Ubuntu [1]. It would be interesting to see if this improves the test results, but that doesn't block this PR. [1] https://github.com/llvm/llvm-project/issues/

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,188 @@ +//===-- TestRiscvInstEmulation.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add boolean literals to DIL. (PR #157992)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. This looks pretty straightforward. LGTM. https://github.com/llvm/llvm-project/pull/157992 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [NFC][lldb-dap] Fix typo in invalidated event (PR #158338)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/158338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb-dap] Fix typo in invalidated event (PR #158338)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/158338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Recognize MTE fault Mach exceptions (PR #159117)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > How will this be tested? We can run API tests on iOS, right? I get that only > you at Apple are likely to be able to do that with any convenience, but still. > > Also you'd probably save a bunch of time by doing one giant test that checks > all the little MTE additions in

[Lldb-commits] [lldb] [NFC][lldb-dap] Fix typo in invalidated event (PR #158338)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/158338 >From da4574994f7d98454b7c1f224a3f4ef1d7a19384 Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Fri, 12 Sep 2025 20:03:42 +0300 Subject: [PATCH] [NFC][lldb-dap] Fix typo in invalidated event --- lldb/

[Lldb-commits] [lldb] [lldb-dap] Add stdio redirection (PR #158609)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/158609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add stdio redirection (PR #158609)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/158609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make flag-only options work in the ParsedCommand mode of adding commands (PR #157756)

2025-09-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/157756 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Require DIA SDK for testing the PDB plugin-selection setting (PR #158284)

2025-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/158284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/docs] Breakdown python reference into multiple files (PR #158331)

2025-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. There's tons of opportunity for improvement but that shouldn't block this PR. https://github.com/llvm/llvm-project/pull/158331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Remove unused swig macro (NFC) (PR #157905)

2025-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/157905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add invalidated event (PR #157530)

2025-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/157530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-mcp] Auto connect to the first running lldb mcp instance. (PR #157503)

2025-09-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🛫 https://github.com/llvm/llvm-project/pull/157503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix use after free on ModuleList::RemoveSharedModuleIfOrphaned (PR #155331)

2025-09-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: We discussed this offline today. I should've been less terse in explaining my idea, which is to use weak pointers all the way down, lock it just before we're going to remove it to create a critical section, account for the increase in refcount, and then release the pointer.

[Lldb-commits] [lldb] [lldb][test] StepUntil disable test for unsupported linkers. (PR #157474)

2025-09-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/157474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add invalidated event (PR #157530)

2025-09-12 Thread Jonas Devlieghere via lldb-commits
@@ -1073,3 +1073,17 @@ TEST(ProtocolTypesTest, CompletionsResponseBody) { ASSERT_THAT_EXPECTED(expected, llvm::Succeeded()); EXPECT_EQ(pp(*expected), pp(response)); } + +TEST(ProtocolTypesTest, InvalidatedEventBody) { + InvalidatedEventBody body; + body.areas = {Invalidat

[Lldb-commits] [lldb] [lldb-dap] Add invalidated event (PR #157530)

2025-09-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/157530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unwind through ARM Cortex-M exceptions automatically (PR #153922)

2025-09-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > The one significant choice that we haven't agreed on at this point is whether > `Architecture::GetArchitectureUnwindPlan` should return an empty UnwindPlanSP > to indicate no override, or if it should return the `std::shared_ptr UnwindPlan>` identical to its input if it in

[Lldb-commits] [lldb] [LLDB][SBProgress] Quick fix to the progress formatting (PR #157561)

2025-09-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/157561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Default-initialize all fields of lldb_dap::protocol::Symbol. (PR #157150)

2025-09-07 Thread Jonas Devlieghere via lldb-commits
@@ -50,29 +50,29 @@ llvm::json::Value toJSON(const SourceLLDBData &); struct Symbol { /// The symbol id, usually the original symbol table index. - uint32_t id; + uint32_t id = 0; /// True if this symbol is debug information in a symbol. - bool isDebug; + bool isDeb

[Lldb-commits] [lldb] [lldb] Add more mnemonics (PR #156987)

2025-09-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Default-initialize all fields of lldb_dap::protocol::Symbol. (PR #157150)

2025-09-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/157150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Default-initialize all fields of lldb_dap::protocol::Symbol. (PR #157150)

2025-09-05 Thread Jonas Devlieghere via lldb-commits
@@ -50,29 +50,29 @@ llvm::json::Value toJSON(const SourceLLDBData &); struct Symbol { /// The symbol id, usually the original symbol table index. - uint32_t id; + uint32_t id = 0; /// True if this symbol is debug information in a symbol. - bool isDebug; + bool isDeb

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/156648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix Python 3.9+ specific typing annotations (PR #156868)

2025-09-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more mnemonics (PR #156987)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156987 Add a few more command option mnemonics. >From b86d0eada5f7b752851779fdc9aed08988e92b39 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 4 Sep 2025 16:51:55 -0700 Subject: [PATCH] [lldb] Add mor

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From 85e35e5ace2e5f8f851117268ae49c38f7f55477 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 4 Sep 2025 11:19:49 -0700 Subject: [PATCH] [lldb] Add more command option mnemonics #155705 --- l

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156774 The LLVM Style Guide says the following about error and warning messages [1]: > [T]o match error message styles commonly produced by other tools, > start the first sentence with a lowercase letter, and fini

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can you talk a bit about what's motivating this change? I'm a little worried about the proliferation of new options and I'm especially wary about the ones that need to be specified on the command line instead of over the protocol. Every new option extends the matrix of thin

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Friendly ping https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Great! May be we should do this for: > > * `Status::Status(std::string err_str)` > * `static Status FromErrorString(const char *str)` > * `static Status FromErrorStringWithFormat(const char *format, ...)` > * `template static Status FromErrorStringWithFormatv(const > char

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
@@ -418,7 +418,7 @@ other command as far as there is only one alias command match."); if ((pos != std::string::npos) && (pos > 0)) raw_command_string = raw_command_string.substr(pos); } else { - result.AppendError("Error parsing command string. No alias

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/156774 >From 7e2901ba9171555b07a44a008e84f6811a95a64d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 3 Sep 2025 16:45:13 -0700 Subject: [PATCH] [lldb] Correct style of error messages The LLVM Style G

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Mark scripted frames as synthetic instead of artificial (PR #153117)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/153117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From 6427b12a42c2064d57bc211443a5aa1e59fa81d9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 3 Sep 2025 08:25:14 -0700 Subject: [PATCH] Add a bunch of mnemonics to the command options now that

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From f56a1a836e2fbe865d8e143d021389c99ec341e6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 14:25:29 -0700 Subject: [PATCH] [lldb] Add more command option mnemonics Add a bunch o

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-09-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor variable annotation logic in Disassembler::PrintInstructions (PR #156118)

2025-08-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156118 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some spelling and grammatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some spelling and grammatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/156121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some spelling and gramatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156121 Fixes whitespace, spelling and grammatical issues in the command options. I also formatted the affected options with clang-format and reflowed the description where necessary. >From 49a76d3d7551549d243f54

[Lldb-commits] [lldb] [lldb] Fix some spelling and grammatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/156121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor variable annotation logic in Disassembler::PrintInstructions (PR #156118)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/156118 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in the description of the -X alias (PR #156119)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in the description of the -X alias (PR #156119)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/156119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in the description of the -X alias (PR #156119)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156119 None >From c872dddcbd2f8e1d65357a943a65d9e4cfc0a519 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 29 Aug 2025 15:42:29 -0700 Subject: [PATCH] [lldb] Fix typo in the description of the -X alia

[Lldb-commits] [lldb] [lldb] Stop the protocol servers when terminating the plugin (PR #156101)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix typescript issue in updated typescript code. (PR #156117)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/156117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format tools/driver/Options.td (NFC) (PR #156111)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format tools/driver/Options.td (NFC) (PR #156111)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/156111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format tools/driver/Options.td (NFC) (PR #156111)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156111 Use clang-format to format the driver options tablegen file. >From d2335a68e58af0fb46b8dada94f5e3b163fc326d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 29 Aug 2025 14:46:13 -0700 Subject: [

  1   2   3   4   5   6   7   8   9   10   >