[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/152054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: General feedback: this patch is using `auto` in a bunch of places that don't align with the [LLVM Coding Standards](https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable). https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module *module) const { } namespace { +/// A wrapper around ModuleList for shared modules. Provides fast lookups for +/// file-based ModuleSpec queries. +class SharedModuleList { +public: + /// Finds all the m

[Lldb-commits] [lldb] [lldb] Workaround omission of PyBUF_READ in the stable API (PR #152214)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152214 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Workaround omission of PyBUF_READ in the stable API (PR #152214)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152214 PyMemoryView_FromMemory is part of stable ABI but the flag constants such as PyBUF_READ are not. This was fixed in Python 3.11 [1] but work around the issue with older versions. [1] https://github.com/pyt

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152212)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Part of https://github.com/llvm/llvm-project/issues/151617 https://github.com/llvm/llvm-project/pull/152212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support the Python stable C API in PythonString::AsUTF8 (PR #152212)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152212 This conditionally reimplements `PythonString::AsUTF8` using `PyUnicode_AsUTF8String` instead of `PyUnicode_AsUTF8AndSize`. The latter is slightly more efficient because it caches the result, which also me

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
@@ -1,4 +1,4 @@ -//===-- MCPError.h ===// +//===--===// JDevlieghere wrote: Yup, as of https://discourse.llvm.org/t/is-c-in-header-files-

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/152188 >From 6519cdaa2339e78ed7f7d5ef58b3978746646b75 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 5 Aug 2025 11:26:27 -0700 Subject: [PATCH 1/2] [lldb] Move the generic MCP code into Protocol/MCP (

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152188 This moves all the generic MCP code into the new ProtocolMCP library so it can be shared between the MCP implementation in LLDB (built on the private API) and lldb-mcp (built on the public API). This PR d

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @walter-erquinigo > > > Please write a section in the lldb-dap documentation on how to integrate > > with other debugger extensions via these commands? > > That was a great suggestion. Added text to near the end of the `README.md`. > Please feel free to LMK if you have d

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I'm also curious how these will be used. Are you working on an extension that will take advantage of this, or are the commands added in this PR purely speculative? It would be nice to at least include that because otherwise it'll be hard to figure out in the future if we ca

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/152002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Asking just for this first time: In this code base (vscode-lldb), do you > recommend me to go ahead and merge with your approval, or should I wait for > @JDevlieghere to take a look, too? Thanks for asking! The [Code Review Policy](https://llvm.org/docs/CodeReview.html#l

[Lldb-commits] [lldb] dd0bb2c - [lldb-dap] Bump the version to 0.2.16

2025-08-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T09:15:43-07:00 New Revision: dd0bb2c3a8675ff1e2b9de565a301c0a09d3063b URL: https://github.com/llvm/llvm-project/commit/dd0bb2c3a8675ff1e2b9de565a301c0a09d3063b DIFF: https://github.com/llvm/llvm-project/commit/dd0bb2c3a8675ff1e2b9de565a301c0a09d3063b.d

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/152059 >From 39e2e11148eecafc539d7425c804981519a9cefd Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 4 Aug 2025 16:54:28 -0700 Subject: [PATCH 1/2] [lldb] Move MCP protocol into its own library (NFC)

[Lldb-commits] [lldb] [lldb] Reimplement PythonObject::Dump using the limited API (PR #152055)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a CMake option to build agains the Python limited API (PR #152034)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a CMake option to build agains the Python limited API (PR #152034)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152034 This adds a CMake option (which defaults to OFF) to force building against the Python limited API. This makes iterating on #151617 easier and eventually will prevent us from regressing this configuration.

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Part of https://github.com/llvm/llvm-project/issues/151617 https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/152031 >From 54de8da70ff38d351057835b8d9216d58ed659e8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 4 Aug 2025 13:49:09 -0700 Subject: [PATCH] [lldb] Use Python Bytes instead of Buffer for Binary I/O

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152031 Binary I/O (also called buffered I/O) expects bytes-like objects and produces bytes objects [1]. Switch from using a Python buffer to using Python bytes to read the data. This eliminates calls to functions

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Part of https://github.com/llvm/llvm-project/issues/151617 https://github.com/llvm/llvm-project/pull/152006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152006 Eliminate calls to PyGILState_Check, which is not part of the Python Limited C API. In the Locker, we can use PyGILState_Ensure directly. We could do something similar to replace the assert, but I don't th

[Lldb-commits] [lldb] [LLDB] Add setting for native PDB reader (PR #151490)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8f77fa7 - [lldb] Simplify Python Locker log messages (NFC)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-04T09:37:37-07:00 New Revision: 8f77fa7026de9f544778063fd9fe900d0804b863 URL: https://github.com/llvm/llvm-project/commit/8f77fa7026de9f544778063fd9fe900d0804b863 DIFF: https://github.com/llvm/llvm-project/commit/8f77fa7026de9f544778063fd9fe900d0804b863.d

[Lldb-commits] [lldb] 0f08dc8 - [lldb] Use fully qualified name instead of namespace (NFC)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-04T09:22:25-07:00 New Revision: 0f08dc84405796c25c070ef57258309f66017984 URL: https://github.com/llvm/llvm-project/commit/0f08dc84405796c25c070ef57258309f66017984 DIFF: https://github.com/llvm/llvm-project/commit/0f08dc84405796c25c070ef57258309f66017984.d

[Lldb-commits] [lldb] [lldb][nfc] Use delegating ctor for ExecutionContext (PR #151987)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate InitializePythonRAII::InitializeThreadsPrivate (NFC) (PR #151780)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_String using the Python stable C API (PR #151761)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
@@ -1469,11 +1466,33 @@ python::runStringMultiLine(const llvm::Twine &string, const PythonDictionary &locals) { if (!globals.IsValid() || !locals.IsValid()) return nullDeref(); - PyObject *result = PyRun_String(NullTerminated(string), Py_file_i

[Lldb-commits] [lldb] [vscode-lldb] Fix format (PR #151829)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid a crash after selecting an unknown platform (PR #151803)

2025-08-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_SimpleString using the Python stable C API (PR #151777)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate InitializePythonRAII::InitializeThreadsPrivate (NFC) (PR #151780)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This is in preparation for eliminating the call to `PyGILState_Check` and calling `PyGILState_Ensure` directly as part of https://github.com/llvm/llvm-project/issues/151617. https://github.com/llvm/llvm-project/pull/151780 ___ ll

[Lldb-commits] [lldb] [lldb] Eliminate InitializePythonRAII::InitializeThreadsPrivate (NFC) (PR #151780)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/151780 The behavior of thread initialization changed in Python 3.7. The minimum supported Python version is now 3.8. That means that `PyEval_ThreadsInitialized` always returns true and `PyEval_InitThreads` is ne

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_String using the Python stable C API (PR #151761)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151761 >From cb8d0d2f28a736c6c4808e73f1f60103ee535478 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 1 Aug 2025 12:48:47 -0700 Subject: [PATCH] [lldb] Reimplment PyRun_String using the Python stable C

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_String using the Python stable C API (PR #151761)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151761 >From 80affa33bba14616f21da6bdad6fc6fb8b7048ed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 1 Aug 2025 12:48:47 -0700 Subject: [PATCH] [lldb] Reimplment PyRun_String using the Python stable C

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_String using the Python stable C API (PR #151761)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/151761 Reimplement `PyRun_String` using `Py_CompileString` and` PyEval_EvalCode`, which are part of the stable C API. Part of #151617 >From 8fe60ddc943421af3039d136cd2e3ac38c8347f4 Mon Sep 17 00:00:00 2001 From:

[Lldb-commits] [lldb] [LLDB] Add setting for native PDB reader (PR #151490)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add setting for native PDB reader (PR #151490)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: It's also kind of weird that we have `SymbolFilePDB` and `SymbolFileNativePDB` with one initializing the other. It seems like we should have a pure virtual SymbolFilePDB and then a `SymbolFileNativePDB` and a `SymbolFileDIAPDB`. Anyway, I'd still like to get rid of the DIA

[Lldb-commits] [lldb] [LLDB] Add setting for native PDB reader (PR #151490)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Is this the current behavior? In my understanding, both plugins are mostly > independent. The DIA PDB parser only brings in the native PDB parser to > initialize it. It doesn't instantiate it to resolve a type. It's possible I'm misremembering this. In the PR that removes

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
@@ -62,8 +63,12 @@ export class DebugSessionTracker createDebugAdapterTracker( session: vscode.DebugSession, ): vscode.ProviderResult { +this.logger.info(`Starting debug session "${session.name}"`); +let stopping = false; return { + onError: (error) =>

[Lldb-commits] [lldb] [lldb] Replace Python APIs with their stable equivalent (PR #151618)

2025-08-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a use-after-free in SymbolFileCTF (PR #151586)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a use-after-free in SymbolFileCTF (PR #151586)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I think I'm missing something. Instead of removing it at the end of > `ResolveTypeUID`, you remove it right _after_ the call to `ResolveTypeUID`. > What's the difference? I should've mentioned that this function is (indirectly) recursive, because that's totally fine (e.g

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151403 >From 279bb81cafcf1d5fcbb3f605293a52c0cbe25f9b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 14:57:20 -0700 Subject: [PATCH 1/2] [lldb] Support Darwin cross compilation for remote

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151387 >From 5174e09049e6e295862decfad8081105bca154aa Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 13:19:50 -0700 Subject: [PATCH] [lldb] Don't use NamedTemporaryFile to test compiler su

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -37,6 +37,9 @@ def getExtraMakeArgs(self): def getArchCFlags(self, architecture): """Returns the ARCH_CFLAGS for the make system.""" +triple = self.getTriple(architecture) +if triple: +return ["ARCH_CFLAGS=-target {}".format(triple)]

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1593,6 +1621,14 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec &arch, features_str += "+a,+m,"; } + const char *additional_features = + arch.GetAdditionalDisassemblyFeatureStr().data(); + // Prepend the additional_features if it's not already in the f

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1284,6 +1285,54 @@ ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data, return error; } +void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length, + ArchSpec &arch_spec) { + lldb::off

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -548,6 +557,9 @@ class ArchSpec { // these are application specific extensions like micromips, mips16 etc. uint32_t m_flags = 0; + // Holds the additional disassembly feature string. JDevlieghere wrote: Maybe explain what this is and what it's used fo

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -537,6 +537,15 @@ class ArchSpec { void SetFlags(const std::string &elf_abi); + // Sets the target specific disassembly feature string + // for ELF disassembly. + void SetAdditionalDisassemblyFeatureStr(llvm::StringRef additional_features); + + // Get the current tar

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -548,6 +557,9 @@ class ArchSpec { // these are application specific extensions like micromips, mips16 etc. uint32_t m_flags = 0; + // Holds the additional disassembly feature string. + std::string m_additional_disassembly_feature_str; JDevlieghere wro

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -537,6 +537,15 @@ class ArchSpec { void SetFlags(const std::string &elf_abi); + // Sets the target specific disassembly feature string + // for ELF disassembly. + void SetAdditionalDisassemblyFeatureStr(llvm::StringRef additional_features); JDevlieghe

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1284,6 +1285,54 @@ ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data, return error; } +void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length, + ArchSpec &arch_spec) { + lldb::off

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -537,6 +537,15 @@ class ArchSpec { void SetFlags(const std::string &elf_abi); + // Sets the target specific disassembly feature string + // for ELF disassembly. JDevlieghere wrote: At the ArchSpec level, the fact that this is coming from ELF is an im

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -1446,6 +1446,34 @@ bool DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated( return InstrDesc.isAuthenticated() || IsBrkC47x; } +void DisassemblerLLVMC::UpdateFeatureString(llvm::StringRef additional_features, +std::string &

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,11 @@ +# REQUIRES: target=riscv32-{{.*}} + +# RUN: %lldb -b -o "disassemble -b -n main" %p/Inputs/riscv_xqci.out | FileCheck %s + +# CHECK: 051f 0058 qc.e.li a0, 0x58 +# CHECK: 1516 qc.extu a0, a0, 0x6, 0x0 + +# RUN: %lldb -b -o "disassemble -b -n ma

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/147990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151387 >From a0fc19ed15fac0694309d0b1c8246c3d9cc3aeba Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 13:19:50 -0700 Subject: [PATCH] [lldb] Don't use NamedTemporaryFile to test compiler su

[Lldb-commits] [lldb] [lldb] Don't use NamedTemporaryFile to test compiler support (PR #151387)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151387 >From 97435049d503045f22e169825244c944f31968c7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 13:19:50 -0700 Subject: [PATCH] [lldb] Don't use NamedTemporaryFile to test compiler su

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -355,6 +355,16 @@ ifeq "$(OS)" "Windows_NT" endif endif +#-- +# Darwin cross compilation +#-- +ifeq "$(HOST_OS)" "Darwin" +

[Lldb-commits] [clang] [lldb] [llvm] NFC: Clean up construction of IntrusiveRefCntPtr from raw pointers for llvm::vfs::FileSystem. (PR #151407)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Darwin cross compilation for remote Linux test suite runs (PR #151403)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151403 >From 436d8863eff7403ff2a367719dcf8488cd4c6457 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 14:57:20 -0700 Subject: [PATCH] [lldb] Support Darwin cross compilation for remote Linu

[Lldb-commits] [lldb] a7ac431 - Re-land "[lldb] Pick the builder for the target platform (#151262)"

2025-07-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-30T12:48:56-07:00 New Revision: a7ac43125eabb5845a2855bbf37fd4485831e860 URL: https://github.com/llvm/llvm-project/commit/a7ac43125eabb5845a2855bbf37fd4485831e860 DIFF: https://github.com/llvm/llvm-project/commit/a7ac43125eabb5845a2855bbf37fd4485831e860.d

[Lldb-commits] [lldb] Revert "[lldb] Pick the builder for the target platform" (PR #151367)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151367 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Pick the builder for the target platform" (PR #151367)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/151367 Reverts llvm/llvm-project#151262 while I investigate why this breaks GreenDragon. >From 131f924162e1c94a57e3aa061103b2d19d94c0f2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 30 Jul 2025 10

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Fix name access for classes in `CVTagRecord::name` (PR #151190)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Fix name access for classes in `CVTagRecord::name` (PR #151190)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove %T from lit tests (PR #151343)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Pick the builder for the target platform (PR #151262)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/151262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151010 >From c9cea26faaede58bcc8a68eb91425fda21455983 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 28 Jul 2025 10:38:02 -0700 Subject: [PATCH 1/2] [lldb] Support DW_OP_WASM_location in DWARFExpressi

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/151010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support DW_OP_WASM_location in DWARFExpression (PR #151010)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,91 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
@@ -224,67 +311,68 @@ def test_load_module_with_stripped_symbols_from_remote(self): @skipIfAsan @skipIfXmlSupportMissing -def test_load_module_from_file(self): -"""Test connecting to a WebAssembly engine via GDB-remote and loading a Wasm module from a fil

[Lldb-commits] [lldb] [lldb] Implement RegisterContextWasm (PR #151056)

2025-07-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/151056 >From c9cea26faaede58bcc8a68eb91425fda21455983 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 28 Jul 2025 10:38:02 -0700 Subject: [PATCH 1/3] [lldb] Support DW_OP_WASM_location in DWARFExpressi

  1   2   3   4   5   6   7   8   9   10   >