[Lldb-commits] [lldb] [lldb-dap] Allow returning multiple breakpoints in "stopped" event (PR #149133)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
@@ -33,7 +33,7 @@ int main(int argc, char const *argv[]) { if (foo == nullptr) { fprintf(stderr, "%s\n", dlerror()); exit(2); - } + } // end of foo check JDevlieghere wrote: Ah, I missed that you were using that to set the breakpoint. In that case,

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio Code](https://code.visualstudio.com/doc } ``` -### Troubleshooting +## Tools + +Tools are a primitive in the Model Context Protocol that enable servers to +expose functionality to clients. + +LLDB's MCP integration e

[Lldb-commits] [lldb] [lldb] Always compute the execution & symbol context (PR #148994)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148994 >From ee116a937d165f4862aae34206d112682b8ce0ee Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 15 Jul 2025 16:54:05 -0700 Subject: [PATCH] [lldb] Always compute the execution & symbol context A

[Lldb-commits] [lldb] [lldb] [cosmetic] Update help message of `(lldb) b` (PR #149114)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: [begin bikeshedding] How about something like this: >Set a breakpoint using one of several shorthand formats, or list the existing >breakpoints if no arguments are provided. Expects 'raw' input (see 'help >raw-input'.) My reasoning is that it describes the more common use

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Also, the server made it into 21.x but the docs obviously didn't and there's > no release note for it. Is it complete "enough" to cherry-pick this and add a > release note? I will add a release note and create a back port request. Do you think it's worth cherrypicking th

[Lldb-commits] [lldb] [LLDB] Compile API tests with exceptions enabled on Windows (PR #148691)

2025-07-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/148691 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/148708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document MCP tools & resources (PR #148708)

2025-07-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/148708 Add documentation for the tools and resources exposed by LLDB's MCP server. >From cde479affc82c6964e6471315179aaab58b3fd6a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 14 Jul 2025 12:18:02 -

[Lldb-commits] [lldb] [LLDB] Compile API tests with exceptions enabled on Windows (PR #148691)

2025-07-14 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/148691 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Compile API tests with exceptions enabled on Windows (PR #148691)

2025-07-14 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > On other platforms, exceptions are enabled as well. I don't believe that's accurate. By default, LLVM builds without exceptions. There's `LLVM_ENABLE_EH` to override that behavior [1]: > LLVM_ENABLE_EH:BOOL > Build LLVM with exception-handling support. This is necessary i

[Lldb-commits] [lldb] [lldb] Add DWARFExpressionEntry and GetExpressionEntryAtAddress() to … (PR #144238)

2025-07-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/144238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] deactivate some tests on older SDKs (PR #147768)

2025-07-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. > The conclusion was we will upgrade the AS bots on Green Dragon and only then > land this PR. We do want coverage for these since they usually expose Clang > modules related issues. Alright, that sounds good and alleviates my concern

[Lldb-commits] [lldb] [lldb][Format] Fall back to old function.name-with-args if language frame format is emtpy (PR #148235)

2025-07-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/148235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/148075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add Disassembler log channel (PR #148290)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/148290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I think both are true. When using an IDE with LSP support, the doxygen comments can be quite helpful and they're easier to keep up to date compared to a separate design document. I've reduced the verbosity further and now almost all comments are a single line. https://gith

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147621 >From 337a7e43efcab08061ca6a5a0bd05547d783c63c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 11 Jul 2025 13:33:53 -0700 Subject: [PATCH] [lldb] Document the SBDebugger public interface Despit

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I didn't because, unlike for the debugger, you can do `target select`. https://github.com/llvm/llvm-project/pull/148075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148075 >From 74cc4598eccdb43b3a36e3276d16de84a901f095 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Jul 2025 15:51:44 -0700 Subject: [PATCH 1/3] [lldb] Expose debuggers and target as resources thr

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/148075 >From 74cc4598eccdb43b3a36e3276d16de84a901f095 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Jul 2025 15:51:44 -0700 Subject: [PATCH 1/2] [lldb] Expose debuggers and target as resources thr

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,166 @@ +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,166 @@ +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===

[Lldb-commits] [lldb] [lldb] Expose debuggers and target as resources through MCP (PR #148075)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -76,17 +76,75 @@ struct ToolCapability { llvm::json::Value toJSON(const ToolCapability &); bool fromJSON(const llvm::json::Value &, ToolCapability &, llvm::json::Path); +struct ResourceCapability { + /// Whether this server supports notifications for changes to the resourc

[Lldb-commits] [lldb] [lldb] Add completions for plugin list/enable/disable (PR #147775)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/147775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add completions for plugin list/enable/disable (PR #147775)

2025-07-11 Thread Jonas Devlieghere via lldb-commits
@@ -2473,3 +2474,35 @@ bool PluginManager::SetUnwindAssemblyPluginEnabled(llvm::StringRef name, bool enable) { return GetUnwindAssemblyInstances().SetInstanceEnabled(name, enable); } + +void PluginManager::AutoCompletePlugin

[Lldb-commits] [lldb] [lldb] deactivate some tests on older SDKs (PR #147768)

2025-07-10 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > the green dragon AArch64 bots do run macOS 15. I don't believe that's accurate. The incremental AS bot is running macOS 14.1 and building against a 14.2 SDK. From the console logs: ``` + sw_vers ProductName:macOS ProductVersion: 14.1 BuildVersion:

[Lldb-commits] [lldb] [lldb-dap] Migrate variables request protocol types. (PR #147611)

2025-07-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/147611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate variables request protocol types. (PR #147611)

2025-07-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147621 >From af54eaf253b1840abb721c3e584d9936fad12c8a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 16:37:20 -0700 Subject: [PATCH 1/5] [lldb] Document the SBDebugger public interface Des

[Lldb-commits] [lldb] [lldb-dap] Migrate variables request protocol types. (PR #147611)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/147611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147621 >From af54eaf253b1840abb721c3e584d9936fad12c8a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 16:37:20 -0700 Subject: [PATCH 1/3] [lldb] Document the SBDebugger public interface Des

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147621 >From af54eaf253b1840abb721c3e584d9936fad12c8a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 16:37:20 -0700 Subject: [PATCH 1/2] [lldb] Document the SBDebugger public interface Des

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
@@ -153,70 +249,221 @@ class LLDB_API SBDebugger { /// lldb::SBStructuredData settings = debugger.GetSetting("target.arg0"); /// lldb::SBStructuredData settings = debugger.GetSetting("target"); /// - /// \param[out] setting + /// \param[in] setting /// Property set

[Lldb-commits] [lldb] [lldb] Document the SBDebugger public interface (PR #147621)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger { bool &is_debugger_specific); #endif + /// Get structured progress data from an event. + /// + /// \param [in] event + /// The event to extract the progress information from. + /

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147603 >From 7aa2ae6b97dd933afdcf59984d20a659ad59ab79 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 14:55:59 -0700 Subject: [PATCH] [lldb] Support specifying a language for breakpoint con

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
@@ -42,17 +52,21 @@ def setUp(self): "main.c", "// Find the line number of c's parent call here." ) -def breakpoint_conditions(self, inline=False): +def breakpoint_conditions(self, inline=False, language=None): """Exercise breakpoint condit

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147603 >From 9e4ce45f9d5957b80c0e9b00c03bd29308be66b1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 14:55:59 -0700 Subject: [PATCH] [lldb] Support specifying a language for breakpoint con

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/147603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,53 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
@@ -173,7 +173,7 @@ const char *SBBreakpointLocation::GetCondition() { std::lock_guard guard( loc_sp->GetTarget().GetAPIMutex()); - return ConstString(loc_sp->GetConditionText()).GetCString(); + return ConstString(loc_sp->GetCondition().GetText()).GetCString(); -

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,53 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Enable SWIG Doxygen Translation (PR #147617)

2025-07-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/147617 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change breakpoint interfaces for error handling (PR #146972)

2025-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146972 >From b593c9b4f8791f2b5562ca301f77af72619b9c30 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 15:32:13 -0700 Subject: [PATCH 1/2] [lldb] Change breakpoint interfaces for error handli

[Lldb-commits] [lldb] [lldb] Enable SWIG Doxygen Translation (PR #147617)

2025-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/147617 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Enable SWIG Doxygen Translation (PR #147617)

2025-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/147617 Enable SWIG support for translating Doxygen comments found in interface and header files into a target language's normal documentation language. This feature was introduced in SWIG 4.0 and currently only s

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/147603 >From 67ce4cd81355863ec2b3af43eb5a0e47f420acd2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Jul 2025 14:55:59 -0700 Subject: [PATCH] [lldb] Support specifying a language for breakpoint con

[Lldb-commits] [lldb] [lldb] Support specifying a language for breakpoint conditions (PR #147603)

2025-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/147603 LLDB breakpoint conditions take an expression that's evaluated using the language of the code where the breakpoint is located. Users have asked to have an option to tell it to evaluate the expression in a

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/146966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > How should a proper debugger shutdown sequence look like? > > 1. Release all `SBModule` pointers. > 2. Call `SBDebugger::MemoryPressureDetected`. > 3. Call `SBDebugger::Destroy`. Ideally, `SBDebugger::Destroy` would clean up all the modules in the module cache. You say we

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > However, when lldb is used as a library, we need a way to manage opened > modules to avoid problems with file locks (on some systems) for modules that > we no longer need. Can you give a concrete example? This seems like its own issue that should be solved rather than wo

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -46,6 +48,107 @@ static bool ShouldDisplayAssemblySource( return false; } +static uint64_t GetDebugInfoSizeInSection(lldb::SBSection section) { + uint64_t debug_info_size = 0; + const llvm::StringRef section_name(section.GetName()); + if (section_name.starts_with(".deb

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -7,64 +7,43 @@ //===--===// #include "DAP.h" -#include "EventHelper.h" -#include "JSONUtils.h" +#include "ProtocolUtils.h" #include "RequestHandler.h" +using namespace lldb_dap::protocol; namespace lld

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Can you separate out the functional changes and the protocol-type-related non-functional changes? https://github.com/llvm/llvm-project/pull/146966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -1347,45 +1347,7 @@ void DAP::EventThread() { SendStdOutStdErr(*this, process); } } else if (lldb::SBTarget::EventIsTargetEvent(event)) { -if (event_mask & lldb::SBTarget::eBroadcastBitModulesLoaded || -event_mask & lldb::SBTarget:

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -46,6 +48,107 @@ static bool ShouldDisplayAssemblySource( return false; } +static uint64_t GetDebugInfoSizeInSection(lldb::SBSection section) { + uint64_t debug_info_size = 0; + const llvm::StringRef section_name(section.GetName()); + if (section_name.starts_with(".deb

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &, DisassembledInstruction &, llvm::json::Path); llvm::json::Value toJSON(const DisassembledInstruction &); +struct Module { + /// Unique identifier for the module. + std::string id; + + /// A name of

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change breakpoint interfaces for error handling (PR #146972)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/146972 This RP changes some Breakpoint-related interfaces to return errors. On its own these improvements are small, but they encourage better error handling going forward. There are a bunch of other candidates,

[Lldb-commits] [lldb] 1725cc0 - [lldb] Remove unused `hardware` argument (NFC)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-03T14:37:05-07:00 New Revision: 1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c URL: https://github.com/llvm/llvm-project/commit/1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c DIFF: https://github.com/llvm/llvm-project/commit/1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c.d

[Lldb-commits] [lldb] 17cb0a7 - [lldb][docs] Fix another broken markdown link

2025-07-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-03T14:19:09-07:00 New Revision: 17cb0a73a0542da3477ac94c3fddfa05c20888f8 URL: https://github.com/llvm/llvm-project/commit/17cb0a73a0542da3477ac94c3fddfa05c20888f8 DIFF: https://github.com/llvm/llvm-project/commit/17cb0a73a0542da3477ac94c3fddfa05c20888f8.d

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase { static llvm::VersionTuple GetOSVersion(); static std::optional GetOSBuildString(); + static llvm::Expected GetSDKRoot(SDKOptions options); JDevlieghere wrote: Why not a `FileSpec`? https://gi

[Lldb-commits] [lldb] Use the root directory as the SDK root on POSIX platforms (PR #146963)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract DW_OP_deref evaluation code (NFC) (PR #146801)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving 'variables' hover requests. (PR #146773)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I don't know how you are doing this, but if you are treating "hover over" > requests as expressions and presenting the result of some real expression > evaluation, you have to be quite careful about what you evaluate. The corresponding DAP request is called "expression" w

[Lldb-commits] [lldb] [lldb] Extract DW_OP_deref evaluation code (NFC) (PR #146801)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146801 >From 1e71640c0bb0e3a680adf12679df6cbeda6c3aed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 2 Jul 2025 15:31:54 -0700 Subject: [PATCH 1/2] [lldb] Extract DW_OP_deref evaluation code (NFC) Th

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 6b5d9075cf7b1e6aec0b4969695f88613e715783 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH] [lldb] Add SB API to make a breakpoint a hardware breakp

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix incorrect logging message (PR #146903)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/146903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146578 >From a0ebe1e710c56ddc8108758ee461c1a934021337 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 10:38:22 -0700 Subject: [PATCH 1/3] [lldb] Take a sledgehammer approach to resizing the

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Sorry, I was out yesterday. No worries and I'm sorry for rushing you. > I think this is an okay, though not really satisfying solution (it could be > you resized the window to see more of your history). To see if we can handle > this uniformly, I guess we'd need to start

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/5] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] ab0fa6c - [lldb] Fix else-after-return in Breakpoint (NFC)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-02T12:07:20-07:00 New Revision: ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75 URL: https://github.com/llvm/llvm-project/commit/ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75 DIFF: https://github.com/llvm/llvm-project/commit/ab0fa6c5dc725ef6f839ac8cea9b3a41aa3a5b75.d

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Closing in favor of https://github.com/llvm/llvm-project/pull/146578 https://github.com/llvm/llvm-project/pull/146435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @labath let me know what you think of this approach. I'd like to take this on the Swift 6.2 release branch as it addresses several issues folks have reported. https://github.com/llvm/llvm-project/pull/146578 ___ lldb-commits mailin

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 👋 https://github.com/llvm/llvm-project/pull/146480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/4] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/3] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] [lldb][mcp] Fix unix domain socket protocol server addresses (PR #146603)

2025-07-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/146603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/2] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere converted_to_draft https://github.com/llvm/llvm-project/pull/146602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the hardware breakpoint decorator (PR #146609)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
@@ -9,6 +9,7 @@ #ifndef LLDB_HOST_HOSTTHREAD_H #define LLDB_HOST_HOSTTHREAD_H +#include "lldb/Host/HostNativeThreadBase.h" #include "lldb/Host/HostNativeThreadForward.h" JDevlieghere wrote: Guess this one can go now? Or we implement `HasThread` out-of-line.

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
@@ -3144,16 +3144,17 @@ void Process::CompleteAttach() { } } - if (!m_os_up) { + if (!m_os_up) LoadOperatingSystemPlugin(false); -if (m_os_up) { - // Somebody might have gotten threads before now, but we need to force the - // update after we've loa

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146578 >From a689f4c68949b7be48562295e8f2105e880a5b30 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 10:38:22 -0700 Subject: [PATCH] [lldb] Take a sledgehammer approach to resizing the sta

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146578 >From a57532d99ec1b46e76a388e1b2baa1f737838f62 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 10:38:22 -0700 Subject: [PATCH] [lldb] Take a sledgehammer approach to resizing the sta

[Lldb-commits] [lldb] 3edae0d - [lldb] Use EL_REFRESH to refresh Editline

2025-07-01 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-01T11:08:11-07:00 New Revision: 3edae0d5e5b69a4613a0dfce32ef56eb3ffec2fb URL: https://github.com/llvm/llvm-project/commit/3edae0d5e5b69a4613a0dfce32ef56eb3ffec2fb DIFF: https://github.com/llvm/llvm-project/commit/3edae0d5e5b69a4613a0dfce32ef56eb3ffec2fb.d

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks for the report. I've reached the point where I'm skeptical that I'm able to get this right for every combination of OS/WM/Terminal so I think https://github.com/llvm/llvm-project/pull/146578 is the safest path forward. https://github.com/llvm/llvm-project/pull/146435

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/146578 Terminal resizing continues to be a source of statusline bugs, so much so that some users have started disabling it altogether. Different operating systems and terminal emulators exhibit subtly different b

[Lldb-commits] [lldb] [lldb][Mach-O] Fix several bugs in x86_64 Mach-O corefile (PR #146460)

2025-06-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/146460 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mach-O] Fix several bugs in x86_64 Mach-O corefile (PR #146460)

2025-06-30 Thread Jonas Devlieghere via lldb-commits
@@ -184,46 +184,32 @@ class RegisterContextDarwin_x86_64_Mach : public RegisterContextDarwin_x86_64 { SetError(GPRRegSet, Read, -1); SetError(FPURegSet, Read, -1); SetError(EXCRegSet, Read, -1); -bool done = false; -while (!done) { +while (offset < da

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-06-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/146435 Avoid some of the work to disable/enable the statusline when the terminal dimensions change. >From 73bffa08fe1b2946a81056636b505f93d0b787a8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 30 J

[Lldb-commits] [lldb] eb904e8 - [lldb] Fix link syntax in docs/use/mcp.md

2025-06-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-30T13:50:32-07:00 New Revision: eb904e857af19abc2ea32ea3be455d96af6902f1 URL: https://github.com/llvm/llvm-project/commit/eb904e857af19abc2ea32ea3be455d96af6902f1 DIFF: https://github.com/llvm/llvm-project/commit/eb904e857af19abc2ea32ea3be455d96af6902f1.d

[Lldb-commits] [lldb] [lldb] Correctly restore the cursor column after resizing the statusline (PR #146132)

2025-06-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146132 >From e601025c14fb609635dc6a9adea5b1ae8b8e4540 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 27 Jun 2025 11:08:08 -0700 Subject: [PATCH 1/4] [lldb] Correctly restore the cursor column after re

  1   2   3   4   5   6   7   8   9   10   >