JDevlieghere wrote: > Asking just for this first time: In this code base (vscode-lldb), do you > recommend me to go ahead and merge with your approval, or should I wait for > @JDevlieghere to take a look, too?
Thanks for asking! The [Code Review Policy](https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted) touches on some of the nuances, but generally you can merge with one approval. I can still provide feedback as a post-commit review. That's a little harder for bigger/invasive/complicated patches (which usually also require more time to review), so waiting a little longer for those is generally appreciated. But a PR like this you can definitely merge. https://github.com/llvm/llvm-project/pull/152002 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
