@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
jennphilqc wrote:
> > I actually wrote this for a team that already has their own viewer. We've
> > suggested that they upstream that as well.
>
> Is that viewer in VS-Code or in some other editor? (Trying to avoid
> duplicating effort, so I don't accidentally implement the same thing)
It is
jennphilqc wrote:
> Given this, I think we should take the best parts of both PRs 🙂 What do you
> think about the following path forward?
>
> * rebase this PR on top of [[lldb-dap] Support inspecting memoryÂ
> #104317](https://github.com/llvm/llvm-project/pull/104317)
> * scope this PR down to
https://github.com/jennphilqc updated
https://github.com/llvm/llvm-project/pull/108036
>From b7e59ca0739240796b89b3d114d6c96c3b09c687 Mon Sep 17 00:00:00 2001
From: Jennifer Phillips
Date: Tue, 27 Aug 2024 10:48:37 -0700
Subject: [PATCH 1/2] Added readMemory and WriteMemory, var type correction
jennphilqc wrote:
Please add @clayborg as Reviewer.
https://github.com/llvm/llvm-project/pull/108036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
