https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/119052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/119052
>From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Dec 2024 18:17:44 -0800
Subject: [PATCH 1/5] Add SBPRogress class to enable commands to async report
to l
@@ -0,0 +1,68 @@
+//===-- SBProgress.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -2544,6 +2544,26 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
progress_up = std::make_unique(
"Reading binary from memory", file_spec.GetFilename().GetString());
+if (size_to_read == 0) {
+ // No size was provided, figure ou
@@ -2544,6 +2544,26 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
progress_up = std::make_unique(
"Reading binary from memory", file_spec.GetFilename().GetString());
+if (size_to_read == 0) {
+ // No size was provided, figure ou
@@ -2544,6 +2544,26 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
progress_up = std::make_unique(
"Reading binary from memory", file_spec.GetFilename().GetString());
+if (size_to_read == 0) {
+ // No size was provided, figure ou
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/123132
>From dbe633443f608f292c1f7f775d1b96b7eb808965 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 14 Jan 2025 14:23:05 -0800
Subject: [PATCH 1/2] Add draft docstrings for SBSaveCoreOptions
---
.../interfa
@@ -0,0 +1,72 @@
+%feature("docstring",
+"A container for options to use when saving a core file.
+
+SBSaveCoreOptions includes API's to specify the memory regions and threads to
include
+when generating a core file. These options are not exclusive the existing
SaveCoreStyle opt
Jlalond wrote:
I can still make an RFC if that is desired, but I believed we reached a
compromise with the new broadcast bit. I think we should frame the SBProgress
very differently to @labath's recent improvements to Progress itself. I think
the critical feature is the disposal of SBProgress
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/122541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/123132
SBSaveCoreOptions has been around for awhile now, so I decided to draft up some
Docstrings describing the functionality better. Some of my wording sounded a
bit clunky due the optionality of each method call so
https://github.com/Jlalond approved this pull request.
Great to see a quick follow up on this. I left a comment, but I think we should
still include some test cases not behind a typedef, and then include your test
changes as well to cover all the bases.
https://github.com/llvm/llvm-project/pul
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/123125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,15 +18,19 @@ int main() {
char buffer[sizeof(std::unordered_map)] = {0};
std::unordered_map &corrupt_map =
*(std::unordered_map *)buffer;
- std::unordered_map map; // Set break point at this line.
+ // Make a typedef to ensure functionality when typedefs are used
@@ -1105,7 +1105,7 @@ bool CompilerType::GetValueAsScalar(const
lldb_private::DataExtractor &data,
return false;
std::optional byte_size = GetByteSize(exe_scope);
-if (!byte_size)
+if (!byte_size || *byte_size == 0)
Jlalond wrote:
Nit: I wo
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/123107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/8] Make the thread list for SBSaveCoreOptions iterable
---
ll
@@ -115,8 +115,21 @@ const MemoryRanges
&SaveCoreOptions::GetCoreFileMemoryRanges() const {
return m_regions_to_save;
}
-Status SaveCoreOptions::EnsureValidConfiguration(
-lldb::ProcessSP process_sp) const {
+lldb::ThreadCollectionSP SaveCoreOptions::GetThreadsToSave()
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/7] Make the thread list for SBSaveCoreOptions iterable
---
ll
@@ -79,3 +81,26 @@ def test_adding_thread_different_process(self):
self.assertTrue(error.Fail())
error = options.AddThread(thread)
self.assertTrue(error.Success())
+
+def test_removing_and_adding_insertion_order(self):
+"""Test insertion orde
Jlalond wrote:
Hey @DavidSpickett, sure I'm drafting that up now. What time frame should we
include commits from? I ask because one of my original patches added [64b
support, and paging](https://github.com/llvm/llvm-project/pull/95312). I assume
we could include anyway as I don't see it in the
Jlalond wrote:
@JDevlieghere friendly bump, I just wanna sneak this into our release this
week, I think all the comments are addressed!
https://github.com/llvm/llvm-project/pull/119052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/6] Make the thread list for SBSaveCoreOptions iterable
---
ll
@@ -56,7 +57,7 @@ class SaveCoreOptions {
std::optional m_file;
std::optional m_style;
lldb::ProcessSP m_process_sp;
- std::unordered_set m_threads_to_save;
+ std::unordered_map m_threads_to_save;
Jlalond wrote:
Yeah we can, good call out.
https://git
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/5] Make the thread list for SBSaveCoreOptions iterable
---
ll
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/4] Make the thread list for SBSaveCoreOptions iterable
---
ll
Jlalond wrote:
@clayborg and I chatted offline. The need for indexable access wasn't as
important as exposing an enumeration of threads. So we instead return a copy of
the thread list in an SBThreadCollection.
https://github.com/llvm/llvm-project/pull/122541
___
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/3] Make the thread list for SBSaveCoreOptions iterable
---
ll
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/3] Make the thread list for SBSaveCoreOptions iterable
---
ll
@@ -47,6 +46,9 @@ class SaveCoreOptions {
void AddMemoryRegionToSave(const lldb_private::MemoryRegionInfo ®ion);
+ std::optional GetThreadAtIndex(uint32_t idx) const;
Jlalond wrote:
We can, I'm personally willing to trade the complexity for the performanc
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/122541
>From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 10 Jan 2025 14:26:10 -0800
Subject: [PATCH 1/2] Make the thread list for SBSaveCoreOptions iterable
---
ll
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/122541
This patch adds the ability to get a thread at a give index, based on insertion
order, for SBSaveCore Options. This is primarily to benefit scripts using
SBSaveCore, and remove the need to have both options and
Jlalond wrote:
@JDevlieghere Do we want to add new tests having the external bit by default? I
added unit tests in the [external category
bit](https://github.com/llvm/llvm-project/pull/120171/files#diff-a1f24599f1588366a91518f71afd1a54b6f8172a1f0891747e6972d126be4159)
PR. Any additional test r
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/119052
>From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Dec 2024 18:17:44 -0800
Subject: [PATCH 1/4] Add SBPRogress class to enable commands to async report
to l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/119052
>From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Dec 2024 18:17:44 -0800
Subject: [PATCH 1/4] Add SBPRogress class to enable commands to async report
to l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/119052
>From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Dec 2024 18:17:44 -0800
Subject: [PATCH 1/3] Add SBPRogress class to enable commands to async report
to l
@@ -89,8 +89,11 @@ Status
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
"Failed to fill in header and directory "
"sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
new_offset, m_saved_data_size);
-
return error;
+ if (error.Fai
@@ -89,8 +89,11 @@ Status
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
"Failed to fill in header and directory "
"sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
new_offset, m_saved_data_size);
-
return error;
+ if (error.Fai
@@ -89,8 +89,11 @@ Status
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
"Failed to fill in header and directory "
"sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
new_offset, m_saved_data_size);
-
return error;
+ if (error.Fai
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,6 +144,9 @@ class Progress {
/// Data needed by the debugger to broadcast a progress event.
const ProgressData m_progress_data;
+ /// The origin of this progress event.
+ const Origin m_origin;
Jlalond wrote:
Good catch! Fixed.
https://github.c
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/7] Add external progress bit category
---
lldb/include/lldb/C
Jlalond wrote:
Hey @JDevlieghere, I was out for the holidays, but did you want to take a
second look at this? Or can I land it to rebase the SBProgress changes on top
of?
https://github.com/llvm/llvm-project/pull/120171
___
lldb-commits mailing list
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/120166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -89,8 +89,11 @@ Status
MinidumpFileBuilder::AddHeaderAndCalculateDirectories() {
"Failed to fill in header and directory "
"sections. Written / Expected (%" PRIx64 " / %" PRIx64 ")",
new_offset, m_saved_data_size);
-
return error;
+ if (error.Fai
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/6] Make workaround for the Dynamic loader issue
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/5] Make workaround for the Dynamic loader issue
---
.../Minid
Jlalond wrote:
> I don't find the "MinidumpParser does not distinguish empty/missing streams"
> argument particularly convincing, since the underlying llvm class
> (`MinidumpFile`) does distinguish them and a
> `MinidumpParser::ContainsStream()` function would be a lot simpler than this
> mag
@@ -126,6 +129,17 @@ Status MinidumpFileBuilder::AddDirectory(StreamType type,
return error;
}
+Status MinidumpFileBuilder::AddLLDBGeneratedStream() {
+ Status error;
+ StreamType type = StreamType::LLDBGenerated;
Jlalond wrote:
Dropped the magic bytes an
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/4] Make workaround for the Dynamic loader issue
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/3] Make workaround for the Dynamic loader issue
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/3] Make workaround for the Dynamic loader issue
---
.../Minid
Jlalond wrote:
@labath I went with your suggestion as the better idea. I ended up just writing
'LLDB' to the stream, because the current API behavior for MinidumpParser is to
return an empty ArrayRef. So there was no direct way to detect an existing but
empty stream. For now I just set the che
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/2] Make workaround for the Dynamic loader issue
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/6] Add external progress bit category
---
lldb/include/lldb/C
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/5] Add external progress bit category
---
lldb/include/lldb/C
@@ -106,9 +107,15 @@ void Progress::ReportProgress() {
if (completed < m_prev_completed)
return; // An overflow in the m_completed counter. Just ignore these
events.
+ // Change the category bit if we're an internal or external progress.
+ uint32_t progress_category_b
Jlalond wrote:
@JDevlieghere I'm hoping I did this right, additionally any preference on where
the enum should live? I debated on enumerations and just make a generic
'eventorigin' enumeration that we could reuse for events in the future. But I
figured that was reaching.
https://github.com/ll
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/120171
As feedback on #119052, it was recommended I add a new bit to delineate
internal and external progress events. This patch adds this new category, and
sets up Progress.h to support external events via SBProgress
https://github.com/Jlalond unassigned
https://github.com/llvm/llvm-project/pull/120166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond unassigned
https://github.com/llvm/llvm-project/pull/120166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/120166
In #119598 my recent TLS feature seems to break crashpad symbols. I have a few
ideas on how this is happening, but for now as a mitigation I'm checking if the
Minidump was LLDB generated, and if so leveraging t
Jlalond wrote:
@JDevlieghere if I were to add a way to identify an 'internal' vs 'external'
progress, do you want me to make all consumers aware to this distinction or are
we cool with just exposing the property as a part of this patch?
https://github.com/llvm/llvm-project/pull/119052
Jlalond wrote:
> > Just to throw my opinion into the debate; I view Progress.h in the same way
> > as I view any printing to the terminal (or stdout). We already allow Python
> > commands, and I believe formatters, to print to the user's console. So
> > restricting progress because we don't wa
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/119052
>From 2adc8124e9b423d7c195cc6b986b43dfa8c10fe4 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Dec 2024 18:17:44 -0800
Subject: [PATCH 1/2] Add SBPRogress class to enable commands to async report
to l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/119052
>From 2adc8124e9b423d7c195cc6b986b43dfa8c10fe4 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 6 Dec 2024 18:17:44 -0800
Subject: [PATCH 1/2] Add SBPRogress class to enable commands to async report
to l
Jlalond wrote:
> The patch itself looks good with some nits, but I'm (still) on the fence
> whether this a good idea.
>
> In the past, a similar question has come up in the context of logging and
> whether we want to add SB APIs to make use of LLDB's internals. The argument
> in favor is that
@@ -0,0 +1,34 @@
+//===-- SBProgress.cpp ---*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/119052
Recently I've been working on a lot of internal Python tooling, and in certain
cases I want to report async to the script over DAP. Progress.h already handles
this, so I've exposed Progress via the SB API so Py
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/117358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/117604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
> The build succeeded!
>
> The source comment at line 82 caught my attention, though. It may imply that
> data layout is important in this struct, i.e. it should match `siginfo_t`
> returned by the OS. But this change is not guaranteeing that.
>
> Actually, the order of the fir
Jlalond wrote:
@tuliom Experimented on godbolt a bit, it looks like alignas(8) will handle our
padding to 56 on 32 and 64 https://godbolt.org/z/ssqeeEs71
https://github.com/llvm/llvm-project/pull/117604
___
lldb-commits mailing list
lldb-commits@lists
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/117604
>From 693f1039e10e5dd26ef0d600b03895f71f340b23 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 25 Nov 2024 10:26:07 -0800
Subject: [PATCH 1/2] Set all the properties of ELFLinuxSigInfo to a non build
de
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/117604
On #110065 the changes to LinuxSigInfo Struct introduced some variables that
will differ in size on 32b or 64b. I've rectified this by setting them all to
build independent types.
>From 693f1039e10e5dd26ef0d60
Jlalond wrote:
@tuliom I don't have a way to verify this, would you mind assisting?
https://github.com/llvm/llvm-project/pull/117604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Ack, sorry about the delay. I will get this fixed today.
https://github.com/llvm/llvm-project/pull/110065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@lukejriddle Can we add a test for this? We just want to have a test case that
iterates the regions.
https://github.com/llvm/llvm-project/pull/117358
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/110065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond approved this pull request.
[The Build
Fix](https://github.com/llvm/llvm-project/pull/116689/commits/1bcfd2a9a1e7ea4ee984f7198ae4ba4148c4861f),
looks good to me. I'm happier with us setting dynsym before the if condition
as well.
https://github.com/llvm/llvm-project
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/115197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -179,55 +142,34 @@ Status MainLoopPosix::RunImpl::Poll() {
read_fds.push_back(pfd);
}
- if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 &&
+ if (ppoll(read_fds.data(), read_fds.size(),
+/*timeout=*/nullptr,
Jlalond w
@@ -384,6 +313,21 @@ void
MainLoopPosix::ProcessReadObject(IOObject::WaitableHandle handle) {
it->second(*this); // Do the work
}
+void MainLoopPosix::ProcessSignals() {
+ std::vector signals;
Jlalond wrote:
(Uneducated question) Is int actually the cor
https://github.com/Jlalond approved this pull request.
I'm not expert, but everything looks rigorous and you've added a lot of
comments.
I left a few nits and a singular question. I would encourage comments on some
file descriptors for the less knowledgeable of us (namely me!)
https://github.
@@ -179,55 +142,34 @@ Status MainLoopPosix::RunImpl::Poll() {
read_fds.push_back(pfd);
}
- if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 &&
+ if (ppoll(read_fds.data(), read_fds.size(),
+/*timeout=*/nullptr,
+/*sigmask=*/n
@@ -17,29 +17,53 @@
#include
#include
#include
+#include
#include
// Multiplexing is implemented using kqueue on systems that support it (BSD
-// variants including OSX). On linux we use ppoll, while android uses pselect
-// (ppoll is present but not implemented proper
https://github.com/Jlalond approved this pull request.
LGTM @JDevlieghere!
https://github.com/llvm/llvm-project/pull/116269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/111601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond approved this pull request.
Appreciate the explanation to your concerns. I'll try to get to your syscall
replacement PR today or tomorrow.
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-c
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self):
@expectedFlakeyLinux(bugnumber="llvm.org/pr26437")
@skipIfDarwinEmbedded # debugserver can't create/write files on the device
def test_stdout_stderr_redirection_to_existing_files(self):
-"""Exerc
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self):
@expectedFlakeyLinux(bugnumber="llvm.org/pr26437")
@skipIfDarwinEmbedded # debugserver can't create/write files on the device
def test_stdout_stderr_redirection_to_existing_files(self):
-"""Exerc
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self):
@expectedFlakeyLinux(bugnumber="llvm.org/pr26437")
@skipIfDarwinEmbedded # debugserver can't create/write files on the device
def test_stdout_stderr_redirection_to_existing_files(self):
-"""Exerc
@@ -6,6 +6,8 @@
//
//===--===//
+#include
Jlalond wrote:
It's also passing the Windows CI. @bulbazord I can help @kusmour validate if
you want, but I personally think CI is good enough
ht
https://github.com/Jlalond commented:
A lot of this is over my head, but I left a few comments anyway.
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -155,7 +181,9 @@ Status MainLoopPosix::RunImpl::Poll() {
void *sigset_ptr;
size_t sigset_len;
} extra_data = {&kernel_sigset, sizeof(kernel_sigset)};
- if (syscall(__NR_pselect6, nfds, &read_fd_set, nullptr, nullptr, nullptr,
+ if (syscall(__NR_pselect6, nfds, &r
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -38,6 +40,9 @@ class MainLoopBase {
class ReadHandle;
public:
+ using TimePoint = std::chrono::time_pointhttps://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
1 - 100 of 495 matches
Mail list logo
