[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-07-29 Thread Jacob Lalonde via lldb-commits
@@ -18,6 +18,26 @@ def tearDown(self): if self.background_pid: os.kill(self.background_pid, signal.SIGKILL) +def test_getname(self): +"""Test the SBModule::GetName() method""" +self.build() +target, _, _, _ = lldbutil.run_to_sour

[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-07-29 Thread Jacob Lalonde via lldb-commits
@@ -18,6 +18,26 @@ def tearDown(self): if self.background_pid: os.kill(self.background_pid, signal.SIGKILL) +def test_getname(self): +"""Test the SBModule::GetName() method""" +self.build() +target, _, _, _ = lldbutil.run_to_sour

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @satyajanga merged for you https://github.com/llvm/llvm-project/pull/150268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/150268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix uninitialized memory access. (PR #150544)

2025-07-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. Thanks @slackito! https://github.com/llvm/llvm-project/pull/150544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-23 Thread Jacob Lalonde via lldb-commits
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate( // grows to the nearest host integer type. llvm::APInt fail_value(1, 0, false); llvm::APInt ap_int = scalar.UInt128(fail_value); -assert(ap_int.getBitWidth() >= bit_

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-21 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/149401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/149401 >From 4e692b251329196ff09aa8fc7d0e329c42df1b50 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 16 Jul 2025 12:57:58 -0700 Subject: [PATCH 1/4] Add check-memory command to see if an address is in a Minid

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Process minidump better error messages (PR #149206)

2025-07-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/149206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -1130,9 +1122,9 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector &ranges, // Capture the starting offset for all the descriptors so we can clean them up // if needed. offset_t starting_offset = - GetCurrentDataEndOffset() + sizeof(llvm::support::ulittle64_t)

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -164,3 +164,46 @@ def test_get_total_in_bytes_missing_requirements(self): options.SetStyle(lldb.eSaveCoreCustomOnly) total = options.GetCurrentSizeInBytes(error) self.assertTrue(error.Fail(), error.GetCString()) + +def test_get_memory_regions_to_s

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,130 @@ +""" +Test that saved memory regions is byte-wise 1:1 with the live process. Specifically +that the memory regions that will be populated in the Memory64List are the same byte for byte. +""" + +import os +import lldb +from lldbsuite.test.decorators import * +f

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-16 Thread Jacob Lalonde via lldb-commits
@@ -63,6 +67,12 @@ Note that currently ELF Core files are not supported." Get an SBThreadCollection of all threads marked to be saved. This collection is not sorted according to insertion order." ) lldb::SBSaveCoreOptions::GetThreadsToSave; +%feature("docstring", " +G

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/146777 >From d17473cc32acb31935759012ca87342d750d68f7 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 2 Jul 2025 09:18:59 -0700 Subject: [PATCH 01/16] Fix logs, prevent accidentally printing a partial read whe

[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

2025-07-14 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/146777 >From d17473cc32acb31935759012ca87342d750d68f7 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 2 Jul 2025 09:18:59 -0700 Subject: [PATCH 01/14] Fix logs, prevent accidentally printing a partial read whe

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for Memory64 RVA in Minidump (+ Testing changes) (PR #146777)

2025-07-03 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Alternative proposal and one @clayborg and I talked about for awhile. Why don't we just put all the non-stacks into Memory64List? Originally I didn't want to change this out of not being familiar with how everything works, but now that we have a 64b list I think it makes sense t

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for Memory64 RVA in Minidump (+ Testing changes) (PR #146777)

2025-07-03 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @jeffreytan81 Sure, but I'll have to revisit after I return from vacation https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for Memory64 RVA in Minidump (+ Testing changes) (PR #146777)

2025-07-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for first 64b Memory Descriptor in Minidump (+ Testing changes) (PR #146777)

2025-07-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for first 64b Memory Descriptor in Minidump (+ Testing changes) (PR #146777)

2025-07-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/146777 >From d17473cc32acb31935759012ca87342d750d68f7 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 2 Jul 2025 09:18:59 -0700 Subject: [PATCH 1/8] Fix logs, prevent accidentally printing a partial read when

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for first 64b Memory Descriptor in Minidump (+ Testing changes) (PR #146777)

2025-07-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for first 64b Memory Descriptor in Minidump (+ Testing changes) (PR #146777)

2025-07-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/146777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for first 64b Memory Descriptor in Minidump (+ Testing changes) (PR #146777)

2025-07-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/146777 ### Context Over a year ago, I landed support for 64b Memory ranges in Minidump (#95312). In this patch we added the Memory64 list stream, which is effectively a Linked List on disk. The layout is a sixteen by

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-25 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/144800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/144800 >From 157b5a5177784bc2ce4e8bf952c812aedd5be258 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 18 Jun 2025 14:35:37 -0700 Subject: [PATCH 1/2] Add SI_USER and SI_KERNEL to Linux signals --- lldb/source

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/144800 >From 157b5a5177784bc2ce4e8bf952c812aedd5be258 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 18 Jun 2025 14:35:37 -0700 Subject: [PATCH 1/2] Add SI_USER and SI_KERNEL to Linux signals --- lldb/source

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-24 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > It's crude but maybe just include SI_KERNEL in there? "sent by kernel > (SI_KERNEL)". Then we don't have to explain the meaning of SI_KERNEL but I > the user do have something I can look up and read about it. And if they do > have a kernel side problem, doing some reading is w

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/144800 >From 157b5a5177784bc2ce4e8bf952c812aedd5be258 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 18 Jun 2025 14:35:37 -0700 Subject: [PATCH 1/2] Add SI_USER and SI_KERNEL to Linux signals --- lldb/source

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-20 Thread Jacob Lalonde via lldb-commits
@@ -154,14 +154,33 @@ def test_find_in_memory_unaligned(self): self.assertEqual(addr, lldb.LLDB_INVALID_ADDRESS) def test_memory_info_list_iterable(self): -"""Make sure the SBMemoryRegionInfoList is iterable""" +"""Make sure the SBMemoryRegionInfoLi

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/144815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-18 Thread Jacob Lalonde via lldb-commits
@@ -154,14 +154,32 @@ def test_find_in_memory_unaligned(self): self.assertEqual(addr, lldb.LLDB_INVALID_ADDRESS) def test_memory_info_list_iterable(self): -"""Make sure the SBMemoryRegionInfoList is iterable""" +"""Make sure the SBMemoryRegionInfoLi

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond requested changes to this pull request. Mostly nits, I think we should expand the scope of the fix and add an equality operator for the SBMemoryRegionInfo. Cleans up your test and will save a lot of developer time because this is a very popular SB API https://github.

[Lldb-commits] [lldb] [lldb] Fix SBMemoryRegionInfoListExtensions iter to yield unique refe… (PR #144815)

2025-06-18 Thread Jacob Lalonde via lldb-commits
@@ -154,14 +154,32 @@ def test_find_in_memory_unaligned(self): self.assertEqual(addr, lldb.LLDB_INVALID_ADDRESS) def test_memory_info_list_iterable(self): -"""Make sure the SBMemoryRegionInfoList is iterable""" +"""Make sure the SBMemoryRegionInfoLi

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/144800 >From 157b5a5177784bc2ce4e8bf952c812aedd5be258 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 18 Jun 2025 14:35:37 -0700 Subject: [PATCH] Add SI_USER and SI_KERNEL to Linux signals --- lldb/source/Plu

[Lldb-commits] [lldb] [LLDB] Add SI_USER and SI_KERNEL to Linux signals (PR #144800)

2025-06-18 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/144800 @dmpots and I were investigating a crash when he was developing LLDB earlier. When I loaded the core I was surprised to see LLDB didn't have information for the SI_CODE. Upon inspection we had an si_code of `12

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/136040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/136040 >From 08d31267245da41e6ad2c1d5dd32e242867fbb18 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 16 Apr 2025 14:33:04 -0700 Subject: [PATCH 1/3] Implement a range data vector for minidump memory ranges --

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/136040 >From 40ca59992a02a5d236263ea88d8f7c1569b5e6c2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 16 Apr 2025 14:33:04 -0700 Subject: [PATCH 1/3] Implement a range data vector for minidump memory ranges --

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
@@ -45,9 +49,16 @@ struct Range { friend bool operator==(const Range &lhs, const Range &rhs) { return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref; } + + friend bool operator<(const Range &lhs, const Range &rhs) { +return lhs.start < rhs.start;

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-16 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > However, FileSpecList already has an AppendIfUnique method. So you could > (with less code than the current implementation) have all the new > lldb_private API's return what consumers actually want: an FileSpecList, and > then that would be trivially convertible to the SBFileS

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/144119 >From 8fdbcc5d037069b977dbf44bf2e5125d91a11743 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 12 Jun 2025 13:57:50 -0700 Subject: [PATCH 1/6] Expose SBModule iterator for all separate debug info module

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-13 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @jasonmolenda tagged you because I think you're the relevant SME, but feel free to reassign otherwise. https://github.com/llvm/llvm-project/pull/144119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-13 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/144119 Today we can run `target modules dump separate-debug-info --json` to get a json blob of all the separate debug info, but it has a few shortcomings when developing some scripting against it. Namely, the caller h

[Lldb-commits] [lldb] [lldb] Implement JSON RPC (newline delimited) Transport (PR #143946)

2025-06-12 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere not a review, but any context on for the change? Just curious. https://github.com/llvm/llvm-project/pull/143946 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] Properly handle locate module callback while overriding (PR #143793)

2025-06-11 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond commented: This makes sense to me. Let's update the PR description to explain whenever Target changes architecture we mvoe any corresponding platform Module callback, because that wasn't really apparent to me from reading the summary. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] Minor fix to connect-url to support unix-connect sockets on localhost (PR #142875)

2025-06-10 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/142875 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond commented: Commented on my own real concern. David can approve the land, but please don't break the current default behavior :) https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/143126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Jacob Lalonde via lldb-commits
@@ -198,6 +198,8 @@ static constexpr OptionEnumValueElement g_completion_type[] = { "Completes to a type category name."}, {lldb::eCustomCompletion, "custom", "Custom completion."}, {lldb::eThreadIDCompletion, "thread-id", "Completes to a thread ID."}, +{lldb:

[Lldb-commits] [lldb] [lldb] add plugin names to process save-core error output. (PR #143126)

2025-06-09 Thread Jacob Lalonde via lldb-commits
@@ -797,7 +797,8 @@ let Command = "process save_core" in { EnumArg<"SaveCoreStyle">, Desc<"Request a specific style " "of corefile to be saved.">; def process_save_core_plugin_name : Option<"plugin-name", "p">, -OptionalArg<"Plugin">, Desc<"Specify a plugin name t

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/142684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond requested changes to this pull request. https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -104,7 +104,7 @@ TEST(Perf, RealLogicalCoreIDs) { ASSERT_GT((int)cpu_ids->size(), 0) << "We must see at least one core"; } -TEST(Perf, RealPtraceScope) { +TEST(Perf, RealPtraceScopeWhenExist) { Jlalond wrote: This will probably fail, I don't think `kerne

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -74,7 +74,7 @@ lldb_private::process_linux::GetAvailableLogicalCoreIDs() { llvm::Expected lldb_private::process_linux::GetPtraceScope() { ErrorOr> ptrace_scope_file = getProcFile("sys/kernel/yama/ptrace_scope"); - if (!*ptrace_scope_file) + if (!ptrace_scope_file)

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/142200 >From 05f09fa434c7fa925935337fb44740f1beba52ba Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 30 May 2025 12:02:02 -0700 Subject: [PATCH 1/3] Flip and add test --- .../Plugins/Platform/Linux/PlatformL

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,10 @@ +#include Jlalond wrote: I do think it's weird. Strangely enough all the existing SIGINFO shell tests also live in this directory. I think it would lead to more confusion to break that, but it's a great refactoring opportunity https://github

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,6 @@ +# XFAIL: system-darwin Jlalond wrote: Can you give me an example @dmpots? I would want to run this only on Linux https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/142200 >From 05f09fa434c7fa925935337fb44740f1beba52ba Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 30 May 2025 12:02:02 -0700 Subject: [PATCH 1/2] Flip and add test --- .../Plugins/Platform/Linux/PlatformL

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip uid and pid in get signal description (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/142200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip and add test (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/142200 >From 05f09fa434c7fa925935337fb44740f1beba52ba Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 30 May 2025 12:02:02 -0700 Subject: [PATCH] Flip and add test --- .../Plugins/Platform/Linux/PlatformLinux

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip and add test (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/142200 >From ac33700e4b248fd9ee2bcb7ee12922fbe38ca5b2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 30 May 2025 12:02:02 -0700 Subject: [PATCH] Flip and add test --- lldb/test/Shell/Register/Core/Inputs/tki

[Lldb-commits] [lldb] [LLDB][Platform Linux] Flip and add test (PR #142200)

2025-05-30 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/142200 Despite a great review from @labath, I accidentally landed the signal with the UID and PID properties flipped. I was actually trying to write tests for this feature when I discovered it. This fixes that bug,

[Lldb-commits] [lldb] [lldb] Fix Linux core file tests hanging on Windows (PR #142143)

2025-05-30 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Hey @DavidSpickett thanks for fixing the test. I think you fixed it the right way, but I wanted to share my understanding of how this probably happened In ProcessElfCore, we check the siginfo status of all the threads ``` if (!siginfo_signal_found) { // If we don't have s

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: https://lab.llvm.org/buildbot/#/builders/197/builds/6014 looks like we're passing https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @labath I'm landing to not leave the build broken, but if you have a better solution/means of doing this let me know and I'll implement it https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: ``` MINIDUMP_MEMORY64_LIST: NumberOfMemoryRanges = 0x0042 BaseRva = 0x7f1963c0 MemoryRanges[0] = [0x - 0x7f1a4020) MemoryRanges[1] = [0x - 0x7f1e0820) MemoryRanges[2] = [0x00

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug in generating 64b memory minidumps (PR #141995)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/141995 In #129307, we introduced read write in chunks, and during the final revision of the PR I changed the behavior for 64b memory regions and did not test an actual 64b memory range. This caused LLDB to crash when

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > Ummm... I should have caught this before, but this isn't correct because the > host system may (and some do) use different signal numbers for these > constants. Are these actually different on Mac? These 4 are the same on BSD to my knowledge. How do you think we should go ab

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Hey @felipepiovezan am I reading green dragon right https://green.lab.llvm.org/job/llvm.org/job/as-lldb-cmake/changes Looks like the build with my changes failed (with I believe unrelated test failures), then went green? Does that mean we're working on Darwin? https://github.c

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
@@ -34,6 +34,20 @@ #define MAP_PRIVATE 2 #define MAP_ANON 0x20 +// For other platforms that use platform linux +#ifndef SIGILL +#define SIGILL 4 +#endif +#ifndef SIGBUS +#define SIGBUS 7 +#endif +#ifndef SIGFPE +#define SIGFPE 8 +#endif +#ifndef SIGSEGV +#define SIGSEGV 11 ---

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: I'm going to wait to see how many build issues we get before landing. https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Put up a fix for Windows on #141971 https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/141971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add ifndef to platform linux (PR #141971)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/141971 Another iteration of fixes for #141670. Platform linux can be used by other platforms, so we need to supply the signal values if they're not defined. >From 0612b888a0dd0cda09fbaa89f5e68c15a1bc9e98 Mon Sep 17 00

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere I did run this on my local Mac (Very slowly on an M1 🥲). Got no failures, but still FYI https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
@@ -27,6 +27,30 @@ #ifndef SEGV_CPERR #define SEGV_CPERR 10 #endif +#ifndef SI_QUEUE +#define SI_QUEUE -1 +#endif +#ifndef SI_TIMER +#define SI_TIMER -2 +#endif +#ifndef SI_MESGQ +#define SI_MESGQ -3 +#endif +#ifndef SI_ASYNCIO +#define SI_ASYNCIO -4 +#endif +#ifndef SI_SIGIO +

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-29 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/6] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead processes on Linux (PR #137041)

2025-05-28 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > What do you say to all this? I realize I am sort of asking you my pet > feature, but I think that by framing your feature (debugging of dead > processes) as a special case of this (debugging exiting processes), we can > avoid most of the problematic issues with this PR (diverg

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/5] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/5] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > but the I find the implementation somewhat unelegant. 😎 That's certainly me! In all seriousness, I am still drinking from the proverbial firehouse. So I appreciate the patience as I learn the codebase (even a year later). You are correct, the checks are now unimportant becaus

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/4] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere Is there a way to trigger GreenDragon/Mac CI for this? https://github.com/llvm/llvm-project/pull/141670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/141670 After some debugging, I found out ProcessELFCore never updates the platform. I've updated ProcessElfCore to set the arch and platform before we parse the Notes. >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 M

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @petrhosek Hey Petr, can you provide more information? For Linux environments, SI_DETHREAD should be present. The commit for this signal specifically is 13 years old, @DavidSpickett do you have any insight as to why this is happening? https://github.com/torvalds/linux/commit/8a

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere reverted while I investigate https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141645)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/141645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141645)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/141645 Reverts llvm/llvm-project#140150 Broke the Darwin tests, but they pass on Linux. Reverting to make the build healthy while I investigate >From 8da155e11c3d168d8f8ad59d4691156e57549d57 Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @felipepiovezan I am indeed the problem here. I'm confused how they're passing on Linux but failing on Mac. I'll investigate. https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @DavidSpickett I'll make a follow up patch! https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   4   5   6   7   8   9   >