Jlalond wrote:

> but the I find the implementation somewhat unelegant.

😎 That's certainly me!

In all seriousness, I am still drinking from the proverbial firehouse. So I 
appreciate the patience as I learn the codebase (even a year later).

You are correct, the checks are now unimportant because 
`Thread::GetSiginfoValue` will handle this for us directly, and we have a 
fallback clause in `CalculateStopInfo` that handled that error case. I've 
removed this clause. I still need to address Petr's build concern before we 
reapply this.

https://github.com/llvm/llvm-project/pull/141670
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to