[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

gkistanova added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:72 "-DCMAKE_BUILD_TYPE=" + config, +"-DLLVM_LIT_ARGS='%s'" % lit_args, "-DCMAKE_INSTALL_PREFIX=../install", To work as expected, this line should be wrap

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. Statically linked LLVM + LLD builds with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdcb9ab10e53: Revert "Use find_library for ncurses" (authored by haampie, committed by gkistanova). Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

gkistanova added a comment. Hi Petr, I don't have a strong opinion on the exact way of fixing the problem. But we should do this as soon as possible, as keeping the bots red for that long is not Ok. Please send me your patch and I will check it on lld-perf-testsuite bot. If you do not have th

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

gkistanova added a comment. Fair enough. Reverted. https://github.com/llvm/llvm-project/commit/cdcb9ab10e53ff08293915af3cd897c42112bcc5 Thanks, everyone! Petr, please feel free to send me a patch you want me to check for you. Make sure I could apply it on top of the trunk. Repository: rG LL

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

gkistanova added a comment. Hi Mateusz, Yes, this looks like a separate patch on top of this revert. By the way, this hasn't been merged yet. Are we waiting for anything? Harmen, do you need a help committing this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. I have checked this patch with http://lab.llvm.org:8011/builders/lld-perf-testsuite bot. It makes it green. Thanks for reverting, Harmen! Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

gkistanova reopened this revision. gkistanova added a comment. This revision is now accepted and ready to land. @haampie Are you working on fixing the http://lab.llvm.org:8011/builders/lld-perf-testsuite bot? This patch has broken it. FAILED: bin/llvm-tblgen : && /usr/bin/c++ -fvisibility

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

gkistanova added a comment. The cmake command redefinition effectively is not supported any more, but the 'cmake' arg is left behind. + inline comments. These have been addressed by https://reviews.llvm.org/rZORG425eeb1bf21b. Comment at: zorg/buildbot/builders/LLDBBuilder.py:

[Lldb-commits] [PATCH] D60458: [zorg] Add lldb-x86_64-debian builder

gkistanova accepted this revision. gkistanova added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60458/new/ https://reviews.llvm.org/D60458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D35356: [zorg] Enable assertions on the linux lldb bot

gkistanova added a comment. Hi Pavel, The patch looks Ok, with a small issue to address before committing. Comment at: zorg/buildbot/builders/LLDBBuilder.py:921 scriptExt='.sh', + extra_cmake_args=[], ): ---