gkistanova added a comment. The cmake command redefinition effectively is not supported any more, but the 'cmake' arg is left behind. + inline comments.
These have been addressed by https://reviews.llvm.org/rZORG425eeb1bf21b. ================ Comment at: zorg/buildbot/builders/LLDBBuilder.py:110 - cmake_cmd = [ - "cmake", "-G", "Ninja", os.path.join(os.pardir, f.monorepo_dir, "llvm"), + path = os.path.join(os.pardir, f.monorepo_dir, "llvm") + cmake_options = [ ---------------- This would build a path per notations on master. Which could be different than what a builder expects. Think of master running on Windows, for example. Better use a "/" path separator as these days it seems supported by all platforms we care about. ================ Comment at: zorg/buildbot/builders/LLDBBuilder.py:130 + doStepIf=FileDoesNotExist( + "./%s/CMakeCache.txt" % build_dir))) ---------------- It is better to always run the cmake configure step. It doesn't take long but handles some dependencies. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
