[Lldb-commits] [lldb] [lldb][nfc] Fix missing move operations and constness of methods (PR #142052)

2025-05-30 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/142052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: There's a very good chance this is breaking a lot of tests on mac: https://green.lab.llvm.org/job/as-lldb-cmake/26580/console Could you have a look? The only other commit there is a table gen warning fix https://github.com/llvm/llvm-project/pull/140150 ___

[Lldb-commits] [lldb] Support stepping through Darwin "branch islands" (PR #139301)

2025-05-13 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/139301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-05-12 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: hi @kuilpd , I think this may have broken the mac incremental bots: https://green.lab.llvm.org//job/as-lldb-cmake/25656/ ``` [2025-05-12T12:08:03.542Z] runCmd: frame variable -d run-target *cfDictionaryRef [2025-05-12T12:08:03.542Z] [2025-05-12T12:08:03.542Z] runCmd fail

[Lldb-commits] [lldb] Support stepping through Darwin "branch islands" (PR #139301)

2025-05-09 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/139301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding a modules explorer to lldb-dap ext. (PR #138977)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: It may be a coincidence, but a DAP test failed in green dragon right after this patch was applied: https://ci.swift.org/view/all/job/llvm.org/job/as-lldb-cmake/25465/console TestDAP_repl_mode_detection.py DAP tasks have been flaky though, so maybe unrelated, I don't full

[Lldb-commits] [lldb] Branch island debug (PR #139166)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. Fingers crossed this will give us enough info! https://github.com/llvm/llvm-project/pull/139166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Ah there were _two_ tests here. I've disabled the other one too. https://github.com/llvm/llvm-project/pull/137904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: 28156539a9df 20250508 fpiove.. [lldb] Disable test using GetControlFlowKind on arm (HEAD, llvm/main) https://github.com/llvm/llvm-project/pull/137904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: @eronnen my fix does not seem to have worked https://github.com/llvm/llvm-project/pull/137904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2815653 - [lldb] Disable test using GetControlFlowKind on arm

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-05-08T13:14:40-07:00 New Revision: 28156539a9df3fa0d9db47c405c0006fcee9f77f URL: https://github.com/llvm/llvm-project/commit/28156539a9df3fa0d9db47c405c0006fcee9f77f DIFF: https://github.com/llvm/llvm-project/commit/28156539a9df3fa0d9db47c405c0006fc

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -44,6 +44,48 @@ def step_out_with_scripted_plan(self, name): stop_desc = thread.GetStopDescription(1000) self.assertIn("Stepping out from", stop_desc, "Got right description") +def run_until_branch_instruction(self): +self.build() +(targe

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: To fix the bots, I've disabled your new test in all non x86 archs, feel free to update if you want to do something else https://github.com/llvm/llvm-project/pull/137904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] cb0b961 - [lldb] Disable test using GetControlFlowKind on arm

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-05-08T08:11:17-07:00 New Revision: cb0b9614f8ca7ffcd5f091b1c9990adfd6cb7e33 URL: https://github.com/llvm/llvm-project/commit/cb0b9614f8ca7ffcd5f091b1c9990adfd6cb7e33 DIFF: https://github.com/llvm/llvm-project/commit/cb0b9614f8ca7ffcd5f091b1c9990adfd

[Lldb-commits] [lldb] bbafa52 - [lldb] Fix asan failure in MinidumpFileBuilder

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-05-08T07:27:09-07:00 New Revision: bbafa5214e8d5d5daf7cf428780500b13a7d6cbb URL: https://github.com/llvm/llvm-project/commit/bbafa5214e8d5d5daf7cf428780500b13a7d6cbb DIFF: https://github.com/llvm/llvm-project/commit/bbafa5214e8d5d5daf7cf428780500b13

[Lldb-commits] [lldb] [lldb] Expose QueueThreadPlanForStepSingleInstruction function to SBThreadPlan (PR #137904)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: @eronnen this is breaking the incremental green dragon bots. Could you revert while you look at this please? https://ci.swift.org/view/all/job/llvm.org/job/as-lldb-cmake/25425/changes#41321416815d74a4a7fd15c78fcfa5af457625bb ``` [2025-05-08T12:15:32.021Z] ==

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Pushed your suggestion > Lol, I think its this: > > https://github.com/llvm/llvm-project/blob/6babd63a4bbc094bee4ef8e75f95dccd32325c15/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp#L718-L721 > > I'm done for this week, but could someone try if changing

[Lldb-commits] [lldb] [lldb] Fix dynamic type resolutions for core files (PR #138698)

2025-05-07 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Btw I think this is causing an asan failure: https://green.lab.llvm.org/job/lldb-cmake-sanitized/1671/ ``` 2025-05-07T19:03:57.557Z] ==73219==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0001070cf5b8 at pc 0x0001056051c0 bp 0x00016b0a3730 sp 0x00016b0a2ee0

[Lldb-commits] [lldb] a123891 - Revert "Branch island with numbers (#138781)"

2025-05-06 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-05-06T18:20:25-07:00 New Revision: a1238911f43c1d46cc7d4e72e2a16c3c9a157d9a URL: https://github.com/llvm/llvm-project/commit/a1238911f43c1d46cc7d4e72e2a16c3c9a157d9a DIFF: https://github.com/llvm/llvm-project/commit/a1238911f43c1d46cc7d4e72e2a16c3c9

[Lldb-commits] [lldb] 2cae14f - Revert "[lldb] Change synthetic symbol names to have file address (#137512)"

2025-05-01 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-05-01T18:27:34-07:00 New Revision: 2cae14fdc62a07252ad1c2c2b11678c4539416a6 URL: https://github.com/llvm/llvm-project/commit/2cae14fdc62a07252ad1c2c2b11678c4539416a6 DIFF: https://github.com/llvm/llvm-project/commit/2cae14fdc62a07252ad1c2c2b11678c45

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #137512)

2025-05-01 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I'm going to revert this for now, as I see your commit access is still pending (hopefully soon!) https://github.com/llvm/llvm-project/pull/137512 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #137512)

2025-05-01 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: @eronnen I believe this is breaking the macOS bots, on the test TestFoundationDisassembly.py ``` 17:54:59 FAIL: test_foundation_disasm (TestFoundationDisassembly.FoundationDisassembleTestCase) 17:54:59 Do 'disassemble -n func' on each and every 'Code' symbol entry f

[Lldb-commits] [lldb] f784fa7 - [lldb] Disable TestExitDuringExpression on asan

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-29T12:38:51-07:00 New Revision: f784fa727543463b86511f7e5797174422cbeeaf URL: https://github.com/llvm/llvm-project/commit/f784fa727543463b86511f7e5797174422cbeeaf DIFF: https://github.com/llvm/llvm-project/commit/f784fa727543463b86511f7e579717442

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Could you please disable/revert if the fix is not easy? https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Hi, this test is _still_ failing on the macOS bots: https://ci.swift.org/view/all/job/llvm.org/job/lldb-cmake/11728/execution/node/111/log/ ``` /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/lldb-build/tools/lldb/unittests/Host/./HostTests --gtest_filter=HostTest.G

[Lldb-commits] [lldb] 55b4e5e - [lldb] Disable TestDAP_attach

2025-04-29 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-29T07:18:22-07:00 New Revision: 55b4e5e5154550ba981af08ca9bd1e3da00e6fea URL: https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da00e6fea DIFF: https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da

[Lldb-commits] [lldb] [lldb] Provide an unconditional @skip annotation for API tests (PR #137712)

2025-04-28 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. Nice! https://github.com/llvm/llvm-project/pull/137712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b73169a - [lldb] Disable TestDAP_attachByPortNum

2025-04-28 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-28T14:08:14-07:00 New Revision: b73169ad3edc56fe2b4f5bd3d5259310168da50c URL: https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d5259310168da50c DIFF: https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d52593101

[Lldb-commits] [lldb] [lldb][nfc] Split the constructor of ThreadPlanStepOut (PR #136160)

2025-04-18 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-04-18 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Closing in favor of the stack of patches here: [[lldb][nfc] Factor out code from ThreadPlanStepOut ctor #136159](https://github.com/llvm/llvm-project/pull/136159) [[lldb][nfc] Split the constructor of ThreadPlanStepOut #136160](https://github.com/llvm/llvm-project/pull/13

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Remove unused parameters in ThreadPlanStepOut ctor (PR #136161)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Addressed review comments, rebased on top of main https://github.com/llvm/llvm-project/pull/136163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/136163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/136163 >From d1f15f7a23b75d7b68989ac84b1c4b5991fb120d Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 17 Apr 2025 09:36:22 -0700 Subject: [PATCH 1/2] [lldb] Create ThreadPlanStepOut ctor tha

[Lldb-commits] [lldb] [lldb][nfc] Remove unused parameters in ThreadPlanStepOut ctor (PR #136161)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/136161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Split the constructor of ThreadPlanStepOut (PR #136160)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/136160 >From 42850d46b705c239b099be8d102a3756a8fd5283 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Tue, 15 Apr 2025 10:20:41 -0700 Subject: [PATCH 1/3] [lldb][nfc] Factor out code from ThreadP

[Lldb-commits] [lldb] [lldb][nfc] Split the constructor of ThreadPlanStepOut (PR #136160)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/136160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (PR #136159)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (PR #136159)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/136159 A future patch will need to create a new constructor for this class, and extracting code out of its sole existing constructor will make this easier. This commit creates a helper function for the code com

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Closing in favor of the stack: [[lldb][nfc] Factor out code from ThreadPlanStepOut ctor #136159](https://github.com/llvm/llvm-project/pull/136159) [[lldb][nfc] Split the constructor of ThreadPlanStepOut #136160](https://github.com/llvm/llvm-project/pull/136160) [[lldb][nfc

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/131800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > > That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe > > it's not working? > > There is only one constructor for step out, and it always skips those frames. > So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over > frames. In

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe it's > not working? There is only one constructor for step out, and it always skips those frames. So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over frames. https://github.

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > The `frame_idx` parameter is the frame you step out to. I don't think this is quite true, that parameter indicates where we step out _from_. I know this distinction may look unimportant at first, but it is exactly that distinction that gives the constructor space to ski

[Lldb-commits] [lldb] [DRAFT][lldb] Upgrade CompilerType::GetIndexOfFieldWithName to return llvm::Expected (PR #135963)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: It's worth mentioning that the LLVM convention (as opposed to what is done in the swift fork) is to avoid force-pushing. Instead, you'd always add a new fixup commit (`git commit --fixup`) and squash them when merging (note that, for llvm, github will force you into squas

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: >then it would queue up a ThreadPlanStepOut that would go to that frame. To elaborate on this, today there is no constructor for StepOut that allows one to specify a target frame. This is also something we would need to create for that to work, right? https://github.com

[Lldb-commits] [lldb] [lldb][nfc] Remove redundant check in if statement (PR #135869)

2025-04-16 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135869 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-15 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/135866 >From 3804a622a92ed541e4ee1a40298442e78b687507 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Tue, 15 Apr 2025 10:20:41 -0700 Subject: [PATCH] [lldb][nfc] Add customization flags for Thre

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-15 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/135866 ThreadPlanStepOut always skips over Hidden/Artificial frames when computing its destination frame, without providing any customization of this behavior. This is problematic for some plans like StepThroug

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/135637 This is necessary so that LLDB does not select (or show the stop reason for) a thread which stopped at an internal breakpoint. Other than manual testing/inspection, which I've done, this does not seem to

[Lldb-commits] [lldb] [lldb] Override Should{Select, Show} in StopReasonBreakpoint (PR #135637)

2025-04-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/135637 >From 0383630d48f60cf25d241deda909737869b65998 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 14 Apr 2025 08:56:55 -0700 Subject: [PATCH] [lldb] Override Should{Select,Show} in StopR

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-11 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/135296 >From b24dc5da70443eb15819c6134ddd38c84f86a5e5 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 9 Apr 2025 07:38:13 -0700 Subject: [PATCH] Reland "[lldb] Clear thread-creation breakpoi

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/135296 This reapplies commit 232525f06942adb3b9977632e38dcd5f08c0642d. The original commit triggered a sanitizer failure when Target was destroyed. In Target::Destroy, `DeleteCurrentProcess` was called, but i

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #134757)

2025-04-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/134757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-04-05 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Based on the 2013 commit that added those, I don't think there is a clean way of testing this. That said, since these methods simply forward to the underlying register context, I think it's ok to rely on the lack of regression from the OS plugin tests https://github.com/

[Lldb-commits] [lldb] [lldb][debugserver] remove g/G packet handling from debugserver (PR #132127)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/132127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134469 The UpdateRegisterContext method can be called from multiple threads. >From ef59ad0f6522e5ca35cfeed562fc528b4732fb22 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 4 Apr 2025 18:28:

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/134469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/134160 >From 48150d4bb0daf57b708f4fa86285f028eeff0da6 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 2 Apr 2025 09:28:56 -0700 Subject: [PATCH 1/2] [lldb][NFC] Move ShouldShow/ShouldSelect

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/134397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/134397 >From e7689b631d898e4f2a6f2cff6e60c1a05a65c7ea Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 4 Apr 2025 07:56:38 -0700 Subject: [PATCH] [lldb] Clear thread-creation breakpoints in

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134397 Currently, these breakpoints are being accumulated every time a new process if created (e.g. through a `run`). Depending on the circumstances, the old breakpoints are even left enabled, interfering with

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/134397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-03 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/134160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-03 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/134160 >From 48150d4bb0daf57b708f4fa86285f028eeff0da6 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 2 Apr 2025 09:28:56 -0700 Subject: [PATCH 1/3] [lldb][NFC] Move ShouldShow/ShouldSelect

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Addressed review comments https://github.com/llvm/llvm-project/pull/134160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134160 This NFC patch simplifies the main loop in HandleProcessStateChanged event by moving duplicated code into the StopInfo class, also allowing StopInfo subclasses to override behavior. More specifically, t

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: This type of patch also slightly worries me in that it could make it harder to unify the LLDB dwarf data structures with the LLVM ones https://github.com/llvm/llvm-project/pull/131645 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Should this also change the interface of DWAFExpressionList? ``` DWARFExpressionList(lldb::ModuleSP module_sp, const plugin::dwarf::DWARFUnit *dwarf_cu, lldb::addr_t func_file_addr) : m_module_wp(module_sp), m_dwarf_cu(dwa

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: In order to preserve the two separate commits (and not squash them) I've merged this into two separate PRs: https://github.com/llvm/llvm-project/pull/132905 https://github.com/llvm/llvm-project/pull/132906 So I'll close this now. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Implement missing queue overloads from ThreadMemory (PR #132906)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/132906 This commit makes ThreadMemory a real "forwarder" class by implementing the missing queue methods: they will just call the corresponding backing thread method. To make this patch NFC(*) and not change t

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/132734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement missing queue overloads from ThreadMemory (PR #132906)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/132906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement missing queue overloads from ThreadMemory (PR #132906)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: This was reviewed and approved in https://github.com/llvm/llvm-project/pull/132734 But, in order to preserve the small commits, I'm merging through separate PRs. https://github.com/llvm/llvm-project/pull/132906 ___ lldb-commits m

[Lldb-commits] [lldb] [lldb][NFC] Break ThreadMemory into smaller abstractions (PR #132905)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/132905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Break ThreadMemory into smaller abstractions (PR #132905)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: This was reviewed and approved in https://github.com/llvm/llvm-project/pull/132734 But, in order to preserve the small commits, I'm merging through separate PRs. https://github.com/llvm/llvm-project/pull/132905 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Break ThreadMemory into smaller abstractions (PR #132905)

2025-03-25 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/132905 ThreadMemory attempts to be a class abstracting the notion of a "fake" Thread that is backed by a "real" thread. According to its documentation, it is meant to be a class forwarding most methods to the b

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

2025-03-24 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/132734 Please read the two commit messages individually. >From 00da78461321b019303ddffcec5620859829cd40 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 20 Mar 2025 14:59:33 -0300 Subject: [

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > oh, that regression test will need to be added to the swiftlang cherrypick. Nice! I've added it to that PR. https://github.com/llvm/llvm-project/pull/132079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/132079 These allow for more efficient saving/restoring state after an expression is evaluated. >From e619ec8d09fec2e0567ad6194f60968e89e40627 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-03-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/131800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-12 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/129937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/129937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan deleted https://github.com/llvm/llvm-project/pull/129937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -354,14 +354,13 @@ class Language : public PluginInterface { virtual llvm::StringRef GetInstanceVariableName() { return {}; } - /// Returns true if this SymbolContext should be ignored when setting - /// breakpoints by line (number or regex). Helpful for languages that

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -354,14 +354,13 @@ class Language : public PluginInterface { virtual llvm::StringRef GetInstanceVariableName() { return {}; } - /// Returns true if this SymbolContext should be ignored when setting - /// breakpoints by line (number or regex). Helpful for languages that

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -207,16 +207,15 @@ bool operator<(const SourceLoc lhs, const SourceLoc rhs) { void BreakpointResolver::SetSCMatchesByLine( SearchFilter &filter, SymbolContextList &sc_list, bool skip_prologue, llvm::StringRef log_ident, uint32_t line, std::optional column) { - llvm:

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/129937 This allows languages to make decisions based on the whole set of symbol contexts, giving them strictly more power than when they are only allowed to see one at a time. >From 3d6a826964326a408b8e3a9d79c

[Lldb-commits] [lldb] [lldb] Add ability to inspect backing threads with `thread info` (PR #129275)

2025-02-28 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/129275 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to inspect backing threads with `thread info` (PR #129275)

2025-02-28 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/129275 >From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 28 Feb 2025 09:11:11 -0800 Subject: [PATCH 1/4] [lldb] Add ability to inspect backing th

[Lldb-commits] [lldb] [lldb] Add ability to inspect backing threads with `thread info` (PR #129275)

2025-02-28 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Linux bots seem to print the TID using decimal numbers, so I updated the regex. https://github.com/llvm/llvm-project/pull/129275 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] Add ability to inspect backing threads with `thread info` (PR #129275)

2025-02-28 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/129275 >From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 28 Feb 2025 09:11:11 -0800 Subject: [PATCH 1/3] [lldb] Add ability to inspect backing th

  1   2   3   4   5   6   >