https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132906
This commit makes ThreadMemory a real "forwarder" class by implementing the
missing queue methods: they will just call the corresponding backing thread
method.
To make this patch NFC(*) and not change the behavior of the Python OS plugin,
NamedThreadMemoryWithQueue also overrides these methods to simply call the
`Thread` method, just as it was doing before. This also makes it obvious that
there are missing pieces of this class if it were to provide full queue support.
(*) This patch is NFC in the sense that all llvm.org plugins will not have any
behavior change, but downstream consumers of ThreadMemory will benefit from the
newly implemented forwarding methods.
>From 4242173b75c1a55ade1ab020d1a11cc7e54580b4 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan <fpiove...@apple.com>
Date: Fri, 21 Mar 2025 14:59:05 -0300
Subject: [PATCH] [lldb] Implement missing queue overloads from ThreadMemory
This commit makes ThreadMemory a real "forwarder" class by implementing
the missing queue methods: they will just call the corresponding backing
thread method.
To make this patch NFC(*) and not change the behavior of the Python OS
plugin, NamedThreadMemoryWithQueue also overrides these methods to
simply call the `Thread` method, just as it was doing before. This also
makes it obvious that there are missing pieces of this class if it were
to provide full queue support.
(*) This patch is NFC in the sense that all llvm.org plugins will not have
any behavior change, but downstream consumers of ThreadMemory will
benefit from the newly implemented forwarding methods.
---
.../Plugins/Process/Utility/ThreadMemory.h | 112 ++++++++++++++++++
1 file changed, 112 insertions(+)
diff --git a/lldb/source/Plugins/Process/Utility/ThreadMemory.h
b/lldb/source/Plugins/Process/Utility/ThreadMemory.h
index 7cabde202518e..f47bbd8848436 100644
--- a/lldb/source/Plugins/Process/Utility/ThreadMemory.h
+++ b/lldb/source/Plugins/Process/Utility/ThreadMemory.h
@@ -53,6 +53,69 @@ class ThreadMemory : public lldb_private::Thread {
void WillResume(lldb::StateType resume_state) override;
+ void SetQueueName(const char *name) override {
+ if (m_backing_thread_sp)
+ m_backing_thread_sp->SetQueueName(name);
+ }
+
+ lldb::queue_id_t GetQueueID() override {
+ if (m_backing_thread_sp)
+ return m_backing_thread_sp->GetQueueID();
+ return LLDB_INVALID_QUEUE_ID;
+ }
+
+ void SetQueueID(lldb::queue_id_t new_val) override {
+ if (m_backing_thread_sp)
+ m_backing_thread_sp->SetQueueID(new_val);
+ }
+
+ lldb::QueueKind GetQueueKind() override {
+ if (m_backing_thread_sp)
+ return m_backing_thread_sp->GetQueueKind();
+ return lldb::eQueueKindUnknown;
+ }
+
+ void SetQueueKind(lldb::QueueKind kind) override {
+ if (m_backing_thread_sp)
+ m_backing_thread_sp->SetQueueKind(kind);
+ }
+
+ lldb::QueueSP GetQueue() override {
+ if (m_backing_thread_sp)
+ return m_backing_thread_sp->GetQueue();
+ return lldb::QueueSP();
+ }
+
+ lldb::addr_t GetQueueLibdispatchQueueAddress() override {
+ if (m_backing_thread_sp)
+ return m_backing_thread_sp->GetQueueLibdispatchQueueAddress();
+ return LLDB_INVALID_ADDRESS;
+ }
+
+ void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) override
{
+ if (m_backing_thread_sp)
+ m_backing_thread_sp->SetQueueLibdispatchQueueAddress(dispatch_queue_t);
+ }
+
+ lldb_private::LazyBool GetAssociatedWithLibdispatchQueue() override {
+ if (m_backing_thread_sp)
+ return m_backing_thread_sp->GetAssociatedWithLibdispatchQueue();
+ return lldb_private::eLazyBoolNo;
+ }
+
+ void SetAssociatedWithLibdispatchQueue(
+ lldb_private::LazyBool associated_with_libdispatch_queue) override {
+ if (m_backing_thread_sp)
+ m_backing_thread_sp->SetAssociatedWithLibdispatchQueue(
+ associated_with_libdispatch_queue);
+ }
+
+ bool ThreadHasQueueInformation() const override {
+ if (m_backing_thread_sp)
+ return m_backing_thread_sp->ThreadHasQueueInformation();
+ return false;
+ }
+
void DidResume() override {
if (m_backing_thread_sp)
m_backing_thread_sp->DidResume();
@@ -134,6 +197,55 @@ class ThreadMemoryProvidingNameAndQueue : public
ThreadMemoryProvidingName {
return ThreadMemory::GetQueueName();
}
+ /// TODO: this method should take into account the queue override.
+ void SetQueueName(const char *name) override { Thread::SetQueueName(name); }
+
+ /// TODO: this method should take into account the queue override.
+ lldb::queue_id_t GetQueueID() override { return Thread::GetQueueID(); }
+
+ /// TODO: this method should take into account the queue override.
+ void SetQueueID(lldb::queue_id_t new_val) override {
+ Thread::SetQueueID(new_val);
+ }
+
+ /// TODO: this method should take into account the queue override.
+ lldb::QueueKind GetQueueKind() override { return Thread::GetQueueKind(); }
+
+ /// TODO: this method should take into account the queue override.
+ void SetQueueKind(lldb::QueueKind kind) override {
+ Thread::SetQueueKind(kind);
+ }
+
+ /// TODO: this method should take into account the queue override.
+ lldb::QueueSP GetQueue() override { return Thread::GetQueue(); }
+
+ /// TODO: this method should take into account the queue override.
+ lldb::addr_t GetQueueLibdispatchQueueAddress() override {
+ return Thread::GetQueueLibdispatchQueueAddress();
+ }
+
+ /// TODO: this method should take into account the queue override.
+ void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) override
{
+ Thread::SetQueueLibdispatchQueueAddress(dispatch_queue_t);
+ }
+
+ /// TODO: this method should take into account the queue override.
+ bool ThreadHasQueueInformation() const override {
+ return Thread::ThreadHasQueueInformation();
+ }
+
+ /// TODO: this method should take into account the queue override.
+ lldb_private::LazyBool GetAssociatedWithLibdispatchQueue() override {
+ return Thread::GetAssociatedWithLibdispatchQueue();
+ }
+
+ /// TODO: this method should take into account the queue override.
+ void SetAssociatedWithLibdispatchQueue(
+ lldb_private::LazyBool associated_with_libdispatch_queue) override {
+ Thread::SetAssociatedWithLibdispatchQueue(
+ associated_with_libdispatch_queue);
+ }
+
lldb::ValueObjectSP &GetValueObject() { return m_thread_info_valobj_sp; }
protected:
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
