Eugene.Zelenko added inline comments.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:10
#include "ProcessMinidump.h"
+
#include "ThreadMinidump.h"
Spurious separator.
Comment at: lldb/source/Plugins/Process/minidump/Thre
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBTypeEnumMember.cpp:78
TypeEnumMemberImpl &SBTypeEnumMember::ref() {
if (m_opaque_sp.get() == NULL)
+m_opaque_sp = std::make_shared();
tatyana-krasnukha wrote:
> ```
> if (!m_opaque_sp)
>
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
JDevlieghere wrote:
> Eugene.Zelenko wrote:
> > JDevlieghere wrote:
> > > jingham wrote:
> > > > Eugene.Zelenko wrote:
> > > > > Spaces betw
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
JDevlieghere wrote:
> jingham wrote:
> > Eugene.Zelenko wrote:
> > > Spaces between include statements interfere with Clang-format. Same in
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBData.cpp:9
#include
cinttypes should be used instead. See Clang-tidy modernize-deprecated-headers.
Same in other places.
Comment at: lldb/source/API/SBData.cpp:12
+#incl
Eugene.Zelenko added a comment.
Thank you for cleanup effort!
I would suggest to also run modernize checks and at least next readability
checks:
readability-container-size-empty
readability-isolate-declaration
readability-redundant-control-flow
readability-redundant-member-init
readability-redu
Eugene.Zelenko added inline comments.
Comment at: include/lldb/Host/MainLoop.h:16
#include "llvm/ADT/DenseMap.h"
+#include
I think will be good idea to include csignal instead. Same in other files. See
http://clang.llvm.org/extra/clang-tidy/checks/modernize-
