[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

[Eugene Zelenko via Phabricator via lldb-commits]

Eugene.Zelenko added inline comments.


================
Comment at: lldb/source/API/SBTypeEnumMember.cpp:78
 TypeEnumMemberImpl &SBTypeEnumMember::ref() {
   if (m_opaque_sp.get() == NULL)
+    m_opaque_sp = std::make_shared<TypeEnumMemberImpl>();
----------------
tatyana-krasnukha wrote:
> ```
> if (!m_opaque_sp)
> ```
Will be good idea to run Clang-tidy readability-redundant-smartptr-get.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57990/new/

https://reviews.llvm.org/D57990



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits