[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-24 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: On the Android Studio side, we don't run tests on old API levels. We only run automated on latest API levels (and some best-effort manual tests on recent-ish API levels). Different features in Android Studio have different min-API requirements. To me, it seems OK to add "A

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-10 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: LGTM. Thanks. https://github.com/llvm/llvm-project/pull/111237 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-09 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: > With this in mind, deleting the file is representative of an editor wanting > to save the file using the deletion strategy,... Yes. I had meant it is not representative of what Android Studio (or _some_ editors) does. > think it's not our goal here to ensure the editor

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-08 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: OK, I figured the problem. In the test, we call `os.removeFile()` which does not actually represent the real end-user use-case (which is to edit the file and save it). Empirically, on Windows 11, I can verify that when LLDB mmaps these large files, then: 1. I can appen

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-07 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: > it failed in this case because the source file is opened with the > `FILE_SHARE_DELETE` share mode, which allows the file to be removed, see > `llvm::sys::fs::openNativeFileInternal()` in > `llvm/lib/Support/Windows/Path.inc`. Was there an LLDB change about how it open

[Lldb-commits] [PATCH] Fix parsing of IPv6 host:port inside brackets

2020-03-24 Thread Emre Kultursay via lldb-commits
0001-Fix-parsing-of-IPv6-host-port-inside-brackets.patch Description: Binary data ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits