[Lldb-commits] [lldb] r325452 - Add DEBUGSERVER_PATH to the cache so it'll be available for tests.

2018-02-17 Thread Don Hinton via lldb-commits
Author: dhinton Date: Sat Feb 17 15:06:15 2018 New Revision: 325452 URL: http://llvm.org/viewvc/llvm-project?rev=325452&view=rev Log: Add DEBUGSERVER_PATH to the cache so it'll be available for tests. This fixed a problem caused by r325442. Differential Revision: https://reviews.llvm.org/D43432

[Lldb-commits] [lldb] r325442 - [cmake] Fix LLDB_CODESIGN_IDENTITY logic.

2018-02-17 Thread Don Hinton via lldb-commits
Author: dhinton Date: Sat Feb 17 11:17:21 2018 New Revision: 325442 URL: http://llvm.org/viewvc/llvm-project?rev=325442&view=rev Log: [cmake] Fix LLDB_CODESIGN_IDENTITY logic. Summary: Consolidate LLDB_CODESIGN_IDENTITY logic in one place and use SKIP_DEBUGSERVER, which can be set independently,

[Lldb-commits] [lldb] r318164 - Add check for self-assignment. NFC

2017-11-14 Thread Don Hinton via lldb-commits
Author: dhinton Date: Tue Nov 14 10:19:41 2017 New Revision: 318164 URL: http://llvm.org/viewvc/llvm-project?rev=318164&view=rev Log: Add check for self-assignment. NFC Differential Revision: https://reviews.llvm.org/D39578 Modified: lldb/trunk/source/Core/RegisterValue.cpp lldb/trunk/s

[Lldb-commits] [lldb] r317327 - Add type to FileSpec::PathSyntax enum.

2017-11-03 Thread Don Hinton via lldb-commits
Author: dhinton Date: Fri Nov 3 07:59:36 2017 New Revision: 317327 URL: http://llvm.org/viewvc/llvm-project?rev=317327&view=rev Log: Add type to FileSpec::PathSyntax enum. Summary: Add type to FileSpec::PathSyntax enum to decrease size for FileSpec on systems with 32 bit pointers. Thanks to @zt

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

2017-10-31 Thread Don Hinton via lldb-commits
Btw, is there a way to pass the '-m' option via the SB API? I'd like to exclude matches in comments when using BreakpointCreateBySourceRegex. On Tue, Oct 31, 2017 at 8:26 AM, Don Hinton wrote: > On Tue, Oct 31, 2017 at 8:22 AM, Zachary Turner > wrote: > >> >> >> On Tue, Oct 31, 2017 at 8:12 AM

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

2017-10-31 Thread Don Hinton via lldb-commits
On Tue, Oct 31, 2017 at 8:22 AM, Zachary Turner wrote: > > > On Tue, Oct 31, 2017 at 8:12 AM Don Hinton wrote: > >> There have been a few suggestions that I could just use a script to solve >> this "problem" -- poor startup performance of clangdiag. >> >> However, this patch was not submitted to

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

2017-10-31 Thread Don Hinton via lldb-commits
There have been a few suggestions that I could just use a script to solve this "problem" -- poor startup performance of clangdiag. However, this patch was not submitted to solve a particular problem. It was submitted in response to Jim's suggestion: On Mon, Oct 23, 2017 at 6:25 PM, Jim Ingham w

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

2017-10-30 Thread Don Hinton via lldb-commits
I'll add tests if it looks like it'll be accepted, but based on the initial response, that doesn't seem likely. However, it was a good exercise and addressed the issues raised. thanks again for all the feedback... don On Mon, Oct 30, 2017 at 9:44 PM, Zachary Turner wrote: > Asking again, but w

Re: [Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

2017-10-26 Thread Don Hinton via lldb-commits
On Thu, Oct 26, 2017 at 5:44 PM, Zachary Turner wrote: > > > On Thu, Oct 26, 2017 at 3:18 PM Don Hinton wrote: > >> On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner >> wrote: >> >>> Seems fine, it would be nice if the workflow could be improved a little >>> bit so that all you have to do is say

Re: [Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

2017-10-26 Thread Don Hinton via lldb-commits
On Thu, Oct 26, 2017 at 2:48 PM, Zachary Turner wrote: > Seems fine, it would be nice if the workflow could be improved a little > bit so that all you have to do is say `clangdiag break > —error=“-Wcovered-switch”` or something . I think that gives the most > intuitive usage for people, even it’s

Re: [Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

2017-10-26 Thread Don Hinton via lldb-commits
On Thu, Oct 26, 2017 at 3:00 PM, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > Each lldb.SBValue has accessors for the stuff in an execution context: > > `` > > lldb::SBTarget GetTarget(); > lldb::SBProcess GetProcess(); > lldb::SBThread GetT