[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

This revision was automatically updated to reflect the committed changes. Closed by commit rG98c3dc3fa748: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines (authored by dstenb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14255

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

dstenb added a comment. In D142552#4083939 , @clayborg wrote: > As long as there are no regressions in the test suite this looks good to me Thanks, and sorry for the delay with landing this! I have ran check-lldb. I will land this shortly. Repository:

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

dstenb added a comment. First time looking at LLDB, so I had trouble finding a suitable way to create a reproducer for this. I would be happy to change to another type of lit test if that is more suitable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

dstenb created this revision. dstenb added reviewers: jasonmolenda, clayborg, aeubanks, ayermolo. dstenb added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. dstenb requested review of this revision. Herald added a reviewer: j

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1918940 , @dstenb wrote: > In D73534#1918890 , @manojgupta > wrote: > > > Hi, > > > > I see another crash with this change when building gdb. > > > > Reduced test case: > > struct

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1918890 , @manojgupta wrote: > Hi, > > I see another crash with this change when building gdb. > > Reduced test case: > struct type *a(type *, type *, long, long); > enum b {}; > static int empty_array(type *, int c) {

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1881353 , @nickdesaulniers wrote: > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > this change. I see it's been reverted (thank you). Please cc me on the > updated patch and I can help tes

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1882127 , @djtodoro wrote: > @dstenb No problem, we have already addressed the issue. Thanks to @vsk and > @nickdesaulniers! I'll update the patch. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Options.SupportsDebugEntryValues) MF.addCall

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Options.SupportsDebugEntryValues) MF.addCall