[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

zrthxn added a comment. I've tried most of these changes to see the effect it has, but in my opinion this adds quite a lot of code complexity for not enough benefit in terms of memory usage which was our goal. I think this will make the DecodedThread even more of a monolith class with single-us

[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

zrthxn added a comment. Example of improvement in memory usage thread #1: tid = 42805 Raw trace size: 4096 KiB Total number of instructions: 94 Total approximate memory usage: 4394.58 KiB Average memory usage per instruction: 5.00 bytes where previously the same trace took

[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Grouping instructions with the same high 48 bits and storing prefixes. Simple looku

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd849959071c8: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread` (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn updated this revision to Diff 420543. zrthxn marked an inline comment as done. zrthxn added a comment. Removed unnecessary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991 Files: lldb/sour

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn updated this revision to Diff 420401. zrthxn marked 12 inline comments as done. zrthxn added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn updated this revision to Diff 420256. zrthxn added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp lldb/sour

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn updated this revision to Diff 420245. zrthxn added a comment. Change in memory use is appreciable. thread #1: tid = 40371 Raw trace size: 4 KiB Total number of instructions: 145011 Total approximate memory usage: 1840.96 KiB Average memory usage per instruction: 13.00 byt

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn created this revision. zrthxn added a reviewer: wallace. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is to reduce the size of the trace further and has appreciable results. Repository:

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

This revision was automatically updated to reflect the committed changes. Closed by commit rGca922a3559d7: [intelpt] Refactor timestamps out of `IntelPTInstruction` (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ http

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419656. zrthxn edited the summary of this revision. zrthxn added a comment. The difference in memory usage is appreciable with large number of instructions, as shown below # Before (with current metrics, total memory does not include raw trace size) Raw

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:145 + private: +friend class DecodedThread; + wallace wrote: > jj10306 wrote: > > nit: No need to friend the enclosing class since C++11 - > > https://en.cppreferen

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419619. zrthxn marked 3 inline comments as done. zrthxn added a comment. Dont use auto for simple types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/s

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:67-82 switch (origin) { case TraceCursor::SeekType::Set: m_pos = fitPosToBounds(offset); +m_current_tsc = m_decoded_thread_sp->CalculateTscRange(m_pos); return

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419560. zrthxn marked 12 inline comments as done. zrthxn added a comment. Incorporate feedback and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files:

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419519. zrthxn added a comment. Updated tests according to new memory usage calculation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins/Tr

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419517. zrthxn marked an inline comment as done. zrthxn added a comment. Fixed issue with TSC becoming invalid midway through trace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419348. zrthxn added a comment. Change tsc check anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:45-52 +if (!m_current_tsc) + m_current_tsc = m_decoded_thread_sp->CalculateTscRange(m_pos); +else if (!m_current_tsc->InRange(m_pos)) { + if (m_pos > m_current_ts

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419347. zrthxn marked 23 inline comments as done. zrthxn added a comment. Included requested changes, removed extra members Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 418981. zrthxn added a comment. Prevent crash on printing info when we have 0 instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 418977. zrthxn added a comment. Update memory calc function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.c

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 418975. zrthxn marked 7 inline comments as done. zrthxn retitled this revision from "[wip][intelpt] Refactor timestamps out of `IntelPTInstruction`" to "[intelpt] Refactor timestamps out of IntelPTInstruction". zrthxn added a comment. Change TscRange to class

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

zrthxn updated this revision to Diff 418937. zrthxn marked 12 inline comments as done. zrthxn added a comment. Introduced TscRange for quicker operation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Fil

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

zrthxn updated this revision to Diff 418660. zrthxn added a comment. Update cursor timestamp when we have a new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins/Trace/intel

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122603 Files: ll

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418376. zrthxn added a comment. Clean up and finalize Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp l

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn marked an inline comment as done. zrthxn added a comment. Test program info, (llvm-project/lldb/test/API/commands/trace/intelpt-trace/a.out) (lldb) thread trace dump info Trace technology: intel-pt thread #1: tid = 3842849 Raw trace size: 4 KiB Total number of instruction

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn marked 13 inline comments as done. zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:25 IntelPTError::IntelPTError(int libipt_error_code, lldb::addr_t address) : m_libipt_error_code(libipt_error_code), m_address(address) {

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418327. zrthxn added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp lldb/sour

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:77 bool TraceCursorIntelPT::IsError() { return m_decoded_thread_sp->GetInstructions()[m_pos].IsError(); } jj10306 wrote: > nit: should we update this to use t

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418309. zrthxn added a comment. Added average memory per instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/Decode

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418306. zrthxn added a comment. Finalize diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp lldb/sour

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418299. zrthxn added a comment. Incoporate more feedback, Only parameter pack isnt done yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn marked 15 inline comments as done. zrthxn added a comment. Before refactor thread #1: tid = 37275 Raw trace size: 4 KiB Total number of instructions: 21 Total approximate memory usage: 5.38 KiB After refactor (lldb) thread trace dump info Trace technology: intel-pt

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418249. zrthxn added a comment. Refactor to use more templates and param packs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel

[Lldb-commits] [PATCH] D122293: [intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418154. zrthxn added a comment. Resolved many runtime errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 418000. zrthxn added a comment. Incorporate other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cp

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 417969. zrthxn added a comment. Error gettting method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp l

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 417832. zrthxn added a comment. A few changes to remove redundant things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/De

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn marked 8 inline comments as done. zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:149 +thread.AppendError(insn_index, make_error(time_error, insn.ip)); +thread.AppendInstruction(IntelPTInstruction(insn));

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:152 + /// The errors of the trace. + std::unordered_map GetErrors() const; + jj10306 wrote: > Return a reference here to avoid potential expensive copy when returning

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:172 std::vector m_instructions; + std::vector m_errors; + jj10306 wrote: > wallace wrote: > > you need to have something like > > std::unordered_map m_errors; > >

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 417709. zrthxn added a comment. Introduced unordered map for errors in DecodedThread Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Refactored (but not yet tested) version of the instruction decoding code Repositor

[Lldb-commits] [PATCH] D122114: [tests][intelpt] Fix outdated trace load test

This revision was automatically updated to reflect the committed changes. Closed by commit rGca47011e73e6: [tests][intelpt] Fix outdated trace load test (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122114/new/ https://reviews.

[Lldb-commits] [PATCH] D122114: [tests][intelpt] Fix outdated trace load test

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122114 Files: ll

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

This revision was automatically updated to reflect the committed changes. Closed by commit rG37a466dd72b0: [trace][intelpt] Added total memory usage by decoded trace (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ htt

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416826. zrthxn added a comment. Ingore errored instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.c

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416825. zrthxn marked an inline comment as done. zrthxn added a comment. Cosmetic and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files: lldb/sourc

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn marked 4 inline comments as done. zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:119 + s.Printf(" Total approximate memory usage: %0.2lf KiB\n", + (float)mem_used / 1024); return; wallace wrote:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416797. zrthxn added a comment. Changed to KiB and fixed how caclulation is done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files: lldb/source/Plugins/Trace/int

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416765. zrthxn added a comment. Fixed trace info test for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThrea

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416764. zrthxn added a comment. Clean up, works fine now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fails currently but the basics are there Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

This revision was automatically updated to reflect the committed changes. Closed by commit rG8271220a9981: [trace][intelpt] Instruction count in trace info (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://revie

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

zrthxn updated this revision to Diff 416756. zrthxn added a comment. Using arrow op and made it inline. I think creating a variable looks a bit better but this is fine too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://reviews.

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

zrthxn updated this revision to Diff 416736. zrthxn added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://reviews.llvm.org/D122076 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/te

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

zrthxn created this revision. zrthxn added a reviewer: wallace. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added a line to `thread trace dump info` results which shows total number of instructions e

[Lldb-commits] [PATCH] D122073: [docs] Fixed minor ordering issue

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bcc28b884ff: [docs] Fixed minor ordering issue (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122073/new/ https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D122073: [docs] Fixed minor ordering issue

zrthxn created this revision. zrthxn added a reviewer: wallace. Herald added a subscriber: arphaman. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416532. zrthxn added a comment. Reflow to 80 cols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/docs/index.rst lldb/docs/use/intel_pt.rst Index: lld

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn added a comment. Here is the screenshot as well as the HTML file The screenshot doesn't have the CSS theming... F22478403: _home_alisamar_Desktop_lldb-build_tools_lldb_docs_html_use_intel_pt.html.png F22478406: intel_pt.html

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416506. zrthxn added a comment. Herald added a subscriber: arphaman. Referenced IPT doc from main page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/do

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416287. zrthxn added a comment. Switched to RST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/docs/intel_pt.rst Index: lldb/docs/intel_pt.rst

[Lldb-commits] [PATCH] D121942: Switched to RST

zrthxn created this revision. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121942 Files: lldb/docs/intel_pt.rst lldb/source/Plugins

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn added a comment. In D121935#3389954 , @JDevlieghere wrote: > Can we include this in the `docs` folder instead? Having READMEs spread > throughout the sources isn't going to be particularly discoverable. Sure can. Should I also use RST instead of

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn created this revision. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121935 Files: lldb/source/Plugins/Trace/intel-pt/README.md

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392308. zrthxn added a comment. Cosmetic changes and incorporate requested changes from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392305. zrthxn added a comment. Removed old/dead code and commented out sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Language/

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392197. zrthxn added a comment. Added libcxx support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt l

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn updated this revision to Diff 392154. zrthxn added a comment. Herald added a subscriber: mgorny. Squash many commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Lan

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

zrthxn created this revision. zrthxn added a reviewer: wallace. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115178 Files: lldb/source/Plugins/Language/CPlusPlus/