zrthxn added inline comments.
================ Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:145 + private: + friend class DecodedThread; + ---------------- wallace wrote: > jj10306 wrote: > > nit: No need to friend the enclosing class since C++11 - > > https://en.cppreference.com/w/cpp/language/nested_types > TIL! We need the friend because we are using a private constructor from outside, in DecodedThread::CalculateTscRange and a couple other places. The idea is to let only DecodedThread create TscRange. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
