adrian-prantl wrote:
As high-level comments:
- I would filter out the entry values, since this feature is meant to help a
user understand the disassembly, and the entry values don't really exist in the
function.
- It would help readability if all annotations started at the same column
- in a fo
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -158,6 +158,7 @@ class DWARFExpression {
}
void DumpLocation(Stream *s, lldb::DescriptionLevel level, ABI *abi) const;
+ void DumpLocationWithOptions(Stream *s, lldb::DescriptionLevel level, ABI
*abi, llvm::DIDumpOptions options) const;
adrian-prantl
@@ -53,6 +54,37 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
@@ -702,6 +705,78 @@ void Instruction::Dump(lldb_private::Stream *s, uint32_t
max_opcode_byte_size,
ss.FillLastLineToColumn(opcode_pos + opcode_column_width, ' ');
ss.PutCString(mnemonics);
+ const size_t annotation_column = 150;
+
+ if (exe_ctx && exe_ctx->GetFramePtr(
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
I pushed this manually as 0b98b27930da.
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: CodingCarpincho
Date: 2025-07-03T14:20:31-07:00
New Revision: 0b98b27930dad5ff59de050605c3f101330a2b5c
URL:
https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c
DIFF:
https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c.dif
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/146963
>From 16b7748cf38aaade5185a1073d2755abb2c40d12 Mon Sep 17 00:00:00 2001
From: CodingCarpincho
Date: Thu, 3 Jul 2025 13:54:46 -0700
Subject: [PATCH] Use the root directory as the SDK root on POSIX platforms
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase {
static llvm::VersionTuple GetOSVersion();
static std::optional GetOSBuildString();
+ static llvm::Expected GetSDKRoot(SDKOptions options);
adrian-prantl wrote:
That's existing API.
https://gi
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/146963
LLDB has the concept of an "SDK root", which expresses where the system
libraries and so which are necessary for debugging can be found. On POSIX
platforms, the SDK root is just the root of the file syste
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -860,6 +860,64 @@ ResolveLoadAddress(ExecutionContext *exe_ctx,
lldb::ModuleSP &module_sp,
return load_addr;
}
+static llvm::Error Evaluate_DW_OP_deref(DWARFExpression::Stack &stack,
+ExecutionContext *exe_ctx,
+
adrian-prantl wrote:
More test coverage sounds great!
https://github.com/llvm/llvm-project/pull/146740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146697
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
LGTM with Michael's comments addressed.
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/adrian-prantl commented:
LGTM with under/overflow checks added.
https://github.com/llvm/llvm-project/pull/144238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -53,6 +54,30 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+std::optional
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> It's not _just_ `BuiltinHeadersInSystemModules` either. There are lots of
> things that the driver toolchain does that you shouldn't be skipping.
We should definitely _also_ find a way to factor that into a function LLDB can
call.
https://github.com/llvm/llvm-project/pu
@@ -53,6 +54,29 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+llvm::Expected
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -421,6 +422,10 @@ class AppleObjCRuntimeV2 : public AppleObjCRuntime {
lldb::addr_t GetISAHashTablePointer();
+ using ValueObjectSet = llvm::SmallSet;
adrian-prantl wrote:
`llvm::SmallPtrSet`?
https://github.com/llvm/llvm-project/pull/145396
_
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/144913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1130,14 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/adrian-prantl approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
This LGTM. There is no good reason to support debugging with modules against an
older SDK, since you can't actually install one easily either.
https://github.com/llvm/llvm-project/pull/144913
__
@@ -58,6 +59,19 @@ class DWARFExpressionList {
}
lldb::addr_t GetFuncFileAddress() { return m_func_file_addr; }
+
+ /// Represents an entry in the DWARFExpressionList with all needed metadata.
+ struct DWARFExpressionEntry {
+AddressRange file_range; /// Represents
https://github.com/adrian-prantl approved this pull request.
LGTM with one comment
https://github.com/llvm/llvm-project/pull/145396
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,6 +53,27 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+llvm::Expected
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/144998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
It would be nice if these were at least unit-tested on llvm.org, but given how
trivial the implementation is, make not strictly necessary.
https://github.com/llvm/llvm-project/pull/144549
__
@@ -982,7 +982,7 @@ lldb::LanguageType
SymbolFileDWARF::ParseLanguage(CompileUnit &comp_unit) {
return eLanguageTypeUnknown;
}
-XcodeSDK SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
+XcodeSDKPath SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) {
---
@@ -0,0 +1,48 @@
+//===-- XcodeSDK.h --*- C++
-*-===//
adrian-prantl wrote:
I think I would just put this into the existing XcodeSDK.h header, since it's
so closely related.
https://github.com/llvm/llvm-project/pull/
adrian-prantl wrote:
> I'm not sure I understand the need for the separate class. What's present in
> the `XcodeSDK` class that prevents you from using it on PlatformWindows?
> Given that the current class is part of Utility, it shouldn't depend on
> anything Darwin specific. If we need to mak
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/144503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -59,6 +59,18 @@ class DWARFExpressionList {
lldb::addr_t GetFuncFileAddress() { return m_func_file_addr; }
+ /// Represents an entry in the DWARFExpressionList with all needed metadata
+ struct DWARFExpressionEntry {
+lldb::addr_t base;
+lldb::addr_t end;
-
@@ -53,6 +53,27 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+llvm::Expected
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
@@ -53,6 +53,27 @@ bool DWARFExpressionList::ContainsAddress(lldb::addr_t
func_load_addr,
return GetExpressionAtAddress(func_load_addr, addr) != nullptr;
}
+llvm::Expected
+DWARFExpressionList::GetExpressionEntryAtAddress(lldb::addr_t func_load_addr,
+
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/143930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/143860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/143860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Anyway, this is good otherwise!
https://github.com/llvm/llvm-project/pull/143686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
@@ -885,6 +885,55 @@ class CommandObjectMemoryRead : public CommandObjectParsed
{
#define LLDB_OPTIONS_memory_find
#include "CommandOptions.inc"
+static llvm::Error CopyExpressionResult(ValueObject &result,
+DataBufferHeap &buffer) {
+
adrian-prantl wrote:
As a general advice it is better to split up patches at the subproject level
because it's harder to find reviewers willing to sign off in other components.
https://github.com/llvm/llvm-project/pull/133148
___
lldb-commits mailing
@@ -11,17 +11,11 @@
class DeclFromSubmoduleTestCase(TestBase):
# Requires DWARF debug info which is not retained when linking with
link.exe.
@skipIfWindows
+# Lookup for decls in submodules fails in Linux
+@expectedFailureAll(oslist=["linux"])
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/143098
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/143098
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self):
self.run_with(
arch=self.getArchitecture(),
os="ios",
-vers="11.0",
+vers="14.0",
adrian-prantl wrote:
Apple silicon and/or macCatalyst mad
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self):
self.run_with(
arch=self.getArchitecture(),
os="ios",
-vers="11.0",
+vers="14.0",
adrian-prantl wrote:
The version 11 here is (I believe) s
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/142244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self):
self.run_with(
arch=self.getArchitecture(),
os="ios",
-vers="11.0",
+vers="14.0",
adrian-prantl wrote:
Ah, but that's the arm64 test, so th
@@ -56,11 +56,14 @@ def run_with(self, arch, os, vers, env,
expected_load_command):
sdk_root = lldbutil.get_xcode_sdk_root(sdk)
clang = lldbutil.get_xcode_clang(sdk)
+print(triple)
adrian-prantl wrote:
```suggestion
if self.Trace
@@ -1534,15 +1534,13 @@ bool Debugger::FormatDisassemblerAddress(const
FormatEntity::Entry *format,
const ExecutionContext *exe_ctx,
const Address *addr, Stream &s) {
FormatEntity::Entry format
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/142489
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1534,15 +1534,13 @@ bool Debugger::FormatDisassemblerAddress(const
FormatEntity::Entry *format,
const ExecutionContext *exe_ctx,
const Address *addr, Stream &s) {
FormatEntity::Entry format
@@ -144,9 +144,9 @@ void Statusline::Redraw(bool update) {
}
StreamString stream;
- if (auto *format = m_debugger.GetStatuslineFormat())
-FormatEntity::Format(*format, stream, &symbol_ctx, &exe_ctx, nullptr,
- nullptr, false, false);
+ FormatE
@@ -380,11 +380,11 @@ bool OptionValue::SetLanguageValue(lldb::LanguageType
new_language) {
return false;
}
-const FormatEntity::Entry *OptionValue::GetFormatEntity() const {
+FormatEntity::Entry OptionValue::GetFormatEntity() const {
std::lock_guard lock(m_mutex);
if
https://github.com/adrian-prantl approved this pull request.
As far as I can tell this looks safe now.
https://github.com/llvm/llvm-project/pull/142489
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/137793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/142044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
That looks like a nice improvement!
https://github.com/llvm/llvm-project/pull/140424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/adrian-prantl approved this pull request.
As an 80x24 terminal user, I approve of this change :-)
https://github.com/llvm/llvm-project/pull/139826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -246,6 +247,8 @@ llvm::StringRef
SymbolFileDWARFDebugMap::GetPluginDescriptionStatic() {
}
SymbolFile *SymbolFileDWARFDebugMap::CreateInstance(ObjectFileSP objfile_sp) {
+ if (objfile_sp->GetPluginName() != ObjectFileMachO::GetPluginNameStatic())
+return nullptr;
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread
&thread,
thread_plan_sp = std::make_shared(
thread, load_addrs, stop_others);
}
+// One more case we have to consider is "branch islands". These are
regular
+// TEXT s
@@ -0,0 +1,3 @@
+.text
adrian-prantl wrote:
This is the first cross-architecture assembler source file I've seen :-)
https://github.com/llvm/llvm-project/pull/138781
___
lldb-commits mailing list
lldb-commits@lists.llv
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/138781
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,16 @@
+C_SOURCES := main.c foo.c
+CFLAGS_EXTRAS := -std=c99
+
+include Makefile.rules
+
+a.out: main.o padding1.o padding2.o padding3.o padding4.o foo.o
+ ${CC} ${LDFLAGS} foo.o padding1.o padding2.o padding3.o padding4.o
main.o -o a.out
+
+%.o: $(SRCDIR)/%.s
+
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread
&thread,
thread_plan_sp = std::make_shared(
thread, load_addrs, stop_others);
}
+// One more case we have to consider is "branch islands". These are
regular
+// TEXT s
@@ -270,10 +270,14 @@ class VectorTypeSyntheticFrontEnd : public
SyntheticChildrenFrontEnd {
}
llvm::Expected GetIndexOfChildWithName(ConstString name) override {
-const char *item_name = name.GetCString();
-uint32_t idx = ExtractIndexFromString(item_name);
-i
@@ -97,18 +97,19 @@ void lldb_private::formatters::AddFilter(
category_sp->AddTypeFilter(type_name, match_type, filter_sp);
}
-size_t lldb_private::formatters::ExtractIndexFromString(const char *item_name)
{
+llvm::Expected
adrian-prantl wrote:
I think her
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Do we really want a copy of all those test-cases in LLDB?
Is it also in the monorepo? Can we just use a relative path to the file?
https://github.com/llvm/llvm-project/pull/137793
___
lldb-commits mailing list
lldb-commits@lists
Author: Adrian Prantl
Date: 2025-04-27T14:35:40-07:00
New Revision: b15adefefffb23fc5de7e26892b22a8716a53621
URL:
https://github.com/llvm/llvm-project/commit/b15adefefffb23fc5de7e26892b22a8716a53621
DIFF:
https://github.com/llvm/llvm-project/commit/b15adefefffb23fc5de7e26892b22a8716a53621.diff
Author: Adrian Prantl
Date: 2025-04-27T14:32:13-07:00
New Revision: cf035e8abbf50efc9ea64c8bf4cdcb7133255a08
URL:
https://github.com/llvm/llvm-project/commit/cf035e8abbf50efc9ea64c8bf4cdcb7133255a08
DIFF:
https://github.com/llvm/llvm-project/commit/cf035e8abbf50efc9ea64c8bf4cdcb7133255a08.diff
adrian-prantl wrote:
Not to derail this too much, but I'm also thinking if we should _stop_ coloring
the column number. Happy to open a patch if people think this is a good idea?
https://github.com/llvm/llvm-project/pull/137301
___
lldb-commits mailin
adrian-prantl wrote:
That sounds useful!
Another way to spell `||` would be `?:` which might be more intuitive to C
programmers?
https://github.com/llvm/llvm-project/pull/137408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
adrian-prantl wrote:
I think this works.
https://github.com/llvm/llvm-project/pull/137301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> > I kinda like how the (highlighted) PC value creates a column. What would
> > you say to highlighting both?
> Maybe we could use a different color? Don't have strong opinions on this.
We could try a less aggressive color like the one used for the file names. I'm
wonder
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString
name) {
}
}
}
- return UINT32_MAX;
+ return llvm::createStringError(
+ "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
adrian-prantl wro
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString
name) {
}
}
}
- return UINT32_MAX;
+ return llvm::createStringError(
+ "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
adrian-prantl wro
@@ -1018,6 +1018,26 @@ CommandInterpreter::VerifyUserMultiwordCmdPath(Args
&path, bool leaf_is_command,
return cur_as_multi;
}
+CommandObjectSP CommandInterpreter::GetFrameLanguageCommand() const {
+ if (auto frame_sp = GetExecutionContext().GetFrameSP()) {
+auto frame
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/137083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/137083
None
>From 05a5eb1eb5ac4ea32c98783cd1a241c7e147e30d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 23 Apr 2025 16:24:49 -0700
Subject: [PATCH] [lldb] Quote module name in error message
---
.../
@@ -0,0 +1,166 @@
+//===-- DemangledNameInfo.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
1 - 100 of 1398 matches
Mail list logo
