https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/137793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/142044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
That looks like a nice improvement!
https://github.com/llvm/llvm-project/pull/140424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/adrian-prantl approved this pull request.
As an 80x24 terminal user, I approve of this change :-)
https://github.com/llvm/llvm-project/pull/139826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -246,6 +247,8 @@ llvm::StringRef
SymbolFileDWARFDebugMap::GetPluginDescriptionStatic() {
}
SymbolFile *SymbolFileDWARFDebugMap::CreateInstance(ObjectFileSP objfile_sp) {
+ if (objfile_sp->GetPluginName() != ObjectFileMachO::GetPluginNameStatic())
+return nullptr;
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread
&thread,
thread_plan_sp = std::make_shared(
thread, load_addrs, stop_others);
}
+// One more case we have to consider is "branch islands". These are
regular
+// TEXT s
@@ -0,0 +1,3 @@
+.text
adrian-prantl wrote:
This is the first cross-architecture assembler source file I've seen :-)
https://github.com/llvm/llvm-project/pull/138781
___
lldb-commits mailing list
lldb-commits@lists.llv
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/138781
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,16 @@
+C_SOURCES := main.c foo.c
+CFLAGS_EXTRAS := -std=c99
+
+include Makefile.rules
+
+a.out: main.o padding1.o padding2.o padding3.o padding4.o foo.o
+ ${CC} ${LDFLAGS} foo.o padding1.o padding2.o padding3.o padding4.o
main.o -o a.out
+
+%.o: $(SRCDIR)/%.s
+
@@ -1028,6 +1029,23 @@ DynamicLoaderDarwin::GetStepThroughTrampolinePlan(Thread
&thread,
thread_plan_sp = std::make_shared(
thread, load_addrs, stop_others);
}
+// One more case we have to consider is "branch islands". These are
regular
+// TEXT s
@@ -270,10 +270,14 @@ class VectorTypeSyntheticFrontEnd : public
SyntheticChildrenFrontEnd {
}
llvm::Expected GetIndexOfChildWithName(ConstString name) override {
-const char *item_name = name.GetCString();
-uint32_t idx = ExtractIndexFromString(item_name);
-i
@@ -97,18 +97,19 @@ void lldb_private::formatters::AddFilter(
category_sp->AddTypeFilter(type_name, match_type, filter_sp);
}
-size_t lldb_private::formatters::ExtractIndexFromString(const char *item_name)
{
+llvm::Expected
adrian-prantl wrote:
I think her
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Do we really want a copy of all those test-cases in LLDB?
Is it also in the monorepo? Can we just use a relative path to the file?
https://github.com/llvm/llvm-project/pull/137793
___
lldb-commits mailing list
lldb-commits@lists
Author: Adrian Prantl
Date: 2025-04-27T14:35:40-07:00
New Revision: b15adefefffb23fc5de7e26892b22a8716a53621
URL:
https://github.com/llvm/llvm-project/commit/b15adefefffb23fc5de7e26892b22a8716a53621
DIFF:
https://github.com/llvm/llvm-project/commit/b15adefefffb23fc5de7e26892b22a8716a53621.diff
Author: Adrian Prantl
Date: 2025-04-27T14:32:13-07:00
New Revision: cf035e8abbf50efc9ea64c8bf4cdcb7133255a08
URL:
https://github.com/llvm/llvm-project/commit/cf035e8abbf50efc9ea64c8bf4cdcb7133255a08
DIFF:
https://github.com/llvm/llvm-project/commit/cf035e8abbf50efc9ea64c8bf4cdcb7133255a08.diff
adrian-prantl wrote:
Not to derail this too much, but I'm also thinking if we should _stop_ coloring
the column number. Happy to open a patch if people think this is a good idea?
https://github.com/llvm/llvm-project/pull/137301
___
lldb-commits mailin
adrian-prantl wrote:
That sounds useful!
Another way to spell `||` would be `?:` which might be more intuitive to C
programmers?
https://github.com/llvm/llvm-project/pull/137408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
adrian-prantl wrote:
I think this works.
https://github.com/llvm/llvm-project/pull/137301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> > I kinda like how the (highlighted) PC value creates a column. What would
> > you say to highlighting both?
> Maybe we could use a different color? Don't have strong opinions on this.
We could try a less aggressive color like the one used for the file names. I'm
wonder
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString
name) {
}
}
}
- return UINT32_MAX;
+ return llvm::createStringError(
+ "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
adrian-prantl wro
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString
name) {
}
}
}
- return UINT32_MAX;
+ return llvm::createStringError(
+ "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
adrian-prantl wro
@@ -1018,6 +1018,26 @@ CommandInterpreter::VerifyUserMultiwordCmdPath(Args
&path, bool leaf_is_command,
return cur_as_multi;
}
+CommandObjectSP CommandInterpreter::GetFrameLanguageCommand() const {
+ if (auto frame_sp = GetExecutionContext().GetFrameSP()) {
+auto frame
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/137083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/137083
None
>From 05a5eb1eb5ac4ea32c98783cd1a241c7e147e30d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 23 Apr 2025 16:24:49 -0700
Subject: [PATCH] [lldb] Quote module name in error message
---
.../
@@ -0,0 +1,166 @@
+//===-- DemangledNameInfo.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString
name) {
}
}
}
- return UINT32_MAX;
+ return llvm::createStringError(
+ "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
adrian-prantl wro
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/136611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/136633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/136633
None
>From 85d2543eee9de66a58208901d1f666fb1c241e6b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 21 Apr 2025 16:22:30 -0700
Subject: [PATCH] [lldb] Clarify the documentation for
GetIndexOfChil
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/136611
>From 5783bec58f5074399edc2d528cbde454f44dd12b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 21 Apr 2025 13:56:28 -0700
Subject: [PATCH] [lldb] Make the statusline separator configurable
And use
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/136611
And use this functionality to replace the ASCII "|" with the same full-geight
line-drawing character used in diagnostics rendering on a color terminal.
>From 3d9d4eba319b33072113ca333d07099be2fba09c Mon S
adrian-prantl wrote:
Why did this break?
https://github.com/llvm/llvm-project/pull/136269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136186
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -368,3 +373,37 @@ bool
lldb_private::formatters::NSTaggedString_SummaryProvider(
stream << suffix;
return true;
}
+
+bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider(
+ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor,
+
@@ -368,3 +373,37 @@ bool
lldb_private::formatters::NSTaggedString_SummaryProvider(
stream << suffix;
return true;
}
+
+bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider(
+ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor,
+
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -368,3 +373,37 @@ bool
lldb_private::formatters::NSTaggedString_SummaryProvider(
stream << suffix;
return true;
}
+
+bool lldb_private::formatters::NSIndirectTaggedString_SummaryProvider(
+ValueObject &valobj, ObjCLanguageRuntime::ClassDescriptorSP descriptor,
+
adrian-prantl wrote:
LGTM with some nits
https://github.com/llvm/llvm-project/pull/136025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -63,12 +63,17 @@ bool lldb_private::formatters::NSStringSummaryProvider(
if (class_name.empty())
return false;
- bool is_tagged_ptr = class_name == "NSTaggedPointerString" &&
- descriptor->GetTaggedPointerInfo();
- // for a tagged pointer, the
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/135963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Oh this is fantastic!
https://github.com/llvm/llvm-project/pull/135944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2025-04-13T14:40:41-07:00
New Revision: 99df442df1f88c1078c433618c75ee62f3dd8512
URL:
https://github.com/llvm/llvm-project/commit/99df442df1f88c1078c433618c75ee62f3dd8512
DIFF:
https://github.com/llvm/llvm-project/commit/99df442df1f88c1078c433618c75ee62f3dd8512.diff
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/135536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/135343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2025-04-08T09:49:36-07:00
New Revision: 2721d50d8785603987358afb4d82b986879ca41e
URL:
https://github.com/llvm/llvm-project/commit/2721d50d8785603987358afb4d82b986879ca41e
DIFF:
https://github.com/llvm/llvm-project/commit/2721d50d8785603987358afb4d82b986879ca41e.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/134719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
Will be great when debugging LLDB itself!
https://github.com/llvm/llvm-project/pull/133211
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -291,13 +291,11 @@ bool
lldb_private::formatters::NSAttributedStringSummaryProvider(
"string_ptr", pointer_value, exe_ctx, type));
if (!child_ptr_sp)
return false;
- DataExtractor data;
- Status error;
- child_ptr_sp->GetData(data, error);
- if (error.Fail()
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/134343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -88,6 +88,7 @@ class ValueObjectMockProcessTest : public ::testing::Test {
var_name,
data_extractor);
if (llvm::Error error = valobj_sp->Dump(strm, options))
adrian-prantl wrote:
The old function s
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/133740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
As the person who suggested this change, I think this is a _great_ idea :-)
https://github.com/llvm/llvm-project/pull/133315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -1148,16 +1175,16 @@ SymbolFileDWARFDebugMap::ParseCallEdgesInFunction(
DWARFDIE SymbolFileDWARFDebugMap::FindDefinitionDIE(const DWARFDIE &die) {
DWARFDIE result;
- ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) {
-result = oso_dwarf->FindDefinitionDIE(die);
-
@@ -924,59 +947,63 @@ void SymbolFileDWARFDebugMap::FindGlobalVariables(
std::lock_guard guard(GetModuleMutex());
uint32_t total_matches = 0;
- ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) {
-const uint32_t old_size = variables.GetSize();
-oso_dwarf->FindGlob
@@ -924,59 +947,63 @@ void SymbolFileDWARFDebugMap::FindGlobalVariables(
std::lock_guard guard(GetModuleMutex());
uint32_t total_matches = 0;
- ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) {
-const uint32_t old_size = variables.GetSize();
-oso_dwarf->FindGlob
@@ -138,10 +139,10 @@ class CPlusPlusLanguage : public Language {
ConstString
GetDemangledFunctionNameWithoutArguments(Mangled mangled) const override;
- bool GetFunctionDisplayName(const SymbolContext *sc,
- const ExecutionContext *exe_ctx,
-
@@ -83,6 +99,127 @@ class OutputBuffer {
return std::string_view(Buffer, CurrentPosition);
}
+ // Stores information about parts of a demangled function name.
+ struct FunctionNameInfo {
+///< A [start, end) pair for the function basename.
adrian-p
@@ -83,6 +99,127 @@ class OutputBuffer {
return std::string_view(Buffer, CurrentPosition);
}
+ // Stores information about parts of a demangled function name.
adrian-prantl wrote:
```suggestion
/// Stores information about parts of a demangled functi
adrian-prantl wrote:
May I recommend we add a skip for macOS < 15 to get the bot green again?
https://github.com/llvm/llvm-project/pull/128156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
adrian-prantl wrote:
> It would be useful to know if you can reproduce this problem locally (because
> I can't -- the test passes on my mac). If you can't then it would be useful
> to get as much information about this buildbot as possible (what kind of
> debugserver it uses, OS versions and s
@@ -273,15 +273,13 @@ ValueObjectSP
ForwardListFrontEnd::GetChildAtIndex(uint32_t idx) {
// we need to copy current_sp into a new object otherwise we will end up with
// all items named __value_
- DataExtractor data;
- Status error;
- current_sp->GetData(data, error);
https://github.com/adrian-prantl commented:
Looks like a great start! I made a couple of suggestions inline.
https://github.com/llvm/llvm-project/pull/130516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
adrian-prantl wrote:
>I was also curious to know if I'd have to change any test code too, I've tried
>to unit test but got error relating to "expected" values. Would I need to
>change something in DumpValueObjectOptionsTests.cpp?
Usually wrapping calls in `llvm::expectedToOptional()` is the ch
@@ -1205,13 +1205,11 @@ bool lldb_private::formatters::ObjCSELSummaryProvider(
valobj_sp = ValueObject::CreateValueObjectFromAddress("text", data_address,
exe_ctx, charstar);
} else {
-DataExtractor data;
-
@@ -207,15 +207,13 @@ lldb::ValueObjectSP lldb_private::formatters::
return lldb::ValueObjectSP();
StreamString stream;
stream.Printf("[%" PRIu64 "]", (uint64_t)idx);
- DataExtractor data;
- Status error;
- val_hash.first->GetData(data, error);
- if (error.Fail())
+
@@ -523,13 +522,11 @@ class EntityVariableBase : public Materializer::Entity {
return;
}
} else {
-DataExtractor data;
-Status extract_error;
-valobj_sp->GetData(data, extract_error);
-if (!extract_error.Success()) {
+
@@ -540,9 +537,9 @@ class EntityVariableBase : public Materializer::Entity {
return;
}
-if (data.GetByteSize() <
+if (data_or_err->GetByteSize() <
adrian-prantl wrote:
I like to add a
```
auto data = *data_or_err;
```
than t
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/130516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -68,11 +68,9 @@ static bool CharStringSummaryProvider(ValueObject &valobj,
Stream &stream) {
template
static bool CharSummaryProvider(ValueObject &valobj, Stream &stream) {
- DataExtractor data;
- Status error;
- valobj.GetData(data, error);
+ auto data_or_err = valob
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/130209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/130209
>From 1dc911414f8bf6441fec6384de046f45e7049870 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 6 Mar 2025 16:33:35 -0800
Subject: [PATCH] [lldb] Objective-C runtime: Work around a bug in the shared
@@ -247,13 +247,15 @@ static lldb::addr_t GetVTableAddress(Process &process,
// We have an object already read from process memory,
// so just extract VTable pointer from it
- DataExtractor data;
- Status err;
- auto size = valobj.GetData(data, err);
- if (err.Fail() |
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/130640
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1810,6 +1845,9 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
}
if (attrs.is_forward_declaration) {
+if (IsCppForwardDeclObjC(*dwarf, attrs))
+ attrs.class_language = eLanguageTypeObjC_plus_plus;
adrian-prantl wrote:
Author: Adrian Prantl
Date: 2025-03-09T12:04:22-07:00
New Revision: 2317a72489145f582ac1f01bc8c4f3b6bb5abb44
URL:
https://github.com/llvm/llvm-project/commit/2317a72489145f582ac1f01bc8c4f3b6bb5abb44
DIFF:
https://github.com/llvm/llvm-project/commit/2317a72489145f582ac1f01bc8c4f3b6bb5abb44.diff
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/130209
where it can overflow a 2GB offset by just a little bit by applying a heuristic.
rdar://145888306
>From a6caecd1e1bae614579783ac1952e999eae5959d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 6
Author: Adrian Prantl
Date: 2025-03-05T12:58:22-08:00
New Revision: 46236f4c3dbe11e14fe7ac1f4b903637efedfecf
URL:
https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf
DIFF:
https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/129601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
It might be worth exploring a SourceManager subclass that has in addition to a
MemoryBuffer-backed location also a source file type that is a file/line
variant that is only converted into a MemoryBuffer-backed location if we do an
operation that really needs it.
https://g
@@ -581,6 +626,21 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
"XcodeSDK not specified");
XcodeSDK sdk = *options.XcodeSDKSelection;
auto key = sdk.GetString();
+
+ // xcrun doesn't search SDKs in the CommandLineT
adrian-prantl wrote:
Do we only pay the cost when a diagnostic is generated, or every time a
DW_AT_file is parsed?
https://github.com/llvm/llvm-project/pull/127829
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
adrian-prantl wrote:
In any case, I think it might be useful to remand the patch once, so we can
inspect the failure log on the bot, since the bot logs have been recycled since
the last time this landed.
https://github.com/llvm/llvm-project/pull/123945
_
adrian-prantl wrote:
> greendragon probably does build debugserver, but tests use Xcode's
> debugserver for proper codesigning, not the built debugserver.
Are you sure? My recollection is that we went out of our way to make code
signing work on those bots.
https://github.com/llvm/llvm-project
adrian-prantl wrote:
>From a quick check of the logs, green dragon seems to be set up to build
>debugserver, too.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/adrian-prantl approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/126221
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -262,8 +262,10 @@ OptionArgParser::DoToAddress(const ExecutionContext
*exe_ctx, llvm::StringRef s,
// 3: The symbol/reg name if there is an offset
// 4: +/-
// 5: The offset value.
+ // clang-format off
static RegularExpression g_symbol_plus_offset_regex(
- "
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/126053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2025-01-31T13:11:20-08:00
New Revision: 87b7f63a117c340a6d9ca47959335fd7ef6c7ad2
URL:
https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2
DIFF:
https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2.diff
adrian-prantl wrote:
I'm going to revert this for now, let me know if you need help understanding
the failure cause!
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
adrian-prantl wrote:
This is breaking macOS bots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/19569/
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
https://github.com/adrian-prantl commented:
I found one bug, otherwise this looks good!
https://github.com/llvm/llvm-project/pull/120163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/120163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -327,27 +358,45 @@ static lldb::offset_t GetOpcodeDataSize(const
DataExtractor &data,
return offset - data_offset;
}
+ case DW_OP_implicit_pointer: // 0xa0 4 + LEB128
+ {
+data.Skip_LEB128(&offset);
+return 4 + offset - data_offset;
adrian-
adrian-prantl wrote:
Generally speaking, it would be a lot more robust to not try and write a regex
for the output, but individually check the summary/type for main node and
children.
https://github.com/llvm/llvm-project/pull/123393
___
lldb-commits
1 - 100 of 1327 matches
Mail list logo
