adrian-prantl wrote: As high-level comments: - I would filter out the entry values, since this feature is meant to help a user understand the disassembly, and the entry values don't really exist in the function. - It would help readability if all annotations started at the same column - in a follow-up patch it would be great to outline the valid range of each expression - is it possible to hide the DW_OP... part and just show the human-readable register name? - `DW_OP_consts +0, DW_OP_stack_value` -> I would filter out anything that isn't a pure register. Then we can later recognize certain kinds of expression, for example, this is a constant, so it should just print `= 0`
https://github.com/llvm/llvm-project/pull/147460 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
