[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fixing makefile issue to include riscv emulation test only when RISCV is present. (PR #159842)

2025-09-19 Thread David Peixotto via lldb-commits
@@ -2,14 +2,34 @@ add_lldb_unittest(EmulatorTests ARM64/TestAArch64Emulator.cpp LoongArch/TestLoongArchEmulator.cpp RISCV/TestRISCVEmulator.cpp - + dmpots wrote: There shouldn't be any changes to this unittest target now that we are splitting it out i

[Lldb-commits] [lldb] [lldb] Introduce Process::FixAnyAddressPreservingAuthentication (PR #159785)

2025-09-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/159785 >From cba7da1439a4d574906422856739dbdbb9590248 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 18 Sep 2025 14:45:00 -0700 Subject: [PATCH] [lldb] Introduce Process::FixAnyAddressPres

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Roy Shi (royitaqi) Changes # Motiviation This helps the development of the lldb-dap binary. For example, when testing a locally built lldb-dap binary, one probably wants to restart the server after each build in order to use the latest bi

[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-19 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/159807 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Introduce Process::FixAnyAddressPreservingAuthentication (PR #159785)

2025-09-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: I forgot all about https://github.com/llvm/llvm-project/pull/157435 so I just merged it and you'll have conflicts from that. You don't have to make the test work on Linux, `if Darwin` is fine and extend it later. In an ideal world, we would know that the target has memory

[Lldb-commits] [lldb] [llvm] [ELF][LLDB] Add an nvsass triple (PR #159459)

2025-09-19 Thread Joseph Huber via lldb-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/159459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -271,6 +283,131 @@ class ObjectFileMachO : public lldb_private::ObjectFile { uint32_t strsize = 0; /* string table size in bytes */ }; + // The LC_DYLD_INFO's dyld_info_command has 32-bit file offsets + // that we will use as virtual address offsets, and may ne

[Lldb-commits] [lldb] Fixing makefile issue to include riscv emulation test only when RISCV is present. (PR #159842)

2025-09-19 Thread David Peixotto via lldb-commits
@@ -2,14 +2,34 @@ add_lldb_unittest(EmulatorTests ARM64/TestAArch64Emulator.cpp LoongArch/TestLoongArchEmulator.cpp RISCV/TestRISCVEmulator.cpp - + LINK_COMPONENTS Support +${LLVM_TARGETS_TO_BUILD} LINK_LIBS lldbCore lldbSymbol lldbTarget

[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-19 Thread via lldb-commits
dlav-sc wrote: **II Watchpoint.cpp ** I conducted significant refactoring of the internal logic of the `Watchpoint` class. Initially, I created two separate classes, `SoftwareWatchpoint` and `HardwareWatchpoint`, which inherited from the `Wa

[Lldb-commits] [lldb] [lldb][test] Unify and extend test infrastructure for checking CPU features (PR #153914)

2025-09-19 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/153914 >From fd3eff77a288062c86fcad3f32bf27e7cba6de76 Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Fri, 15 Aug 2025 16:19:37 -0700 Subject: [PATCH 1/4] [LLDB] Add CPU feature check support to Darwin Add new `CPUFeat

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/159849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0fa3061 - Revert "[ELF][LLDB] Add an nvsass triple (#159459)" (#159879)

2025-09-19 Thread via lldb-commits
Author: Joseph Huber Date: 2025-09-19T20:13:48-05:00 New Revision: 0fa3061c4e1468f8ab8fbb06ef0d19c00df2aef3 URL: https://github.com/llvm/llvm-project/commit/0fa3061c4e1468f8ab8fbb06ef0d19c00df2aef3 DIFF: https://github.com/llvm/llvm-project/commit/0fa3061c4e1468f8ab8fbb06ef0d19c00df2aef3.diff

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo Doxygen comments. https://github.com/llvm/llvm-project/pull/159849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/159849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -271,6 +283,131 @@ class ObjectFileMachO : public lldb_private::ObjectFile { uint32_t strsize = 0; /* string table size in bytes */ }; + // The LC_DYLD_INFO's dyld_info_command has 32-bit file offsets + // that we will use as virtual address offsets, and may ne

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-19 Thread via lldb-commits
@@ -621,63 +621,72 @@ void Thread::WillStop() { } bool Thread::SetupToStepOverBreakpointIfNeeded(RunDirection direction) { - if (GetResumeState() != eStateSuspended) { -// First check whether this thread is going to "actually" resume at all. -// For instance, if we're

[Lldb-commits] [lldb] [lldb][test] Unify and extend test infrastructure for checking CPU features (PR #153914)

2025-09-19 Thread Julian Lettner via lldb-commits
@@ -0,0 +1,58 @@ +""" +Platform-agnostic helper to query for CPU features. +""" + +import re + + +class CPUFeature: +def __init__(self, linux_cpu_info_flag: str, darwin_sysctl_key: str): +self.cpu_info_flag = linux_cpu_info_flag +self.sysctl_key = darwin_sysctl

[Lldb-commits] [lldb] [llvm] Revert "[ELF][LLDB] Add an nvsass triple (#159459)" (PR #159879)

2025-09-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/include/lldb/Utility/ArchSpec.h lldb/sour

[Lldb-commits] [lldb] [llvm] Revert "[ELF][LLDB] Add an nvsass triple (#159459)" (PR #159879)

2025-09-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Joseph Huber (jhuber6) Changes Summary: This patch has broken the `libc` build bot. I could work around that but the changes seem unnecessary. This reverts commit 9ba844eb3a21d461c3adc7add7691a076c6992fc. --- Full diff: https://github.com

[Lldb-commits] [lldb] [llvm] Revert "[ELF][LLDB] Add an nvsass triple (#159459)" (PR #159879)

2025-09-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: Joseph Huber (jhuber6) Changes Summary: This patch has broken the `libc` build bot. I could work around that but the changes seem unnecessary. This reverts commit 9ba844eb3a21d461c3adc7add7691a076c6992fc. --- Full diff: h

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Matheus Izvekov via lldb-commits
@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); mizvekov wrote: If you feel the

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Matheus Izvekov via lldb-commits
@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); mizvekov wrote: > I suppose I e

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-19 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > > LLVM Buildbot has detected a new failure on builder > > `lldb-remote-linux-ubuntu` > > https://lab.llvm.org/buildbot/#/builders/195/builds/14788 > > The buildbot lldb-remote-linux-win is broken too > https://lab.llvm.org/buildbot/#/builders/197/builds/9007 > > Please

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1250095 - [vscode-lldb] Improve logging in Server Mode (#159672)

2025-09-19 Thread via lldb-commits
Author: Roy Shi Date: 2025-09-19T14:43:37-07:00 New Revision: 1250095b1a21f219b22e2c50b9789e001813627a URL: https://github.com/llvm/llvm-project/commit/1250095b1a21f219b22e2c50b9789e001813627a DIFF: https://github.com/llvm/llvm-project/commit/1250095b1a21f219b22e2c50b9789e001813627a.diff LOG:

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
royitaqi wrote: @walter-erquinigo: Updated the patch to use `chokidar`. It worked out of the box, which is nice~ Any other suggestions from you? https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
@@ -83,6 +88,18 @@ export class LLDBDapServer implements vscode.Disposable { }); this.serverProcess = process; this.serverSpawnInfo = this.getSpawnInfo(dapPath, dapArgs, options?.env); + this.serverFileChanged = false; royitaqi wrote: @w

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere Here you go. > lldb-dap-20250919T135246-90ee62ea.log > drop the -session and -vscode Originally I added "-vscode" as a visual separator between the timestamp and the UUID (which contains multiple "-"). Now it's shorter I think it's good to remove it. > unless fo

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-19 Thread via lldb-commits
dlav-sc wrote: **III StopInfo.cpp =** Besides moving the logic from `StopInfoWatchpoint::PerformAction` into `Watchpoint::WatchedValueReportable` as mentioned above, I also endeavored to improve the overall readability of `StopInfoWatchpoint::Pe

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Justin Stitt via lldb-commits
@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); JustinStitt wrote: > If you fee

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi deleted https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/159797 >From e4d4d1c8d38ae929081778b47859c47a5a5665c8 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Fri, 19 Sep 2025 07:57:06 -0700 Subject: [PATCH 1/2] [vscode-lldb] Restart server when the lldb-dap binary has change

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [ELF][LLDB] Add an nvsass triple (PR #159459)

2025-09-19 Thread Justin Holewinski via lldb-commits
@@ -295,7 +295,7 @@ TEST(ELFObjectFileTest, CheckOSAndTriple) { {ELF::EM_X86_64, ELF::ELFOSABI_AIX, "x86_64--aix"}, {ELF::EM_X86_64, ELF::ELFOSABI_FREEBSD, "x86_64--freebsd"}, {ELF::EM_X86_64, ELF::ELFOSABI_OPENBSD, "x86_64--openbsd"}, - {ELF::EM_CUDA, EL

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The Mach-O file format has several load commands which specify the location of data in the file in UInt32 offsets. lldb uses these same structures to track the offsets of the binary in virtual address

[Lldb-commits] [lldb] [lldb][MachO] Local structs for larger VA offsets (PR #159849)

2025-09-19 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/159849 The Mach-O file format has several load commands which specify the location of data in the file in UInt32 offsets. lldb uses these same structures to track the offsets of the binary in virtual address spa

[Lldb-commits] [lldb] [vscode-lldb] Restart server when lldb-dap binary has changed (PR #159797)

2025-09-19 Thread Roy Shi via lldb-commits
@@ -83,6 +88,18 @@ export class LLDBDapServer implements vscode.Disposable { }); this.serverProcess = process; this.serverSpawnInfo = this.getSpawnInfo(dapPath, dapArgs, options?.env); + this.serverFileChanged = false; royitaqi wrote: Ju

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Looks good, thank you! https://github.com/llvm/llvm-project/pull/159672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/159672 >From 79ea55789a7f01b05009a9bb6c28fa6e4ebe7fdb Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 18 Sep 2025 15:52:45 -0700 Subject: [PATCH 1/4] [vscode-lldb] Improve logging in server mode --- lldb/tools/lld

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Using the session ID sounds fine. I suppose the first segment of the UUID is unique enough, so if it's easy, I'd lean towards that. I also think we can drop the `-session` and `-vscode` from the filename (unless forks like cursor would report something else and folks think

[Lldb-commits] [lldb] [vscode-lldb] Improve logging in Server Mode (PR #159672)

2025-09-19 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere VSCode PID isn't readily accessible (see [ref](https://www.google.com/search?q=how+does+a+vscode+extension+get+the+PID+of+the+vscode+window%3F) and [ref](https://stackoverflow.com/questions/43975632/access-window-object-from-vscode-extension)), so I used the VSCo

[Lldb-commits] [lldb] Fixing makefile issue to include riscv emulation test only when RISCV is present. (PR #159842)

2025-09-19 Thread David Peixotto via lldb-commits
https://github.com/dmpots requested changes to this pull request. Update the title to something like "Reland #158161 with cmake fix" Please update the commit message with a description of why the original commit was failing and what you did to fix it. It's also good to explicitly reference the

[Lldb-commits] [lldb] Fixing makefile issue to include riscv emulation test only when RISCV is present. (PR #159842)

2025-09-19 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/159842 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fixing makefile issue to include riscv emulation test only when RISCV is present. (PR #159842)

2025-09-19 Thread via lldb-commits
https://github.com/barsolo2000 ready_for_review https://github.com/llvm/llvm-project/pull/159842 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Matheus Izvekov via lldb-commits
@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); mizvekov wrote: These names sta

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Matheus Izvekov via lldb-commits
@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); mizvekov wrote: If you would li

[Lldb-commits] [lldb] [LLDB] Fix 64 bit support for CIE and FDE handling in DWARFCallFrameInfo (PR #158350)

2025-09-19 Thread Andrew Gontarek via lldb-commits
@@ -283,7 +306,7 @@ DWARFCallFrameInfo::ParseCIE(const dw_offset_t cie_offset) { GetCFIData(); uint32_t length = m_cfi_data.GetU32(&offset); dw_offset_t cie_id, end_offset; - bool is_64bit = (length == UINT32_MAX); + bool is_64bit = (length == std::numeric_limits::max

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Justin Stitt via lldb-commits
@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); JustinStitt wrote: OK, so shoul

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-19 Thread Matheus Izvekov via lldb-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -foverflow-behavior-types -std=c++11 -ast-print %s -o - | FileCheck %s + +extern int __attribute__((overflow_behavior(no_wrap))) a; +extern int __attribute__((overflow_behavior(wrap))) b; + +// CHECK: extern __no_wrap int a; +// CHECK: extern _

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/159160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -164,48 +126,65 @@ void Server::AddResourceProvider( m_resource_providers.push_back(std::move(resource_provider)); } -void Server::AddRequestHandler(llvm::StringRef method, RequestHandler handler) { - m_request_handlers[method] = std::move(handler); -} - -void Server::A

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -69,7 +114,8 @@ template class Transport { /// Sends a response to a specific request. virtual llvm::Error Send(const Resp &) = 0; - /// Implemented to handle incoming messages. (See Run() below). + /// Implemented to handle incoming messages. (See `RegisterMessageH

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +56,88 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + + explicit InvalidParams(std::string method, std::string context) + : m_method(std::move(method)

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -297,6 +340,450 @@ class JSONRPCTransport : public IOTransport { static constexpr llvm::StringLiteral kMessageSeparator = "\n"; }; -} // namespace lldb_private +/// A handler for the response to an outgoing request. +template +using Reply = +std::conditional_t, +

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -50,17 +58,54 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; +/// An error to indicate that the parameters of a Req, Resp or Evt could not be +/// deserialized. +class InvalidParams : public llvm::ErrorInfo { +public: + static char ID; + +

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -297,6 +340,450 @@ class JSONRPCTransport : public IOTransport { static constexpr llvm::StringLiteral kMessageSeparator = "\n"; }; -} // namespace lldb_private +/// A handler for the response to an outgoing request. +template +using Reply = +std::conditional_t, +

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
@@ -322,6 +323,17 @@ struct CallToolResult { llvm::json::Value toJSON(const CallToolResult &); bool fromJSON(const llvm::json::Value &, CallToolResult &, llvm::json::Path); +lldb_protocol::mcp::Request +MakeRequest(int64_t id, llvm::StringRef method, +std::optional

[Lldb-commits] [lldb] [lldb] Adding A new Binding helper for JSONTransport. (PR #159160)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Thanks, this is looking good. Left some nits, but I think I have a good grasp on the Binder now. I assume the plan is to use the Binder for `lldb-dap` too? https://github.com/llvm/llvm-project/pull/159160 __

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-19 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (PR #159606)

2025-09-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/159606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-19 Thread via lldb-commits
dlav-sc wrote: Hi @DavidSpickett, @jasonmolenda, @jimingham, I've decided to divide the software watchpoint support patch (https://github.com/llvm/llvm-project/pull/151195) into several smaller parts. This is the first one, which consists almost entirely of NFC, refactoring of the existing wa

[Lldb-commits] [lldb] [lldb] refactor watchpoint functionality (PR #159807)

2025-09-19 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/159807 >From 9092e3acdb6e2bd1d2f4ec6f195f32d95f6cc8d9 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Mon, 10 Feb 2025 03:16:50 + Subject: [PATCH] [lldb] refactor watchpoint functionality This patch is the firs

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -80,15 +159,64 @@ ASTNodeUP DILParser::Run() { // Parse an expression. // // expression: -//unary_expression +//cast_expression // -ASTNodeUP DILParser::ParseExpression() { return ParseUnaryExpression(); } +ASTNodeUP DILParser::ParseExpression() { return ParseCastE

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -42,6 +44,83 @@ DILDiagnosticError::DILDiagnosticError(llvm::StringRef expr, m_detail.rendered = std::move(rendered_msg); } +llvm::Expected +DILGetTypeSystemFromCU(std::shared_ptr ctx) { + SymbolContext symbol_context = + ctx->GetSymbolContext(lldb::eSymbolContextCo

[Lldb-commits] [lldb] [lldb] Remove unnecessary calls to Fix{Code, Data}Address (PR #150537)

2025-09-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/150537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Introduce Process::FixAnyAddressPreservingAuthentication (PR #159785)

2025-09-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: A more generic term might be "significant" bits, significant to what is what people will wonder but at least it covers the bits significant to address resolution, plus anything required to use the pointer in code. Which could include the PAC code, if you had really particu

[Lldb-commits] [lldb] [llvm] [ELF][LLDB] Add an nvsass triple (PR #159459)

2025-09-19 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/159459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9ba844e - [ELF][LLDB] Add an nvsass triple (#159459)

2025-09-19 Thread via lldb-commits
Author: Walter Erquinigo Date: 2025-09-19T14:14:20-04:00 New Revision: 9ba844eb3a21d461c3adc7add7691a076c6992fc URL: https://github.com/llvm/llvm-project/commit/9ba844eb3a21d461c3adc7add7691a076c6992fc DIFF: https://github.com/llvm/llvm-project/commit/9ba844eb3a21d461c3adc7add7691a076c6992fc.di

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1688011 - [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (#159825)

2025-09-19 Thread via lldb-commits
Author: Anthony Latsis Date: 2025-09-19T11:13:34-07:00 New Revision: 16880116c9a180e1dfed69be383d20e1efd8d3c1 URL: https://github.com/llvm/llvm-project/commit/16880116c9a180e1dfed69be383d20e1efd8d3c1 DIFF: https://github.com/llvm/llvm-project/commit/16880116c9a180e1dfed69be383d20e1efd8d3c1.diff

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/159825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread Anthony Latsis via lldb-commits
https://github.com/AnthonyLatsis created https://github.com/llvm/llvm-project/pull/159825 Remove 'lldb-python-scripts' from LLVM_DISTRIBUTION_COMPONENTS when Python scripting is disabled. Otherwise we get ``` Specified distribution component 'lldb-python-scripts' doesn't have an install targe

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (attempt 2) (PR #159676)

2025-09-19 Thread Chad Smith via lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/159676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -0,0 +1,81 @@ +// CStyleCast, main.cpp + +#include +#include +#include +#include +#include +#include +#include + +namespace ns { + +typedef int myint; + +class Foo {}; + +namespace inner { + +using mydouble = double; + +class Foo {}; + +} // namespace inner + +} // names

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/159500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (attempt 2) (PR #159676)

2025-09-19 Thread Chad Smith via lldb-commits
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/159676 >From f591e8fe9f1f33e452b6f594cabd314844150a41 Mon Sep 17 00:00:00 2001 From: Chad Smith Date: Thu, 18 Sep 2025 15:02:38 -0700 Subject: [PATCH 1/4] refactor android platform --- .../Plugins/Platform/Android/AdbCli

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/159825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Linux build when LLDB_ENABLE_PYTHON is OFF (PR #159825)

2025-09-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Anthony Latsis (AnthonyLatsis) Changes Remove 'lldb-python-scripts' from LLVM_DISTRIBUTION_COMPONENTS when Python scripting is disabled. Otherwise we get ``` Specified distribution component 'lldb-python-scripts' doesn't have an install t

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (attempt 2) (PR #159676)

2025-09-19 Thread Chad Smith via lldb-commits
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/159676 >From 652e39336e516b1020c1e9b0e9e633d3c96dc781 Mon Sep 17 00:00:00 2001 From: Chad Smith Date: Thu, 18 Sep 2025 15:02:38 -0700 Subject: [PATCH 1/4] refactor android platform --- .../Plugins/Platform/Android/AdbCli

[Lldb-commits] [lldb] [lldb] install lldb-tblgen by default to ease cross-compilation (one-liner) (PR #159812)

2025-09-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0ce6052 - [lldb] install lldb-tblgen by default to ease cross-compilation (one-liner) (#159812)

2025-09-19 Thread via lldb-commits
Author: Jonathan Thackray Date: 2025-09-19T10:56:26-07:00 New Revision: 0ce6052a0c08035a07fcabb05271be7313308db3 URL: https://github.com/llvm/llvm-project/commit/0ce6052a0c08035a07fcabb05271be7313308db3 DIFF: https://github.com/llvm/llvm-project/commit/0ce6052a0c08035a07fcabb05271be7313308db3.d

[Lldb-commits] [lldb] [llvm] [ELF][LLDB] Add an nvsass triple (PR #159459)

2025-09-19 Thread Justin Holewinski via lldb-commits
https://github.com/jholewinski approved this pull request. https://github.com/llvm/llvm-project/pull/159459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-19 Thread Walter Erquinigo via lldb-commits
@@ -149,27 +149,40 @@ Restarting the server will interrupt any existing debug sessions and start a new this.cleanUp(this.serverProcess); } - cleanUp(process: child_process.ChildProcessWithoutNullStreams) { + private cleanUp(process: child_process.ChildProcessWithoutNu

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -42,6 +44,83 @@ DILDiagnosticError::DILDiagnosticError(llvm::StringRef expr, m_detail.rendered = std::move(rendered_msg); } +llvm::Expected +DILGetTypeSystemFromCU(std::shared_ptr ctx) { + SymbolContext symbol_context = + ctx->GetSymbolContext(lldb::eSymbolContextCo

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -0,0 +1,233 @@ +""" +Make sure 'frame var' using DIL parser/evaultor works for C-Style casts. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + +import os +import shutil +import time + +cla

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -42,6 +44,83 @@ DILDiagnosticError::DILDiagnosticError(llvm::StringRef expr, m_detail.rendered = std::move(rendered_msg); } +llvm::Expected +DILGetTypeSystemFromCU(std::shared_ptr ctx) { + SymbolContext symbol_context = + ctx->GetSymbolContext(lldb::eSymbolContextCo

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -0,0 +1,233 @@ +""" +Make sure 'frame var' using DIL parser/evaultor works for C-Style casts. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + +import os +import shutil +import time + +cla

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -0,0 +1,81 @@ +// CStyleCast, main.cpp + +#include +#include +#include +#include +#include +#include +#include + +namespace ns { + +typedef int myint; + +class Foo {}; + +namespace inner { + +using mydouble = double; + +class Foo {}; + +} // namespace inner + +} // names

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -608,4 +635,238 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected Interpreter::VerifyCStyleCastType( +lldb::ValueObjectSP &operand, CompilerType &op_type, +CompilerTy

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-19 Thread Ilia Kuklin via lldb-commits
@@ -0,0 +1,233 @@ +""" +Make sure 'frame var' using DIL parser/evaultor works for C-Style casts. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + +import os +import shutil +import time + +cla

  1   2   >