[Lldb-commits] [lldb] 3788d45 - [lldb][objc] NSError data formatter test is failing

2025-05-28 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-05-28T22:02:16-07:00 New Revision: 3788d459472fb28c244bad6bf010fdcbad907de7 URL: https://github.com/llvm/llvm-project/commit/3788d459472fb28c244bad6bf010fdcbad907de7 DIFF: https://github.com/llvm/llvm-project/commit/3788d459472fb28c244bad6bf010fdcbad907de7.diff

[Lldb-commits] [lldb] [lldb] Allow specific 'make' tool for LLDB testsuite. (PR #93367)

2025-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/93367 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update LLDB testsuite's Makefile.rules in order to support the cross builds on Windows host. (PR #93639)

2025-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/93639 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Wrap Unix-style path inside appropriate API test Makefiles. (PR #93643)

2025-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/93643 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Fix TestStdCXXDisassembly test when running on the remote Linux targets. (PR #93649)

2025-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/93649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests. (PR #93648)

2025-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/93648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow using a custom 'strip' tool for the API tests. (PR #93645)

2025-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka closed https://github.com/llvm/llvm-project/pull/93645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/141689 >From ad0a9cd321d260cd87b852b335da9565f8326449 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 27 May 2025 16:40:10 -0700 Subject: [PATCH 1/2] [lldb-dap] Test Gardening, improving DebugCommunication. Imp

[Lldb-commits] [lldb] 8199f18 - [lldb] Use if-with-initializer pattern in SBTarget (NFC) (#141284)

2025-05-28 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-28T15:11:02-07:00 New Revision: 8199f181cd42e45cbcca095c5c700930215d2c86 URL: https://github.com/llvm/llvm-project/commit/8199f181cd42e45cbcca095c5c700930215d2c86 DIFF: https://github.com/llvm/llvm-project/commit/8199f181cd42e45cbcca095c5c700930215d2c86.d

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. I think the types and classes will help a lot in the long run. https://github.com/llvm/llvm-project/pull/141689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb] Run TestFrameLanguageCommands.py only on Darwin (PR #141866)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes Tests using ObjC do not readily run on Linux. --- Full diff: https://github.com/llvm/llvm-project/pull/141866.diff 1 Files Affected: - (modified) lldb/test/API/commands/command/language/TestFrameLanguageC

[Lldb-commits] [lldb] [lldb] Run TestFrameLanguageCommands.py only on Darwin (PR #141866)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/141866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1d48e55 - [lldb] Run TestFrameLanguageCommands.py only on Darwin (#141866)

2025-05-28 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-28T15:08:58-07:00 New Revision: 1d48e5549f583f501343a9f7c17c1cbda6848a3f URL: https://github.com/llvm/llvm-project/commit/1d48e5549f583f501343a9f7c17c1cbda6848a3f DIFF: https://github.com/llvm/llvm-project/commit/1d48e5549f583f501343a9f7c17c1cbda6848a3f.diff LOG:

[Lldb-commits] [lldb] [lldb] Run TestFrameLanguageCommands.py only on Darwin (PR #141866)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/141866 Tests using ObjC do not readily run on Linux. >From be15e28e81e41a6f25c9591ef6fb9b2130482c12 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 28 May 2025 15:08:03 -0700 Subject: [PATCH] [lldb] Run TestFr

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead processes on Linux (PR #137041)

2025-05-28 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > What do you say to all this? I realize I am sort of asking you my pet > feature, but I think that by framing your feature (debugging of dead > processes) as a special case of this (debugging exiting processes), we can > avoid most of the problematic issues with this PR (diverg

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: The following buildbots are broken https://lab.llvm.org/buildbot/#/builders/197/builds/5950 ``` ld.lld: error: unable to find library -lobjc clang: error: linker command failed with exit code 1 (use -v to see invocation) make: *** [Makefile.rules:530: a.out] Error 1 ``` https://l

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From d595bfeac15852ce12d9851198b57de2f7da08cb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/3] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 4520d08763106b8d639e8afcb3f035a3070dee7f Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream LLDB to RPC converstion Python sc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: Currently I don't think it can live in lldb-dap, because both setting the target and calculating the symbol context are private: ```cpp sc.target_sp = target.GetSP(); SymbolContextItem scope = static_cast(resolve_scope); if (m_opaque_up->IsVal

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: Looking at the `SBTarget::ResolveSymbolContextForAddress()` implementation it won't apply source maps correctly because it doesn't set the target to the symbol context at any point. in order to apply the source maps you must have `sc.target_sp

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
@@ -1008,12 +1084,13 @@ def request_setBreakpoints(self, source: Source, line_array, data=None): breakpoints.append(bp) args_dict["breakpoints"] = breakpoints -command_dict = { +command_dict: Request = { "command": "set

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
@@ -224,99 +265,155 @@ def collect_output(self, category, timeout_secs, pattern, clear=True): break return collected_output if collected_output else None -def _enqueue_recv_packet(self, packet: Optional[ProtocolMessage]): -self.recv_con

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
@@ -104,6 +103,17 @@ def waitUntil(self, condition_callback): time.sleep(0.5) return False +def assertResponseSuccess(self, response: Response): +self.assertIsNotNone(response) +if not response.get("success", False): ash

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread John Harrison via lldb-commits
ashgti wrote: nit: Should this live in the lldb-dap top level folder? I could go either way on that, but it matches the existing helpers. https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread John Harrison via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/141689 >From ad0a9cd321d260cd87b852b335da9565f8326449 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 27 May 2025 16:40:10 -0700 Subject: [PATCH 1/2] [lldb-dap] Test Gardening, improving DebugCommunication. Imp

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 711a177 - add explicit default initialization to DemangledNameInfo to remove warning (#141790)

2025-05-28 Thread via lldb-commits
Author: Charles Zablit Date: 2025-05-28T21:41:45+01:00 New Revision: 711a1779dcb4ed5616d5727d990b642a3593855f URL: https://github.com/llvm/llvm-project/commit/711a1779dcb4ed5616d5727d990b642a3593855f DIFF: https://github.com/llvm/llvm-project/commit/711a1779dcb4ed5616d5727d990b642a3593855f.diff

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Please feel free to merge when possible, as I do not have commit access yet. https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-05-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Closed this as #138209 is preferred. https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 02916a4 - [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (#138209)

2025-05-28 Thread via lldb-commits
Author: Zequan Wu Date: 2025-05-28T16:04:24-04:00 New Revision: 02916a432ca6465e2e45f67be94f1c89c9cd425d URL: https://github.com/llvm/llvm-project/commit/02916a432ca6465e2e45f67be94f1c89c9cd425d DIFF: https://github.com/llvm/llvm-project/commit/02916a432ca6465e2e45f67be94f1c89c9cd425d.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From 40793cd53f94744ee157865b579ff01eb5776f59 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: See https://github.com/llvm/llvm-project/pull/136766 https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e653dc9 - [lldb] Fix TestFrameLanguageCommands.py build (#141829)

2025-05-28 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-28T12:25:49-07:00 New Revision: e653dc9ca00819dc7767dbde4422e96ddc296d03 URL: https://github.com/llvm/llvm-project/commit/e653dc9ca00819dc7767dbde4422e96ddc296d03 DIFF: https://github.com/llvm/llvm-project/commit/e653dc9ca00819dc7767dbde4422e96ddc296d03.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141829.diff 1 Files Affected: - (modified) lldb/test/API/commands/command/language/Makefile (-1) ``diff diff --git a/lldb/test/API/comman

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/141829 None >From f46ad6b01c84dce72cf1547acd2a877f4a8b1dbe Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 28 May 2025 12:24:16 -0700 Subject: [PATCH] [lldb] Fix TestFrameLanguageCommands.py build --- lldb/te

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-28 Thread via lldb-commits
jimingham wrote: It always makes me a little sad to see `.first` or `.second` showing up - they are so non-self-documenting. How horrible would this be if you used a `struct AddrAndType { AddressType type; lldb::addr_t address}` (I'm a bit surprised we don't have one already) instead so that

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-28 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/141543 >From 75f0f1463c7bcabb5ffef34c0f1e1c0b4ca91b04 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 27 May 2025 12:10:36 +0800 Subject: [PATCH 1/3] [libc++][lldb-dap][test] Fix CI for bootstrapping-build --- l

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Ping. https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
ldionne wrote: Thanks a lot for investigating this folks, in particular @frederick-vs-ja for jumping on the issue to restore libc++'s CI. https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] 4304d90 - [libc++][lldb-dap][test] Fix CI for bootstrapping-build (#141543)

2025-05-28 Thread via lldb-commits
Author: A. Jiang Date: 2025-05-28T14:30:45-04:00 New Revision: 4304d90f0ac171f86c26d7d2da4fd03b336957bb URL: https://github.com/llvm/llvm-project/commit/4304d90f0ac171f86c26d7d2da4fd03b336957bb DIFF: https://github.com/llvm/llvm-project/commit/4304d90f0ac171f86c26d7d2da4fd03b336957bb.diff LOG:

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @charles-zablit I've verified that this PR fixes `check-lldb-unit` in my local build. Thank you for fixing this! https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
ldionne wrote: I'm going to land this to attempt to unbreak libc++'s CI, which is in a really bad shape right now. From the comments above, this seems to have consensus to move forward. https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commit

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From f07c408bcbc221e69f56459d0cca27a27ed8551c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/3] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] 7ed185a - [lldb] Expose language plugin commands based based on language of current frame (#136766)

2025-05-28 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-28T11:04:57-07:00 New Revision: 7ed185a8f2b9f2436db1ccd82964424f641917e9 URL: https://github.com/llvm/llvm-project/commit/7ed185a8f2b9f2436db1ccd82964424f641917e9 DIFF: https://github.com/llvm/llvm-project/commit/7ed185a8f2b9f2436db1ccd82964424f641917e9.diff LOG:

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: > If would be really cool if when I'm in a C++ frame and I did: > > `(lldb) help demangle` > > I would get a preface like: > > Chosen from 'language cplusplus demangle' because the current frame's > language is cplusplus. I plan to do this in a follow up. Note that `help dem

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From f07c408bcbc221e69f56459d0cca27a27ed8551c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/2] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: I've updated the help description for `max-children-count` to reflect how it is applied. https://github.com/llvm/llvm-project/pull/140938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > > (on Windows)? > > That's the hard part 😅. I tried to get > https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py > to run on Windows, but it's too flaky. From my observation, the debug > adapter is too fast at launching

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I think this could be ready to land now @DavidSpickett and @JDevlieghere, could you give this another once over? https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! LGTM. https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > The warning in question is `-Wmissing-field-initializers`, which is warning > that in the unit test not all fields of this struct are explicitly > initialized. Even if these fields are optional, I think this is the wrong way > to address this: we should either update th

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/141790 >From 788cabe234336be7168996805f40da7f26fdbec9 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 28 May 2025 16:17:34 +0100 Subject: [PATCH 1/3] add explicit default initialization to DemangledName

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,16 @@ +// Copy lldb-rpc-defines.h from source. +# RUN: mkdir -p %t/input +# RUN: mkdir -p %t/output +# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input chelcassanova wrote: I changed all the tests so that the files are no longer copied fr

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Don't search for DWP files on macOS (PR #139554)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap *SymbolFileDWARF::GetDebugMapSymfile() { const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile() { llvm::call_once(m_dwp_symfile_once_flag, [this]() { +if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Don't search for DWP files on macOS (PR #139554)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/139554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/141799 >From bbef9674f7e5cf9fbc488e27dfd0e35fed23608a Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 28 May 2025 18:25:46 +0200 Subject: [PATCH] [lldb] Refactor away UB in SBValue::GetLoadAddress The problem wa

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/python_api/value/TestValueAPI.py `` View the diff

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The problem was in calling GetLoadAddress on a value in the error state, where `ValueObject::GetLoadAddress` could end up accessing the uninitialized "address type" by-ref return value from `GetAddressOf`. Thi

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141799 The problem was in calling GetLoadAddress on a value in the error state, where `ValueObject::GetLoadAddress` could end up accessing the uninitialized "address type" by-ref return value from `GetAddressOf`. This

[Lldb-commits] [lldb] [lldb] Remove unused escape code defines from status line (PR #141770)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/141770 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] caaca32 - [lldb] Remove unused escape code defines from status line (#141770)

2025-05-28 Thread via lldb-commits
Author: David Spickett Date: 2025-05-28T17:29:59+01:00 New Revision: caaca3298e4c08936d8f10df4ebc1749c8a66902 URL: https://github.com/llvm/llvm-project/commit/caaca3298e4c08936d8f10df4ebc1749c8a66902 DIFF: https://github.com/llvm/llvm-project/commit/caaca3298e4c08936d8f10df4ebc1749c8a66902.diff

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/5] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/5] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > but the I find the implementation somewhat unelegant. 😎 That's certainly me! In all seriousness, I am still drinking from the proverbial firehouse. So I appreciate the patience as I learn the codebase (even a year later). You are correct, the checks are now unimportant becaus

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/141670 >From 048cc769d6380bcb899bbcc5acf7f9349b51c5d3 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 27 May 2025 13:40:40 -0700 Subject: [PATCH 1/4] Reapply "[LLDB][ELF Core] Support all the Generic (Negative

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The warning in question is `-Wmissing-field-initializers`, which is warning that in the unit test not all fields of this struct are explicitly initialized. Even if these fields are optional, I think this is the wrong way to address this: we should either update the unit tes

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/141284 >From 2735f5ad08bd6ac5bdf31104af452f6a1abf0920 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 23 May 2025 12:20:52 -0700 Subject: [PATCH 1/2] [lldb] Use if-with-initializer pattern in SBTarget

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused escape code defines from status line (PR #141770)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141770 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 561234d - [lldb][Expression] Remove m_found_function_with_type_info in favour of boolean return (#141774)

2025-05-28 Thread via lldb-commits
Author: Michael Buch Date: 2025-05-28T16:36:48+01:00 New Revision: 561234d21cfca899ca898dd8b9c96f825a3cc1f6 URL: https://github.com/llvm/llvm-project/commit/561234d21cfca899ca898dd8b9c96f825a3cc1f6 DIFF: https://github.com/llvm/llvm-project/commit/561234d21cfca899ca898dd8b9c96f825a3cc1f6.diff

[Lldb-commits] [lldb] [lldb][Expression] Remove m_found_function_with_type_info in favour of boolean return (PR #141774)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/141774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0ac3f5e - [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (#141738)

2025-05-28 Thread via lldb-commits
Author: David Spickett Date: 2025-05-28T16:29:48+01:00 New Revision: 0ac3f5e9017b9072d80038957f41991c8a3b195c URL: https://github.com/llvm/llvm-project/commit/0ac3f5e9017b9072d80038957f41991c8a3b195c DIFF: https://github.com/llvm/llvm-project/commit/0ac3f5e9017b9072d80038957f41991c8a3b195c.diff

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > Could you add the missing initializers to the test? I think you can just add > a default value so you don't need to touch every test-case Sorry about that, fixed it with explicit default values in https://github.com/llvm/llvm-project/pull/141790. https://github.com/llv

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes https://github.com/llvm/llvm-project/pull/140762 introduces some compilation warnings in `lldb/unittests/Core/MangledTest.cpp`. This patch adds explicit default initialization to `DemangledNameInfo`

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (PR #141738)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/141790 https://github.com/llvm/llvm-project/pull/140762 introduces some compilation warnings in `lldb/unittests/Core/MangledTest.cpp`. This patch adds explicit default initialization to `DemangledNameInfo` to s

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by recuding array indexes (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix flaky DIL array subscript test by reducing array indexes (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/141738 >From ce1b2c86299944608569db2a2fa2403c8e9e2b3b Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 28 May 2025 10:15:42 + Subject: [PATCH] [lldb][test] Fix flaky DIL array subscript test by recudi

[Lldb-commits] [lldb] [lldb][Expression] Remove m_found_function_with_type_info in favour of boolean return (PR #141774)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. :+1: https://github.com/llvm/llvm-project/pull/141774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Pass `/std:...` before `--` on MSVC (PR #141782)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/141782 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread via lldb-commits
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj): args.append("-fms-compatibility-version=19") args.append("/c") +if self.std: Nerixyz wrote: Sorry, I should've asked if it's supposed to be a separate PR or com

[Lldb-commits] [lldb] [LLDB] Pass `/std:...` before `--` on MSVC (PR #141782)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes >From https://github.com/llvm/llvm-project/pull/140761. `MsvcBuilder` passed >`/std:` (if specified) after `--`, so the compiler would >interpret this as a file. This moves the argument before the `--`. ---

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/140761 >From af77293d36a6eeec3d06ded70ebdc2dcc5e97873 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 21 May 2025 17:32:48 +0200 Subject: [PATCH] [LLDB] Avoid crashes when inspecting MS STL types --- .../Language/C

  1   2   >