https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/5] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
HemangGadhavi wrote:
@labath Addressed all your comments, Please have a look once and give your
comments if any.
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -7,21 +7,24 @@
//===--===//
#include "lldb/Host/linux/Support.h"
+#include "lldb/Host/posix/Support.h"
#include "llvm/Support/Threading.h"
#include "gtest/gtest.h"
using namespace lldb_private;
TES
@@ -7,17 +7,135 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/136755
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-04-22T22:38:28-07:00
New Revision: 3ccfbc8a002e1e0f64b5408d26bc42282afc194b
URL:
https://github.com/llvm/llvm-project/commit/3ccfbc8a002e1e0f64b5408d26bc42282afc194b
DIFF:
https://github.com/llvm/llvm-project/commit/3ccfbc8a002e1e0f64b5408d26bc42282afc194b.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/136779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/134563
>From 10593fb8e4eb49576319473a7f59b445c737263b Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 22 Apr 2025 19:37:05 -0700
Subject: [PATCH] Add symbol locator time for each module in statistics
---
lld
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/include/lldb/Core/Module.h lldb/include/lldb/C
https://github.com/GeorgeHuyubo reopened
https://github.com/llvm/llvm-project/pull/134563
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/134563
>From d266e0be70876752bf5b7f58a74a125950840cc3 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 22 Apr 2025 19:37:05 -0700
Subject: [PATCH] Add symbol locator time for each module in statistics
---
lld
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/136795
Fix a [test
failure](https://github.com/llvm/llvm-project/pull/136236#issuecomment-2819772879)
in #136236 and remerge.
>From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001
From: Roy Shi
D
jasonmolenda wrote:
This patch may be all that's necessary, I haven't reproduced the failure
myself. We'd really like to have a test for this to ensure it doesn't regress,
I recently added a watchpoint API test to the testsuite as
`lldb/test/API/functionalities/watchpoint/consecutive-watchpoi
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
hapee wrote:
> I'll need to test this, I don't think it's right but I haven't looked closely
> enough at the code.
>
> We have two cases we need to support, and one of them only happens on
> AArch64/arm64 type architectures, where the watchpoint hit is reported before
> the memory is modi
@@ -135,6 +135,8 @@ if(NOT APPLE_EMBEDDED)
$/Resources/Clang/include
COMMENT "LLDB.framework: copy clang vendor-specific headers"
)
+
+ set(CLANG_RESOURCE_DIR ${clang_resource_headers_dir} CACHE FILEPATH "")
chelcassanova wrote:
Looked into
eronnen wrote:
@JDevlieghere Nice catch, now that the internal `GetDescription` gets the
private type there is no need for the `shared_ptr` eveb
https://github.com/llvm/llvm-project/pull/136755
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -138,7 +141,14 @@ bool SBInstructionList::GetDescription(lldb::SBStream
&stream) {
return GetDescription(stream.ref());
}
-bool SBInstructionList::GetDescription(Stream &sref) {
+bool SBInstructionList::GetDescription(lldb::SBStream &stream,
+
@@ -62,8 +67,8 @@ class LLDB_API SBInstructionList {
friend class SBTarget;
void SetDisassembler(const lldb::DisassemblerSP &opaque_sp);
- bool GetDescription(lldb_private::Stream &description);
-
+ bool GetDescription(lldb_private::Stream &description,
+
@@ -148,10 +158,15 @@ bool SBInstructionList::GetDescription(Stream &sref) {
const uint32_t max_opcode_byte_size =
m_opaque_sp->GetInstructionList().GetMaxOpcocdeByteSize();
FormatEntity::Entry format;
- FormatEntity::Parse("${addr}: ", format);
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136755
>From c1c072875b9a7ad3d11a03d3c1e4a8b6452749f9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 22 Apr 2025 21:58:19 +0200
Subject: [PATCH 1/3] [lldb-dap]: show load addresses in disassembly
---
lldb/inclu
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/2] Fix connecting via abstract socket
Commit 82ee31f an
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/136466
>From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Sun, 20 Apr 2025 01:11:31 +
Subject: [PATCH 1/2] Fix connecting via abstract socket
Commit 82ee31f an
@@ -138,7 +141,14 @@ bool SBInstructionList::GetDescription(lldb::SBStream
&stream) {
return GetDescription(stream.ref());
}
-bool SBInstructionList::GetDescription(Stream &sref) {
+bool SBInstructionList::GetDescription(lldb::SBStream &stream,
+
@@ -148,10 +158,15 @@ bool SBInstructionList::GetDescription(Stream &sref) {
const uint32_t max_opcode_byte_size =
m_opaque_sp->GetInstructionList().GetMaxOpcocdeByteSize();
FormatEntity::Entry format;
- FormatEntity::Parse("${addr}: ", format);
+
@@ -62,8 +67,8 @@ class LLDB_API SBInstructionList {
friend class SBTarget;
void SetDisassembler(const lldb::DisassemblerSP &opaque_sp);
- bool GetDescription(lldb_private::Stream &description);
-
+ bool GetDescription(lldb_private::Stream &description,
+
eronnen wrote:
@JDevlieghere Thanks for the review! updated the API to receive
`SBExecutionContext`
https://github.com/llvm/llvm-project/pull/136755
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -54,6 +54,10 @@ class LLDB_API SBInstructionList {
bool GetDescription(lldb::SBStream &description);
+ // Writes assembly instructions to `description` with load addresses using
+ // `frame`.
+ bool GetDescription(lldb::SBStream &description, lldb::SBFrame &frame);
--
@@ -62,8 +66,7 @@ class LLDB_API SBInstructionList {
friend class SBTarget;
void SetDisassembler(const lldb::DisassemblerSP &opaque_sp);
- bool GetDescription(lldb_private::Stream &description);
-
+ bool GetDescription(lldb_private::Stream &description, lldb::SBFrame *fr
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/136785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136755
>From c1c072875b9a7ad3d11a03d3c1e4a8b6452749f9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 22 Apr 2025 21:58:19 +0200
Subject: [PATCH 1/2] [lldb-dap]: show load addresses in disassembly
---
lldb/inclu
jasonmolenda wrote:
I'll need to test this, I don't think it's right but I haven't looked closely
enough at the code.
We have two cases we need to support, and one of them only happens on
AArch64/arm64 type architectures, where the watchpoint hit is reported before
the memory is modified.
O
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add the enum values for RISC-V CPU type and CPU subtype to llvm and use in
LLDB's ArchSpec.
---
Full diff: https://github.com/llvm/llvm-project/pull/136785.diff
3 Files Affected:
- (modified) lld
llvmbot wrote:
@llvm/pr-subscribers-llvm-binary-utilities
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add the enum values for RISC-V CPU type and CPU subtype to llvm and use in
LLDB's ArchSpec.
---
Full diff: https://github.com/llvm/llvm-project/pull/136785.diff
3 Files Affected:
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/136785
Add the enum values for RISC-V CPU type and CPU subtype to llvm and use in
LLDB's ArchSpec.
>From bb749849d514a02a3a418e87510a9d0cd0ebe8cc Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 22 Ap
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/136779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,8 +66,7 @@ class LLDB_API SBInstructionList {
friend class SBTarget;
void SetDisassembler(const lldb::DisassemblerSP &opaque_sp);
- bool GetDescription(lldb_private::Stream &description);
-
+ bool GetDescription(lldb_private::Stream &description, lldb::SBFrame *fr
@@ -54,6 +54,10 @@ class LLDB_API SBInstructionList {
bool GetDescription(lldb::SBStream &description);
+ // Writes assembly instructions to `description` with load addresses using
+ // `frame`.
+ bool GetDescription(lldb::SBStream &description, lldb::SBFrame &frame);
--
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The setter is only used when changing the setting programmatically. When using
the settings command, we need to monitor SetPropertyValue.
---
Full diff: https://github.com/llvm/llvm-project/pull/136
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/136779
The setter is only used when changing the setting programmatically. When using
the settings command, we need to monitor SetPropertyValue.
>From 23f392a73a2b29133adb8c975a5a071aeeb6cbd2 Mon Sep 17 00:00:00
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/136777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
* Fix error in lldb-dap when the stack trace contains a frame without a module
by simply showing the first 32 assembly instructions after the PC
---
Full diff: https://github.com/llvm/llvm-project/pull/136777.d
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/136777
* Fix error in lldb-dap when the stack trace contains a frame without a module
by simply showing the first 32 assembly instructions after the PC
>From 93764e39ce2588ea0f86cf8283fa6c82bd89a8de Mon Sep 17 00:00:0
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136760
>From ce512b778c9aad55c2fc0faef791cb3569a143eb Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Fri, 18 Apr 2025 18:07:05 -0700
Subject: [PATCH 1/3] [lldb] Minor improvements to
AddNamesMatchingPartialString (
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dmpots wrote:
@JDevlieghere @jimingham @clayborg
Please take a look at these open questions when you get a chance. Thanks!
https://github.com/llvm/llvm-project/pull/134418#issuecomment-2798273256
https://github.com/llvm/llvm-project/pull/134418
___
l
@@ -45,9 +49,16 @@ struct Range {
friend bool operator==(const Range &lhs, const Range &rhs) {
return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref;
}
+
+ friend bool operator<(const Range &lhs, const Range &rhs) {
+return lhs.start < rhs.start;
+ }
---
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione wrote:
Placed in draft state while I write tests.
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione converted_to_draft
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/136766.diff
2 Files Affected:
- (modified) lldb/include/lldb/Interpreter/CommandInterpreter.h (+6)
- (modified) lldb/source/Interpreter/CommandInte
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/136766
None
>From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH] [lldb] Expose language plugin commands based based on
lang
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136760
>From ce512b778c9aad55c2fc0faef791cb3569a143eb Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Fri, 18 Apr 2025 18:07:05 -0700
Subject: [PATCH 1/2] [lldb] Minor improvements to
AddNamesMatchingPartialString (
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
We want to be able to access the Clang resources directory in LLDB shell tests,
this commit adds the ability to do this by populating the `CLANG_RESOURCE_DIR`
CMake cache variable and adding it to
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/136761
We want to be able to access the Clang resources directory in LLDB shell tests,
this commit adds the ability to do this by populating the `CLANG_RESOURCE_DIR`
CMake cache variable and adding it to the LLD
@@ -456,9 +464,13 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
-? StringLayout::DSC
-: StringLayout::CSD;
+ auto index_or_
@@ -14,6 +14,7 @@
#include "llvm/Support/Format.h"
#include "llvm/Support/FormatProviders.h"
#include "llvm/Support/FormatVariadicDetails.h"
+#include
augusto2112 wrote:
For llvm the standard is to include with `""` instead of `<>`
https://github.com/llvm/ll
@@ -14,6 +14,7 @@
#include "llvm/Support/Format.h"
#include "llvm/Support/FormatProviders.h"
#include "llvm/Support/FormatVariadicDetails.h"
+#include
augusto2112 wrote:
Also I'd move this up so so it's next to the other lldb imports
https://github.com/llvm/
@@ -489,7 +490,10 @@ llvm::Error Interpret(std::vector
&control,
TYPE_CHECK(Object, String);
auto name = data.Pop();
POP_VALOBJ(valobj);
-data.Push((uint64_t)valobj->GetIndexOfChildWithName(name));
+auto index_or_err = valobj->GetIndexOf
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux`
running on `fuchsia-debian-64-us-central1-b-1` while building `lldb` at step 4
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/11/builds/13550
Here is the relevant p
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ely Ronnen (eronnen)
Changes
Improves the lldb-dap disassembly by showing load addresses in disassembly,
same as in a regular LLDB `disassemble` command by default.
Before:
![Screenshot From 2025-04-22
21-33-56](https://github.com/user-a
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/136755
Improves the lldb-dap disassembly by showing load addresses in disassembly,
same as in a regular LLDB `disassemble` command by default.
Before:
![Screenshot From 2025-04-22
21-33-56](https://github.com/user-a
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/136611
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2025-04-22T12:59:46-07:00
New Revision: 6f1adbdb2b6f21d81e491c9ddd307fca0d183850
URL:
https://github.com/llvm/llvm-project/commit/6f1adbdb2b6f21d81e491c9ddd307fca0d183850
DIFF:
https://github.com/llvm/llvm-project/commit/6f1adbdb2b6f21d81e491c9ddd307fca0d183850.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/136633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2025-04-22T12:59:13-07:00
New Revision: 66b2c343541a914e591aeae7091b97564cf534a7
URL:
https://github.com/llvm/llvm-project/commit/66b2c343541a914e591aeae7091b97564cf534a7
DIFF:
https://github.com/llvm/llvm-project/commit/66b2c343541a914e591aeae7091b97564cf534a7.diff
@@ -8,72 +8,37 @@
#include "DAP.h"
#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "Protocol/ProtocolTypes.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
+
+using namespace llvm;
+using namespace lldb_dap::protocol;
namespace lldb_dap {
-// "N
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/136633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@dmpots adding you after our conversation yesterday as an FYI
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -152,7 +152,8 @@
lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdVectorSyntheticFront
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -173,7 +173,8 @@
lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::Update() {
return ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdProxyArraySyntheti
@@ -488,10 +488,12 @@
lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::GetChildAtIndex(
return m_pair_sp->GetChildAtIndex(idx);
}
-size_t lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibCxxMapIterator
@@ -456,7 +460,7 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
+ StringLayout layout = l->GetIndexOfChildWithName("__data_").get() == 0
charles-zablit wrote:
Fix
@@ -199,10 +199,12 @@
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t StdlibCoroutineHandleSyntheticFrontEnd::GetIndexOfChildWithName(
+llvm::Expected
+StdlibCoroutineHandleSyntheticFrontEnd::Get
@@ -172,8 +173,15 @@ bool lldb_private::formatters::BlockPointerSummaryProvider(
static const ConstString s_FuncPtr_name("__FuncPtr");
- lldb::ValueObjectSP child_sp = synthetic_children->GetChildAtIndex(
- synthetic_children->GetIndexOfChildWithName(s_FuncPtr_name));
@@ -218,10 +218,11 @@ bool
ScriptedSyntheticChildren::FrontEnd::MightHaveChildren() {
return m_interpreter->MightHaveChildrenSynthProviderInstance(m_wrapper_sp);
}
-size_t ScriptedSyntheticChildren::FrontEnd::GetIndexOfChildWithName(
-ConstString name) {
+llvm::Expected
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/132395
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> which (according to the paragraph you quote) means that the function's entry
> point is 0x1cfb0, which is not the lowest address in the function.
I managed to nitpick the text but then go on to assume the ranges would be
sorted with start address increasing. Bad idea.
B
@@ -42,6 +27,21 @@ look_me_up:
.size foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
+bar:
+nop
+.Lbar_end:
+.size bar, .Lbar_end-bar
+
+.type foo,@function
+foo:
DavidSpickett wrote:
Ok I understand now. `look_me_up` is u
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -612,9 +611,9 @@
lldb_private::formatters::GenericNSArrayISyntheticFrontEnd::
}
template
-size_t
-lldb_private::formatters::GenericNSArrayISyntheticFrontEnd::
- GetIndexOfChildWithName(ConstString name) {
+llvm::Expected
+lldb_private::formatters::GenericNSArrayISyntheti
@@ -248,14 +249,17 @@
lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxVectorBoolSynthetic
@@ -1045,12 +1052,14 @@
lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
}
template
-size_t lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
+llvm::Expected
+lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
D32, D64>::GetI
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -173,7 +173,8 @@
lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::Update() {
return ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdProxyArraySyntheti
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -488,10 +488,12 @@
lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::GetChildAtIndex(
return m_pair_sp->GetChildAtIndex(idx);
}
-size_t lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibCxxMapIterator
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -20,9 +20,12 @@ class QueueFrontEnd : public SyntheticChildrenFrontEnd {
Update();
}
- size_t GetIndexOfChildWithName(ConstString name) override {
-return m_container_sp ? m_container_sp->GetIndexOfChildWithName(name)
- : UINT32_MAX;
+ l
@@ -202,8 +202,13 @@ class VariantFrontEnd : public SyntheticChildrenFrontEnd {
Update();
}
- size_t GetIndexOfChildWithName(ConstString name) override {
-return formatters::ExtractIndexFromString(name.GetCString());
+ llvm::Expected GetIndexOfChildWithName(ConstSt
@@ -152,7 +152,8 @@
lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdVectorSyntheticFront
@@ -130,9 +130,14 @@
lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::GetChildAtIndex(
return nullptr;
}
-size_t lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::
GetInd
@@ -456,7 +460,7 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
+ StringLayout layout = l->GetIndexOfChildWithName("__data_").get() == 0
Michael137 wrote:
This wo
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/132395
>From 3326940bbae82afa6b19e1ee696447a39ea3723b Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 21 Mar 2025 14:04:12 +0100
Subject: [PATCH 1/2] [lldb/DWARF] Remove "range lower than function low_pc"
check
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/132395
>From 3326940bbae82afa6b19e1ee696447a39ea3723b Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 21 Mar 2025 14:04:12 +0100
Subject: [PATCH 1/2] [lldb/DWARF] Remove "range lower than function low_pc"
check
@@ -42,6 +27,21 @@ look_me_up:
.size foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
+bar:
+nop
+.Lbar_end:
+.size bar, .Lbar_end-bar
+
+.type foo,@function
+foo:
labath wrote:
(and yes, `look_me_up` is in the middle of th
@@ -42,6 +27,21 @@ look_me_up:
.size foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
+bar:
+nop
+.Lbar_end:
+.size bar, .Lbar_end-bar
+
+.type foo,@function
+foo:
labath wrote:
It's because the range `[.Lfoo_inl.__part.1,
1 - 100 of 180 matches
Mail list logo
