llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) <details> <summary>Changes</summary> The setter is only used when changing the setting programmatically. When using the settings command, we need to monitor SetPropertyValue. --- Full diff: https://github.com/llvm/llvm-project/pull/136779.diff 2 Files Affected: - (modified) lldb/source/Core/Debugger.cpp (+3-1) - (modified) lldb/test/API/functionalities/statusline/TestStatusline.py (+3-1) ``````````diff diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp index b572210f25603..cd8726eeba632 100644 --- a/lldb/source/Core/Debugger.cpp +++ b/lldb/source/Core/Debugger.cpp @@ -257,7 +257,9 @@ Status Debugger::SetPropertyValue(const ExecutionContext *exe_ctx, else m_statusline.reset(); } else if (property_path == - g_debugger_properties[ePropertyStatuslineFormat].name) { + g_debugger_properties[ePropertyStatuslineFormat].name || + property_path == + g_debugger_properties[ePropertySeparator].name) { // Statusline format changed. Redraw the statusline. RedrawStatusline(); } else if (property_path == diff --git a/lldb/test/API/functionalities/statusline/TestStatusline.py b/lldb/test/API/functionalities/statusline/TestStatusline.py index dcededdb11e39..da6b4e7c8f320 100644 --- a/lldb/test/API/functionalities/statusline/TestStatusline.py +++ b/lldb/test/API/functionalities/statusline/TestStatusline.py @@ -46,8 +46,10 @@ def test(self): self.child.expect(re.escape("a.out | main.c:2:11 | bre")) self.child.setwinsize(terminal_height, terminal_width) + # Change the separator. + self.expect('set set separator "S "', ["a.out S main.c:2:11"]) + # Change the format. - self.expect('set set separator "S"') self.expect( 'set set statusline-format "target = {${target.file.basename}} ${separator}"', ["target = a.out S"], `````````` </details> https://github.com/llvm/llvm-project/pull/136779 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
